Edit Orders v4.0 Support Thread

[lat9]

Latest EO also has a bug which shows up editing an order which uses an order total module with recalculate taxes = Standard. You can dup with Group Pricing.

Original Order:
Sub-Total: $499.00S
Shipping: $0.00
Group Discount: -$53.39
Tax 7.0%: $31.44
Total: $477.05

After EO:
Sub-Total: $499.00S
Shipping: $0.00
Group Discount: -$53.04 (** error)
Tax 7.0%: $31.44
Total: $473.91 (** error)

@swguy, any idea where that trailing S on the sub-total is coming from? I'm guessing that that could be part of the issue.

[swguy]

Sorry - that was copy & paste cruft. Fixed.

[lat9]

Latest EO also has a bug which shows up editing an order which uses an order total module with recalculate taxes = Standard. You can dup with Group Pricing.

Original Order:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.39
Tax 7.0%: $31.44
Total: $477.05

After EO:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.04 (** error)
Tax 7.0%: $31.44
Total: $473.91 (** error)

@swguy, would you enable EO debug, update that order and send me the generated EO log file via direct email?

[swguy]

Just completed and sent.

[lat9]

... and I've replicated the issue locally. I'll post back when I've identified the root-cause.

[swguy]

Fix needed for virtual orders with no shipping address: such orders will show the message WARNING_ADDRESS_COUNTRY_NOT_FOUND
("Warning: One or more of the customer address fields contains a country name unknown to Zen Cart...")

edit_orders.php line ~ 677 change

      if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
        !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) ||
        !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])) {
        $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
      }

to

      if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
        !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country'])) {
        $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
      } else if ($order->delivery !== false && !empty($order->delivery['country'])) {
        if (!is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])) {
           $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
        }
      }

[lat9]

@swguy, what version of EO are you running? That message being displayed for virtual orders was corrected last year via this GitHub commit for EO 4.1.6.

The code segment that you refer to currently reads (edit_orders.php, line 623):

        if (!$eo->eoOrderIsVirtual ($order) &&
               ( !is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
                 !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) ||
                 !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country']) )) {
            $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
        }

[swguy]

Ah ok thanks I have 4.1.5-beta2.

[lat9]

Ah ok thanks I have 4.1.5-beta2.

Current version is 4.2.3.

[lat9]

I've just submitted v4.3.0 of Edit Orders to the Zen Cart plugins for review. That release contains changes associated with the following GitHub issues:

#50: Correct product.products_ordered calculation (thanks @siliconforks!).
#52: Correct PHP warning when an order-total doesn't include a "TAX_CLASS" setting.
#53: Additional notifiers for address-field insertions.
#54: Invalid value used in "Mock Cart" processing.
#55: Correct PHP "notify" issues.
#56: Correct order-total calculations when order-totals re-compute tax (e.g. group pricing), as reported by @swguy here.
#57: Properly report missing notifiers

I'll post back here once the download is available.