Zen Colorbox

[mc12345678]

Regarding making the lightbox responsive and post 224
https://www.zen-cart.com/showthread....21#post1339321

If the lightbox is opened, then the browser window resized, the lightbox is resized but not the contained image.
If the browser window is resized and then the lightbox is opened, the lightbox and contained image is resized.

I think in the real world that is fine for me.

The previous post about commenting out the 90% stops this from resizing at all, so I'm not sure about that conclusion.

Having been looking over the code, testing options and further researching outside of the provided documentation (also referenced below), it is apparent that a solution has not been incorporated by the original author, but I am working towards one that provides a better result for the "zoom" possibility and would also improve response when changing the orientation of a device. The previous suggested methods (defining both width AND height) caused the issue I was seeing that on zoom, it was possible that the image "window" height would become so small that there would be no image viewable. The software (as described in the author's instruction) will auto-calculate the height if just the width (or innerWidth) is provided. Regardless, a side effect was that the usage of percentage for either causes the "border" of the colorbox to expand to the edge of the screen and then again shrink when the next image is chosen. This is appears as an unexplained change and doesn't look good. To that end an internal code modification has been identified (most effective is from issue 158 of the github repo for the colorbox software) that will resize the image and colorbox together when such function is called. Some additional work is being done to support the "zoom" (resize without change in window dimensions) to allow a current image to remain at its size while zooming in/out. When the window dimensions change (desktop shrink/expand the window) the entire box will be resized. This change is easy to implement (once all code parts are identified) in the non-minimized jquery code, and the jquery can again be minimized. Some series of this will be provided in the updated plugin with a version number indicating that there were modifications made away from the author's provided code. I'm thinking that perhaps that additional resize on window resize may be a feature controllable in the admin with the default of it auto-resizing on screen size change. Me personally, when I'm on a desktop and shrink the window to make space to see something else while the image is displayed, I'd rather the image stay the same size so it is easily viewable. But that isn't strictly responsive in nature. Perhaps an option switch could be added for the user to select/control that, but that is just another development feature to consider.

Regarding possible future changes to this plugin.
It is not language-friendly as implemented.
I would suggest that the slideshow start/stop texts are moved out of the admin and into a language file along with new constants to use with the jscript override options in includes/classes/zen_colorbox/options.php
for these texts.

slideshowStart: "start slideshow",
slideshowStop: "stop slideshow",
current: "image {current} of {total}",
previous: "previous",
next: "next",
close: "close",
xhrError: "This content failed to load.",
imgError: "This image failed to load.",

documentation
The readme is a bit minimal.
I would add links to this thread and a much more prominent mention that the original authors page has a great deal of useful information there.
A note to point out that the jscript plugin offers many options which can be overridden by placing the same parameters/options in this file:
includes/classes/zen_colorbox/options.php

Agree that more ZC standard and capability could be incorporated. Thank you for identifying areas of consideration. A lot was done to the files from the previous version to support html validation and some restructuring. Wanted to do more at the time, but also wanted to keep the functionality present and available.

The reference to the author's instruction would likely reduce similar questions in the forum so yes also to be incorporated in the near future.

Thank you.