Image Handler 5 (for v1.5.5 - v1.5.8) Support Thread

[lat9]

Extra eyes are always a good thing! Thanks @simon1066!

[simon1066]

In case it helps. Playing around with bmz_image_handler.class.php

changing line #449

from

$this->force_canvas = (strpos($pref_width . $pref_height, '!') !== false);

to

$this->force_canvas = (strpos($pref_width . $pref_height, '!') == false);

produces desired result, canvas is displayed.

I mention this without knowing the implications such a code change.

[lat9]

Thanks, @simon1066; that gives me something to "chew on".

P.S. You'll probably want to change that to === false (exactly equal)

[lat9]

@simon1066, I've created an issue on the IH GitHub (https://github.com/DivaVocals/zen_Im...ler/issues/169) and posted a correction. Please note that the change was different than that which you'd posted!

[simon1066]

@simon1066, I've created an issue on the IH GitHub (https://github.com/DivaVocals/zen_Im...ler/issues/169) and posted a correction. Please note that the change was different than that which you'd posted!

Thank you, I'll take a look. Glad that it's different as I found there were issues with my suggestion.

[lat9]

Thank you, I'll take a look. Glad that it's different as I found there were issues with my suggestion.

There are a couple more changes also staged for v1.5.4 of IH-5 that address other issues you've noted above, too!

[lat9]

There are a couple more changes also staged for v1.5.4 of IH-5 that address other issues you've noted above, too!

I'm being dyslexic, that should be v5.1.4!

[Hasher]

Hi Lat9 ,


Setting up my site now . I am wondering what is the best size and format to give IH? For example JPG , BMP , TIF

Trying to optimize my website for IH!


Thanks in advance !

[lat9]

I'd suggest going with .jpg. That image type resizes the best of all of them (and .tif isn't supported by IH).

[simon1066]

ZC v1.5.6b
IH5 v5.1.4beta (issue probably exists in v5.1.3)

Not sure if this is a bug (or indeed that I can explain it clearly),

A category has two identical products (apart from the name) of Product Type 2 (product_music handler) 'Add to Cart = N'

In Admin > Tools > IH5 the zen_draw_products_pull_down for that category only shows one product, but I can scroll between the two using the Prev/Next buttons.

Looking at the code in image_handler.php it seems that if I comment out the lines that hides things that cannot go in the cart (lines 313 - 319), like this

 //  $not_for_cart = $db->Execute(
       //     "SELECT p.products_id 
        //       FROM " . TABLE_PRODUCTS . " p 
        //            LEFT JOIN " . TABLE_PRODUCT_TYPES . " pt 
        //                ON p.products_type= pt.type_id 
        //      WHERE pt.allow_add_to_cart = 'N'"
       // );

I can get both products to show - this sort of makes sense but I can't see why one product would show.

I would say that perhaps IH5 release code should have it commented but I think there's something else going on here because another category with products of Product Type 3 (document_general handler) 'Add to Cart = N' shows all products regardless of whether the above code is commented out or not.

I am using the github v5.1.4beta code although I haven't tested by fully reverting to v5.1.3 - the zen_draw_products_pull_down code in image_handler.php hadn't changed.