includes/modules/pages/checkout_one_confirmation/header_php.php line 129 is
Do you think the call to zen_clean_html is absolutely required? I'm asking because I don't think the standard checkout does this operation.Code:$_SESSION['comments'] = (zen_not_null ($_POST['comments'])) ? zen_clean_html ($_POST['comments']) : '';
In the standard checkout, a comment entry like:
line1
line2
line3
has the line breaks preserved, but in OPC, because of the zen_clean_html operation, they are all put on one line.
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
Fantastic! Thank you Cindy!
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
@swguy, I've chosen to correct the issue a bit differently, changing that line to read:
When using zen_output_string_protected, I found that simple double-quotes (") were being converted to "'s ... which I didn't like. I mean, what if the customer wanted to leave a simple comment like I'd like a margin of 2".?Code:$_SESSION['comments'] = (!empty($_POST['comments'])) ? htmlspecialchars($_POST['comments'], ENT_NOQUOTES, CHARSET, true) : '';
The update is being tracked via this GitHub issue: https://github.com/lat9/one_page_checkout/issues/219
Are you sure that provides sufficient protection?
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
Version of Zencart: Latest
Template: fluorspar
No other plugins added
I am getting a very strange message in my admin area, "The One-Page Checkout plugin has been disabled. The file "/homepages/20/{d*****}/htdocs/****/certuk/includes/templates/fluorspar/jscript/jscript_framework.php" is required for the plugin's proper operation."
Last edited by adb34; 24 Oct 2019 at 04:09 PM.
Learning Fast.
Eden Craft Supplies
Not strange, that's OPC's way of letting you know that it's not going to allow itself to be enabled if it's not going to work! OPC relies on the AJAX interface provided by the jscript_framework.php module to do its thing.
Assuming that the 'Latest' version is zc156c, you can copy the file /includes/templates/responsive_classic/jscript/jscript_framework.php to /includes/templates/fluorspar/jscript/jscript_framework.php to allow OPC to be enabled.
Please note that simply enabling OPC on that template doesn't mean that it's going to work. I have no familiarity with that template, but if it's not providing the jscript_framework.php that's been around since zc154 ...
Bookmarks