Winchester Responsive

[dharrison]

It works!!! Thank you swguy You have made my day.

[swguy]

Glad that helped. Move slowly to PHP 7.0 then 7.1 then 7.2 fixing issues as you go - this template hasn't been updated in a while IIRC.

[mikecnz]

Hi,

Have upgraded on a local host to 1.5.6c (using WAMP with PHP 7.3.12) and am recieving the following warnings:

[23-Jul-2020 02:08:16 UTC] Request URI: /new/, IP address: ::1
#1 require(C:\wamp64\www\New\includes\templates\winchester_responsive\templates\tpl _modules_mobile_categories_tabs.php) called at [C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_header.php :102]
#2 require(C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_he ader.php) called at [C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_main_page. php:181]
#3 require(C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_ma in_page.php) called at [C:\wamp64\www\New\index.php:97]
--> PHP Warning: Use of undefined constant MODULE_ORDER_TOTAL_GV_STATUS - assumed 'MODULE_ORDER_TOTAL_GV_STATUS' (this will throw an Error in a future version of PHP) in C:\wamp64\www\New\includes\templates\winchester_responsive\templates\tpl_modules _mobile_categories_tabs.php on line 71.

[23-Jul-2020 02:08:16 UTC] Request URI: /new/, IP address: ::1
#1 require(C:\wamp64\www\New\includes\templates\winchester_responsive\templates\tpl _modules_mobile_categories_tabs.php) called at [C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_header.php :102]
#2 require(C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_he ader.php) called at [C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_main_page. php:181]
#3 require(C:\wamp64\www\New\includes\templates\winchester_responsive\common\tpl_ma in_page.php) called at [C:\wamp64\www\New\index.php:97]
--> PHP Warning: Use of undefined constant MODULE_ORDER_TOTAL_COUPON_STATUS - assumed 'MODULE_ORDER_TOTAL_COUPON_STATUS' (this will throw an Error in a future version of PHP) in C:\wamp64\www\New\includes\templates\winchester_responsive\templates\tpl_modules _mobile_categories_tabs.php on line 74.

I have coupons and gift certificates turned off - turning them on removes the warning.

Below is the code for lines 71 and 74:

71 <?php if (MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>

74 <?php if (MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>

I tried to alter this to the following (on the off chance it would work - as I really have no idea):

71 - <?php if (defined(MODULE_ORDER_TOTAL_GV_STATUS == 'true') ) { ?>

74 - <?php if (defined(MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') ) { ?>

However, it made no difference - any help would be appreciated.

Thanks,

[mikecnz]

Hi,

I have found a solution to the above (i think)...

I replaced lines 71-74 of includes\templates\winchester_responsive\templates\tpl_modules _mobile_categories_tabs.php

with this code taken from the responsive classic template - tpl_modules_mobile_menu

<?php if (defined('MODULE_ORDER_TOTAL_GV_STATUS') && MODULE_ORDER_TOTAL_GV_STATUS == 'true') { ?>
<li><a href="<?php echo zen_href_link(FILENAME_GV_FAQ); ?>"><?php echo BOX_INFORMATION_GV; ?></a></li>
<?php } ?>
<?php if (DEFINE_DISCOUNT_COUPON_STATUS <= 1 && defined('MODULE_ORDER_TOTAL_COUPON_STATUS') && MODULE_ORDER_TOTAL_COUPON_STATUS == 'true') { ?>
<li><a href="<?php echo zen_href_link(FILENAME_DISCOUNT_COUPON); ?>"><?php echo BOX_INFORMATION_DISCOUNT_COUPONS; ?></a></li>
<?php } ?>

No more warnings or issues (so far).

Regards,

Mike

[mikecnz]

Hi,

Further to the above, I am having issues in Chrome on the detailed product listing page see:
https://www.cammellshoney.co.nz/mult...-Raw-Honey-1kg for example. The page works fine in Firefox, but throughs a tantrum in Chrome:

Uncaught TypeError: Cannot convert undefined or null to object
at Function.keys (<anonymous>)
at e.prune (addthis_widget.js:formatted:14754)
at e.add (addthis_widget.js:formatted:14739)
at Object.i [as log] (addthis_widget.js:formatted:14811)
at i (addthis_widget.js:formatted:10390)
at addthis_widget.js:formatted:9905
at HTMLDocument.onReady (addthis_widget.js:formatted:9838)

and

Uncaught ReferenceError: $info is not defined
at HTMLLIElement.activate (umf-15-manuka-honey-250gm:386)
at HTMLDivElement.<anonymous> (easyResponsiveTabs.js:23)
at HTMLDivElement.dispatch (jquery-3.3.1.min.js:2)
at HTMLDivElement.y.handle (jquery-3.3.1.min.js:2)
at Object.trigger (jquery-3.3.1.min.js:2)
at HTMLLIElement.<anonymous> (jquery-3.3.1.min.js:2)
at Function.each (jquery-3.3.1.min.js:2)
at w.fn.init.each (jquery-3.3.1.min.js:2)
at w.fn.init.trigger (jquery-3.3.1.min.js:2)
at HTMLLIElement.<anonymous> (easyResponsiveTabs.js:139)

I believe the section below is responsible for the 2nd listed error, but have no idea in relation to the first:

<script src="includes/templates/winchester_responsive/jscript/easyResponsiveTabs.js" type="text/javascript"></script>
<script type="text/javascript">
$(document).ready(function () {
$('#horizontalTab').easyResponsiveTabs({
type: 'default', //Types: default, vertical, accordion
width: 'auto', //auto or any width like 600px
fit: true, // 100% fit in a container
activate: function(event) { // Callback function if tab is switched
var $tab = $(this);
var $name = $('span', $info);

$name.text($tab.text());

$info.show();
}
});

Any thoughts or pointers would be appreciated.

[dbltoe]

Not sure.

WAG > a few CSS errors and the image for the honey should not have any spaces in the name. Several of your images have spaces.

Also, you use

target="_blank "

versus the correct

target="_blank"

(again a space problem) on the Terms and Conditions link.

Lastly, a lonely <center> call in the slideout. You should use CSS for centering.

What's weird is all the cookies it's trying to throw out there. Are you attempting to use cloudflare?

Not seeing a problem with the site loading.

[mikecnz]

Hi,

Thanks for pointing out the CSS issues - as a side note (with the exception of the image naming conventions) these are issues with the Winchester Responsive template plugin.

For anyone interested the code that produces target="_blank " - is in includes/modules/winchester-responsive/flexible_footer_menu.php - at line 35.

The lonely center call in the slideout is at line 53 of includes/languages/english/extra_definitions/winchester_responsive/winchester_responsive_defines.php

The template is calling cloudflare at:
line 98 of /includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php
code is <script src="http://cdnjs.cloudflare.com/ajax/libs/jquery-easing/1.3/jquery.easing.min.js" type="text/javascript"></script>
I have changed this to <script src="//cdnjs.cloudflare.com/ajax/libs/jquery-easing/1.3/jquery.easing.min.js" type="text/javascript"></script> as per instructions in post 831 of this thread.
If there is a better alternative it would be helpful not only for me but for all other uses of this template.

Now back to the original issue:
The chrome browser has issues with the javascript as used by the template - I can see this not just on my website, but on others and on a demo version
https://winchester156.zencartdemo.at...&products_id=1
http://cityflyers.co.uk/advertising-...nting-delivery
https://www.qbis.co.uk/all-christmas...4hivid3cmdhvt6

Clicking through the tabs on any of these (review, details, etc) will lead to the Uncaught ReferenceError: $info is not defined.
The addthis_widget relates to the social media sharing icons below the add to cart button (if you look at one of my products or the cityflyers page in Firefox you will see this working correctly) – in Chrome it leads to the Uncaught TypeError: Cannot convert undefined or null to object.

In Chrome it also leads to layout issues and the social media sharing buttons not showing.

Chrome Version is 84.0.4147.125 (Official Build) (64-bit).

[mikecnz]

Further to the above:
I managed to fix the layout of the responsive tabs in Chrome by placing the <br class="clearBoth" /> at line 173 of tpl_product_info_display.

Still no luck on the javascript errors.

[mikecnz]

Above should have read "by placing the <br class="clearBoth" /> at line 173 of tpl_product_info_display inside a div"

[simon1066]

Hi,

Further to the above, I am having issues in Chrome on the detailed product listing page see:

......Uncaught ReferenceError: $info is not defined.....

I believe the section below is responsible for the 2nd listed error, but have no idea in relation to the first:

<script src="includes/templates/winchester_responsive/jscript/easyResponsiveTabs.js" type="text/javascript"></script>
<script type="text/javascript">
$(document).ready(function () {
$('#horizontalTab').easyResponsiveTabs({
type: 'default', //Types: default, vertical, accordion
width: 'auto', //auto or any width like 600px
fit: true, // 100% fit in a container
activate: function(event) { // Callback function if tab is switched
var $tab = $(this);
var $name = $('span', $info);

$name.text($tab.text());

$info.show();
}
});

Any thoughts or pointers would be appreciated.

@mikecnz, responding to your PM. I have not found a resolution for this. Having repurposed the responsive tabs from Westminster New/Winchester Responsive for use in my own template I've since found that it is also an issue on the template author's demo page - so it's not me/us.

It seems that the following line, in red, was removed from the original plugin - causing the above error:

activate: function(event) { // Callback function if tab is switched
                var $tab = $(this);
                var $info = $('#nested-tabInfo');
                var $name = $('span', $info);
                $name.text($tab.text());
                $info.show();

perhaps it was removed to avoid the url being changed when switching tabs. With little knowledge I've played around, trying to resolve this - no luck.