Error when installing the shipping surcharge module

[carlwhat]

@mc12345678 you are wrong.

the keys method is not the place to install configuration values. if one were to add the global $db declaration in said method, what happens when we call the install method, and we try to execute lines 127 and 128? we would now have an attempt to insert a duplicate key into the configuration table. (i can't remember which method gets called first, the result is the same.)

i would encourage you to test your recommendations (as i did) prior to making them. adding the global $db declaration just causes a new error. and, to me, it's pretty clear where the config values should get installed.... in the install method.

this is the answer and the best help for the OPs issue.

[mc12345678]

@mc12345678 you are wrong.

the keys method is not the place to install configuration values. if one were to add the global $db declaration in said method, what happens when we call the install method, and we try to execute lines 127 and 128? we would now have an attempt to insert a duplicate key into the configuration table. (i can't remember which method gets called first, the result is the same.)

i would encourage you to test your recommendations (as i did) prior to making them. adding the global $db declaration just causes a new error. and, to me, it's pretty clear where the config values should get installed.... in the install method.

this is the answer and the best help for the OPs issue.

And apparently you missed the memo. Ways of installing/upgrading are to not require removal in order to upgrade. Been that way for a few zen Cart versions. Not sure what type of purist you are, but the keys method is out of the way of routine operation as once the missing keys are present there's no need to check again.

So looks like with that added information about the additional install issue that the query for the two newly added keys within the related install method should each start with insert ignore.

[swguy]

A couple of flubs on my part - as noted above, the $db variable needs to be global'ed but also the INSERT in keys() - which saves a remove/reinstall for upgraders - should *only* be done if the module is already installed. This provides an easier path for users to update plugins which might have new configuration keys. See (for example) authorizenet.php line 525.

Will update this module shortly.