i will look at it when i can...
best.
Great thank you. Below fixes the one issue where the company name is not being populated when adding a new address from the update_card page.
Around line 603 added the line that is in green below:
$return['company'] = $_POST['company'];
PHP Code:if ($_POST['address_selection'] == 'new') {
$this->addNewAddress();
$return['firstname'] = $_POST['firstname'];
$return['lastname'] = $_POST['lastname'];
$return['company'] = $_POST['company'];
$return['street_address'] = $_POST['street_address'];
$return['city'] = $_POST['city'];
if (empty($_POST['zone_id'])) {
$return['state'] = $_POST['state'];
} else {
$return['state'] = zen_get_zone_name($_POST['zone_country_id'], $_POST['zone_id'],
($_POST['state'] ?? ''));
}
$return['postcode'] = $_POST['postcode'];
$return['country']['title'] = zen_get_country_name($_POST['zone_country_id']);
The following are just recommendations for a future update to this module:
1: The billing address address book id is not being saved so when you go to update a credit card you do not know which address is currently associated with that CC # on authorize.net
2: When capturing the credit card store what type of card it is like Visa, Master Card, Amex, Discover. That can then be used to show the credit card's logo associated with the credit card being updated on the card_update page.
3: Shipping address is not being populated on authorize.net Transaction Detail page at time of order, that is helpful to have as a backup way of confirming what shipping address was selected by a customer when the order was placed.
Last edited by marcopolo; 11 Nov 2022 at 06:53 PM.
marco,
i would suggest using the public github repo as opposed to having these discussions here.
best.
this has been fixed on the repo.
this has also been fixed on the repo.
i'm not sure about these recommendations. i will give them some thought.
my opinion is that auth.net is for getting paid. it is not for verifying order details.
1. i have never felt that the address is necessary to save and to verify it. currently every zen-cart order has 3 address fields; so now you want to verify the credit card address with the zen-cart address? i have never been a fan of ensuring that the billing address with the credit card is in the ZC db. most times it already is... but for me, have auth.net validate the card details, send me a token, and as long as that token works, use that for charging a customer. feel free to convince me other wise (although lets move it over to an issue on the repo...).
2. a database change. maybe.
3. codd-date normal form. if auth.net does not match, which address are you going to use?
in the 10+ years this module has been in use at my clients, they have never made these requests. but maybe...
1: Real world use in my companies case is sometimes customers will state that they selected a shipping address and that we sent it to the wrong address and this is just another way to confirm what was captured at the time of order. We could login to auth's website to confirm what was captured at the time of order. Not a big deal just that extra spot to check something.
3: If I was a customer and recently moved I would change my stored billing addresses with companies I have stored cc's with. The update card page edit cc section now does not show what address is stored for the credit card just gives a list of address(s) I have in my address book. So if I was the customer and was trying to update this I (me personally) would select the address or add a new one if not listed then submit. I would then go back in to verify it is now the billing address.
This is where I pointed out the recommendation for capturing the address id so it can be confirmed back to the customer that the billing address has been updated if they want to confirm it.
If you do update the logic on this page I would simply store the address id that the customer selected for the card and if still in the database have it be auto be selected with a message saying current billing next to the address. If the address has been deleted over time then keep current logic in which case the customer will update the address and if goes back into the screen to verify it will work as intended.
Note there is a bug now if you try updating the address it says you did but does not update on auth's website.
Last edited by marcopolo; 12 Nov 2022 at 04:58 PM.
Two more feature ideas I had for this module.
1: Allow customer to set a default card to be auto selected at checkout if they have multiple cards saved.
2: If an ADMIN is placing the order give an option to Authorize only or Authorize+Capture the sale at checkout.
@carlwhat would you please review and provide feedback for:
https://docs.zen-cart.com/user/payme...horizenet_cim/
I just realized last week that there was no documentation for this plugin.
That Software Guy. My Store: Zen Cart Support
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.