Has anyone tested this fix with both options for Display Prices with Tax?
Has anyone tested this fix with both options for Display Prices with Tax?
Are You Vulnerable for an Accessibility Lawsuit?
myZenCartHost.com - Zen Cart Certified, PCI Compatible Hosting by JEANDRET
Free SSL & Domain with semi-annual and longer hosting. Updating 1.5.2 and Up.
If anyone has the time to see if the current master branch in the Zen Cart GitHub (https://github.com/zencart/zencart) has corrected this issue, I'd appreciate it. There were a slew of changes in the pricing calculations (most of them hovering around the addition of Wholesale Pricing) that I believe have corrected these issues.
From my simple testing , it has.
Display Prices with Tax = false; Display Prices with Tax in Admin = false ; Tax rate (GST) = 10%
Item $1.60 each; add ten to cart; price displayed is $14.55;
Step 2 of 3 display payment information: Sub-Total = $14.55; Tax = $1.45; Total = $16.00
OldNGrey
ZC158a PHP 8.2.15
MySQL 10.6.16-MariaDB
The latest changes (#6017) show the correct Sub-Total but the Tax is incorrect.
Settings: Display Prices with Tax = true; Display Prices with Tax in Admin = true; Tax (GST) = 10%; Basis of Product Tax = Shipping
Item is $1.60; add 10 to cart; Sub-total = $16.00
Screen 2 of 3 - Payment information: Sub-Total = $16.00; Tax = $1.50; Total = $16.00.
Tax should be $1.45. [ $16.00 / 11 * 10 = 14.55 (14.5454 round to 2 places)]
OldNGrey
ZC158a PHP 8.2.15
MySQL 10.6.16-MariaDB
Thanks for that; I'll get that modeled locally and see what I can do to correct.
GitHub issue opened: https://github.com/zencart/zencart/issues/6094
Thanks lat9. That works with all my testing.
Is far more accurate than it has been in the past.
There can be some minor variances which I think come from the original calculation of the product price. When the gross price is entered, ZC manipulates the Net price to its own calculation. The displayed price may not be the same as the stored price eg
Product Price
Entered stored(Gross) (Net) displayed as
5.00 5.0001 4.5455 5.00
4.999 4.999 4.5445 5.00
4.998 4.998 4.5436 5.00
5.001 5.001 4.5464 5.00
This is a different issue.
OldNGrey
ZC158a PHP 8.2.15
MySQL 10.6.16-MariaDB
@todonada, have you tested to see if the code in the current GitHub master branch (https://github.com/zencart/zencart) corrects this issue? I'm pretty sure that this was one of the test cases I used when making those pricing-calculation updates.
Bookmarks