PayPal RESTful API Payment Module

[Jeff_Mash]

Cindy - I posted this on the GitHub repository, but thought I'd include it here in case it helps get more attention:

Version v1.0.4.

I am noticing an issue in our system. When a customer places a PayPal order (not all the time, but a lot), the STATE that is being sent to PayPal is "California" where we are based.

For example, in ZenCart database, the address in both the Customer and the Orders Table is:

1234 Newbank Circle Suite 207
Dublin, OH 43017

But when I pull up PayPal to look if the address is verified, I see this on PayPal:

1234 Newbank Circle Suite 207
Dublin, CA 43017

I have seen this with multiple orders now, where the order looks fine in ZenCart, but when pulling it up on PayPal's website, they have "CA" as the state.

Is this a bug or perhaps is there something I need to check with my current installation?

I checked the "ipn_1732546861_MsKv7.log" file created for this example order and it shows "CA" as the state being pushed to PayPal, so something within our installation is sending that incorrect state to PayPal.

UPDATE: This doesn't seem to happen with every order.......but when it did, I noticed another WARNING LOG for the same transaction (ipn_1732546861_MsKv7-warning.log)

It seems that that warning log may indicate what is causing CA to be passed as the state to PayPal?

[lat9]

Cindy - I posted this on the GitHub repository, but thought I'd include it here in case it helps get more attention:

Version v1.0.4.

I am noticing an issue in our system. When a customer places a PayPal order (not all the time, but a lot), the STATE that is being sent to PayPal is "California" where we are based.

For example, in ZenCart database, the address in both the Customer and the Orders Table is:

1234 Newbank Circle Suite 207
Dublin, OH 43017

But when I pull up PayPal to look if the address is verified, I see this on PayPal:

1234 Newbank Circle Suite 207
Dublin, CA 43017

I have seen this with multiple orders now, where the order looks fine in ZenCart, but when pulling it up on PayPal's website, they have "CA" as the state.

Is this a bug or perhaps is there something I need to check with my current installation?

I checked the "ipn_1732546861_MsKv7.log" file created for this example order and it shows "CA" as the state being pushed to PayPal, so something within our installation is sending that incorrect state to PayPal.

UPDATE: This doesn't seem to happen with every order.......but when it did, I noticed another WARNING LOG for the same transaction (ipn_1732546861_MsKv7-warning.log)

It seems that that warning log may indicate what is causing CA to be passed as the state to PayPal?

PayPal RESTful doesn't make use of IPNs and none of its generated logs start with ipn_ ... so I'm not sure where those logs are coming from.

[Jeff_Mash]

PayPal RESTful doesn't make use of IPNs and none of its generated logs start with ipn_ ... so I'm not sure where those logs are coming from.

Yeah, I don't know either. I just noticed that at the exact same time as the PayPal transaction occurred (with the incorrect STATE being passed to PayPal), I had that corresponding IPN log file, which references the ipn_main_handler.php.

If you look at the contents of that IPN warning log, you can see that it references the PayPal IPN as well as the freeoptions.php.

When I look at my Payment Modules, only paypalr is enabled. The other two (paypaldp and paypalwpp) are orange (disabled). Perhaps I should actually REMOVE them and see if that helps?

[lat9]

Yeah, I don't know either. I just noticed that at the exact same time as the PayPal transaction occurred (with the incorrect STATE being passed to PayPal), I had that corresponding IPN log file, which references the ipn_main_handler.php.

If you look at the contents of that IPN warning log, you can see that it references the PayPal IPN as well as the freeoptions.php.

When I look at my Payment Modules, only paypalr is enabled. The other two (paypaldp and paypalwpp) are orange (disabled). Perhaps I should actually REMOVE them and see if that helps?

It depends on whether you have any orders paid with those payment modules that might need an update (i.e. a refund or a capture). If all orders paid with them are cleared, then removing them would (I think) also deactivate the ipn_main_handler.php operations.

[Jeff_Mash]

It depends on whether you have any orders paid with those payment modules that might need an update (i.e. a refund or a capture). If all orders paid with them are cleared, then removing them would (I think) also deactivate the ipn_main_handler.php operations.

Well, I removed the old paypalwpp and paypald from the system. Yet, I still get the incorrect STATE passed to PayPal with the paypal restful module.

Only seems to happen with the Paypal Restful module on certain orders (and both using PayPal or Credit Card).

For example:

Order comes in like this:

Customer Address:
Joe Shmoe
119A Jamestown Dr
P.O. Box 303
Sitka Alaska 99835

Sub-Total: $59.90
United States Postal Service (Priority Mail® (2 - 3 days)): $13.79
Shipping Insurance (Recommended): $3.00
Total: $76.69


But on PayPal, I see:

Joe Shmoe
119A Jamestown Dr
P.O. Box 303
Sitka, CA 99835
UNITED STATES

In the logs, I see this warning created at the same exact time:

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/ipn_main_handler.php(352): zen_debug_error_handler()
--> PHP Warning: Undefined array key "payment" in /home/domain/public_html/store/ipn_main_handler.php on line 352.

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/ipn_main_handler.php(353): zen_debug_error_handler()
--> PHP Warning: Undefined array key "shipping" in /home/domain/public_html/store/ipn_main_handler.php on line 353.

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(104): zen_debug_error_handler()
#1 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(85): freeoptions->update_status()
#2 /home/domain/public_html/store/includes/classes/shipping.php(91): freeoptions->__construct()
#3 /home/domain/public_html/store/ipn_main_handler.php(353): shipping->__construct()
--> PHP Warning: Attempt to read property "delivery" on null in /home/domain/public_html/store/includes/modules/shipping/freeoptions.php on line 104.

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(104): zen_debug_error_handler()
#1 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(85): freeoptions->update_status()
#2 /home/domain/public_html/store/includes/classes/shipping.php(91): freeoptions->__construct()
#3 /home/domain/public_html/store/ipn_main_handler.php(353): shipping->__construct()
--> PHP Warning: Trying to access array offset on value of type null in /home/domain/public_html/store/includes/modules/shipping/freeoptions.php on line 104.

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(104): zen_debug_error_handler()
#1 /home/domain/public_html/store/includes/modules/shipping/freeoptions.php(85): freeoptions->update_status()
#2 /home/domain/public_html/store/includes/classes/shipping.php(91): freeoptions->__construct()
#3 /home/domain/public_html/store/ipn_main_handler.php(353): shipping->__construct()
--> PHP Warning: Trying to access array offset on value of type null in /home/domain/public_html/store/includes/modules/shipping/freeoptions.php on line 104.

[11-Dec-2024 05:36:56 America/Los_Angeles] Request URI: /store/ipn_main_handler.php, IP address: 173.0.81.140, Language id 1
#0 /home/domain/public_html/store/includes/modules/order_total/ot_shipping.php(67): zen_debug_error_handler()
#1 /home/domain/public_html/store/includes/classes/order_total.php(72): ot_shipping->process()
#2 /home/domain/public_html/store/ipn_main_handler.php(365): order_total->process()
--> PHP Warning: Undefined array key "country_id" in /home/domain/public_html/store/includes/modules/order_total/ot_shipping.php on line 67.

Everything gets processed fine in PayPal EXCEPT for the customer's state. Whenever this happens, the customer's state always says "CA" instead of their actual state on the ZenCart side of the transaction.

Why is this a big deal?

Because PayPal will only offer Seller Protection if you ship to the exact same address in their posted transaction. But if all the addresses are showing the incorrect state, it could violate any Seller Protection that we have. Meaning, any chargebacks or disputes will be automatically found in the buyer's favor even if you have proper proof of delivery (because you are delivering to the correct address and not to the incorrect address on PayPal).

[swguy]

Getting an issue related to PayPal REST checkout when products have a checkbox in their attribute configuration. Zen Cart 2.0.1. PP Rest 1.0.4. Bootstrap 3.7.4.

In CreatePayPalOrderRequest.php, should the constructor strip off the "_chk" that is added to the customers_basket_attributes entry on includes/classes/shopping_cart.php line 355?

Log here:

[14-Dec-2024 06:38:46 America/Denver] Request URI: /shop/index.php?main_page=checkout_confirmation, IP address: 2601:188:c404:8520:39bb:5ae1:e114:c498, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(714): trigger_error()
#2 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(659): queryFactory->show_error()
#3 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(299): queryFactory->set_error()
#4 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(291): queryFactory->Execute()
#5 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(237): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->isProductPhysical()
#6 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(98): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->getItems()
#7 /home2/client/public_html/shop/includes/modules/payment/paypalr.php(1102): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->__construct()
#8 /home2/client/public_html/shop/includes/modules/payment/paypalr.php(940): paypalr->createPayPalOrder()
#9 /home2/client/public_html/shop/includes/classes/payment.php(248): paypalr->pre_confirmation_check()
#10 /home2/client/public_html/shop/includes/modules/pages/checkout_confirmation/header_php.php(92): payment->pre_confirmation_check()
#11 /home2/client/public_html/shop/index.php(35): require('/home2/client...')
--> PHP Fatal error: MySQL error 1054: Unknown column '3_chk7' in 'where clause' :: SELECT products_attributes_id
               FROM zen_products_attributes_download
              WHERE products_attributes_id IN (
                    SELECT products_attributes_id
                      FROM zen_products_attributes
                     WHERE products_id = 1807
                       AND ((options_id = 30 AND options_values_id = 0) OR (options_id = 32 AND options_values_id = 0) OR (options_id = 31 AND options_values_id = 0) OR (options_id = 33 AND options_values_id = 0) OR (options_id = 3_chk7 AND options_values_id = 7) OR (options_id = 5 AND options_values_id = 11)
                       )
                    ) ==> (as called by) /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php on line 291 <== in /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php on line 714.

[lat9]

Getting an issue related to PayPal REST checkout when products have a checkbox in their attribute configuration. Zen Cart 2.0.1. PP Rest 1.0.4. Bootstrap 3.7.4.

In CreatePayPalOrderRequest.php, should the constructor strip off the "_chk" that is added to the customers_basket_attributes entry on includes/classes/shopping_cart.php line 355?

Log here:

[14-Dec-2024 06:38:46 America/Denver] Request URI: /shop/index.php?main_page=checkout_confirmation, IP address: 2601:188:c404:8520:39bb:5ae1:e114:c498, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(714): trigger_error()
#2 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(659): queryFactory->show_error()
#3 /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php(299): queryFactory->set_error()
#4 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(291): queryFactory->Execute()
#5 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(237): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->isProductPhysical()
#6 /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php(98): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->getItems()
#7 /home2/client/public_html/shop/includes/modules/payment/paypalr.php(1102): PayPalRestful\Zc2Pp\CreatePayPalOrderRequest->__construct()
#8 /home2/client/public_html/shop/includes/modules/payment/paypalr.php(940): paypalr->createPayPalOrder()
#9 /home2/client/public_html/shop/includes/classes/payment.php(248): paypalr->pre_confirmation_check()
#10 /home2/client/public_html/shop/includes/modules/pages/checkout_confirmation/header_php.php(92): payment->pre_confirmation_check()
#11 /home2/client/public_html/shop/index.php(35): require('/home2/client...')
--> PHP Fatal error: MySQL error 1054: Unknown column '3_chk7' in 'where clause' :: SELECT products_attributes_id
               FROM zen_products_attributes_download
              WHERE products_attributes_id IN (
                    SELECT products_attributes_id
                      FROM zen_products_attributes
                     WHERE products_id = 1807
                       AND ((options_id = 30 AND options_values_id = 0) OR (options_id = 32 AND options_values_id = 0) OR (options_id = 31 AND options_values_id = 0) OR (options_id = 33 AND options_values_id = 0) OR (options_id = 3_chk7 AND options_values_id = 7) OR (options_id = 5 AND options_values_id = 11)
                       )
                    ) ==> (as called by) /home2/client/public_html/shop/includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php on line 291 <== in /home2/client/public_html/shop/includes/classes/db/mysql/query_factory.php on line 714.

Yep, thanks for the report. GitHub issue for tracking: https://github.com/lat9/paypalr/issues/46

I'll be adding the highlighted castings to line 292 of /includes/modules/payment/paypal/PayPalRestful/Zc2Pp/CreatePayPalOrderRequest.php

        $attributes_where = [];
        foreach ($product['attributes'] as $next_att) {
            $attributes_where[] = '(options_id = ' . (int)$next_att['option_id'] . ' AND options_values_id = ' . (int)$next_att['value_id'] . ')';
        }

[swguy]

Thank you for the quick resolution!

[swguy]

Verified working perfectly!

[lat9]

v1.0.5 of the payment-module is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2382

This release contains changes associated with the following GitHub issues:

#40: Send current billing address for PayPal Wallet payments.
#41: Correct alternate payment-module pre-selected on checkout_payment page
#42: Don't send payment request to PayPal if there are existing payment-related messages to be displayed.
#43: Use language-constants for additional status-history record's information.
#44: Remove intervening spaces from addresses' postal_codes.
#46: Correct MySQL error when checking out with a checkbox-type attributed product.