Edit Orders v4.0 Support Thread

[mcqueeneycoins]

Hi all, just recently installed EO 4.7.1 on my site and having some issues with sales tax displaying when items are added/removed from an order.

Example: 1 item order
Sub-Total: $0.25
Ground Advantage® (3 - 5 days): $4.95
CA State Sales Tax (7.25%): $0.02
Total: $5.22

Used EO to add second item, also taxable:

Sub-Total: $1.00
Ground Advantage® (3 - 5 days): 4.9500
Total: $6.02

The tax line is removed from the order. Tax is still calculated correctly in the total, but no longer displays in admin OR on customer order history page. Did I missing something here?

I tried installing with and without the optional overrides without any change in result. Anyone able to point me in the right direction? Thank you.

Anyone have additional thoughts on this issue? I enabled debug and log file appears to have tax calculated, just not displayed. Could there be an issue with my order total module or something else I have set?

2024-12-31 05:16:41, Edit Orders entered (4.7.1) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_shipping.php;ot_coupon.php;ot_group_pricing.php;ot_tax.php;ot_loworderfee.php;ot_gv.php;ot_total.php
getOrderInfo(edit), on entry: Called by /home/.../edit_orders.php on line #112
	Subtotal: (not set), Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 31.1815, Total: 467.3715, Tax Groups: {"7.2500":"1"}
	$_SESSION['shipping']: (not set)

Order Totals
		ot_subtotal. Text: $430.09, Value: 430.0900
		ot_shipping. Text: $6.10, Value: 6.1000
		ot_total. Text: $467.37, Value: 467.3715

[mcqueeneycoins]

Anyone have additional thoughts on this issue? I enabled debug and log file appears to have tax calculated, just not displayed. Could there be an issue with my order total module or something else I have set?

2024-12-31 05:16:41, Edit Orders entered (4.7.1) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_shipping.php;ot_coupon.php;ot_group_pricing.php;ot_tax.php;ot_loworderfee.php;ot_gv.php;ot_total.php
getOrderInfo(edit), on entry: Called by /home/.../edit_orders.php on line #112
	Subtotal: (not set), Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 31.1815, Total: 467.3715, Tax Groups: {"7.2500":"1"}
	$_SESSION['shipping']: (not set)

Order Totals
		ot_subtotal. Text: $430.09, Value: 430.0900
		ot_shipping. Text: $6.10, Value: 6.1000
		ot_total. Text: $467.37, Value: 467.3715

After a lot of trial and error, I discovered a small modification in the ot_tax.php file that apparently caused this issue. I have restored the file to the original ZC distribution and it now displays properly. However, it is showing up as follows:

CA State Sales Tax (7.25%) + Shipping Tax (0.0000%): $23.58

Is there any way to "hide" the + Shipping Tax portion?

[lat9]

After a lot of trial and error, I discovered a small modification in the ot_tax.php file that apparently caused this issue. I have restored the file to the original ZC distribution and it now displays properly. However, it is showing up as follows:

CA State Sales Tax (7.25%) + Shipping Tax (0.0000%): $23.58

Is there any way to "hide" the + Shipping Tax portion?

That would be (most likely) a combination of Zen Cart Configuration settings:

My Store // Sales Tax Display Status, set to 0. That will remove the display of any 0-value taxes, like shipping in your example.
My Store // Show Split Tax Lines, set to true. That will result in each type of tax being separately reported. For your example, that would display as

CA State Sales Tax (7.25%): $23.58
Shipping Tax (0.0000%): $0.00

[yesaul]

Good day

Is anybody using EO with new ZC v2.1.0 ??

I'm trying to experiment with EO 4.7.1 on freshly installed ZC v2.1.0 (no another modules installed or no any changes made)

Problems are appearing with loading language files for different OT modules
(for ex: Could not locate language file: includes/languages/english/modules/order_total/ot_shipping.php)

Systems crashes also by calling zen_calculate_tax function from editOrders->calculateOrderShippingTax
(for ex: Uncaught TypeError: Unsupported operand types: string * int)

[lat9]

Good day

Is anybody using EO with new ZC v2.1.0 ??

I'm trying to experiment with EO 4.7.1 on freshly installed ZC v2.1.0 (no another modules installed or no any changes made)

Problems are appearing with loading language files for different OT modules
(for ex: Could not locate language file: includes/languages/english/modules/order_total/ot_shipping.php)

Systems crashes also by calling zen_calculate_tax function from editOrders->calculateOrderShippingTax
(for ex: Uncaught TypeError: Unsupported operand types: string * int)

Yep, EO 4.1.7 isn't ready for zc210. I'm working hard to get EO-5 ready (see https://github.com/lat9/edit_orders) for progress and pre-release testing.

[yesaul]

Yep, EO 4.1.7 isn't ready for zc210. I'm working hard to get EO-5 ready

Thank you. We'll be waiting

[mcqueeneycoins]

I updated my first live order using EO 4.7.1 with 1.5.8a and had a couple of issues/questions:

1) I received this error when updating the order:

 Warning: The coupon code was not found in the database. Note: the title / text of a coupon is usually formatted like "Discount Coupon : coupon_code :".

I have a feeling it has to do with changes I made to how the coupon code displays to the customer, and I believe the change I need to make is in the eo_update_order_action_processing.php file here:

// Look for correctly formatted title
                    preg_match('/([^:]+):([^:]+)/', $coupon, $matches);
                    if (count($matches) > 2) {
                        $order_total['title'] = trim($matches[1]);
                        $coupon = $matches[2];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                           FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

The change I made to the ot_coupon.php file is:

$this->output[] = [
                'title' => $this->title . ' (' . $this->coupon_code . '):',
                'text' => '-' . $currencies->format($od_amount['total']),
                'value' => $od_amount['total']
            ];

Can someone help me correct the EO code to prevent this error in the future?

2) I have EO set to reset totals on update in the config menu. When I change a quantity to 0 to remove an item, should the totals automatically update (like an auto page refresh), or is it normal to not display any changes until I click "Update"? I was hoping to be able to see the impact the changes have prior to finalizing an update but that's not happening.

[lat9]

I updated my first live order using EO 4.7.1 with 1.5.8a and had a couple of issues/questions:

1) I received this error when updating the order:

 Warning: The coupon code was not found in the database. Note: the title / text of a coupon is usually formatted like "Discount Coupon : coupon_code :".

I have a feeling it has to do with changes I made to how the coupon code displays to the customer, and I believe the change I need to make is in the eo_update_order_action_processing.php file here:

// Look for correctly formatted title
                    preg_match('/([^:]+):([^:]+)/', $coupon, $matches);
                    if (count($matches) > 2) {
                        $order_total['title'] = trim($matches[1]);
                        $coupon = $matches[2];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                           FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

The change I made to the ot_coupon.php file is:

$this->output[] = [
                'title' => $this->title . ' (' . $this->coupon_code . '):',
                'text' => '-' . $currencies->format($od_amount['total']),
                'value' => $od_amount['total']
            ];

Can someone help me correct the EO code to prevent this error in the future?

2) I have EO set to reset totals on update in the config menu. When I change a quantity to 0 to remove an item, should the totals automatically update (like an auto page refresh), or is it normal to not display any changes until I click "Update"? I was hoping to be able to see the impact the changes have prior to finalizing an update but that's not happening.

1) Change that section to read

// Look for correctly formatted title
                    preg_match('/\((.+)\)/', $coupon, $matches);
                    if (count($matches) === 2) {
                        $order_total['title'] = rtrim(str_replace('(' . $matches[1] . ')', '', $order_total['title']), ' :');
                        $coupon = $matches[1];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                           FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

2) EO 4.7.1 can be quite finicky. The totals 'should' automatically update to reflect the removed item; if not, just click the reset-totals box and update again.

[lat9]

EO v5.0.0-beta1 is now available for (er) beta-testing: https://github.com/lat9/edit_orders/...g/v5.0.0-beta1

Currently supported on Zen Cart 2.1.0 only.

[jimmie]

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.