PayPal RESTful API Payment Module

[lat9]

I'm guessing that if you use the browser's developers' tools to inspect that dropdown, there's an 02 id for February but the text reads March. That's a weird date-related issue with the base Zen Cart zcDate class.

Yep, if you navigate to the admin's index.php?cmd=banner_statistics&page=0&bID=0&type=monthly&month=4, you'll see that "Mar" is repeated there, too.

[pilou2]

Yep, if you navigate to the admin's index.php?cmd=banner_statistics&page=0&bID=0&type=monthly&month=4, you'll see that "Mar" is repeated there, too.

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

[pilou2]

No modification needed on line 874!

[lat9]

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

Yep, thanks for the follow-up.

[mikestaps]

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

Would it be possible to provide the specific fixes needed on lines 782 and 129?

THX!

[lat9]

Would it be possible to provide the specific fixes needed on lines 782 and 129?

THX!

See this GitHub commit for the changes needed: https://github.com/lat9/paypalr/comm...6973e6a662156c

[mikestaps]

PERFECT! Thank you

[Jeff_Mash]

Cindy - Quick question: I know the module no longer uses the IPN Hander. My question is, if we do set an IPN Handler in PayPal (under the Settings --> Notifications), would that interfere with the module in any way?

I ask because we are developing a product (completely separate from ZenCart but run on our same server), and this other product uses a PayPal button that relies on PayPal to post back to the IPN handler for that program.

So if we put the URL for that other program into our PayPal IPN settings, would that somehow cause our ZenCart store (using the PayPal RESTFUL api) to stop processing the orders?

[lat9]

Cindy - Quick question: I know the module no longer uses the IPN Hander. My question is, if we do set an IPN Handler in PayPal (under the Settings --> Notifications), would that interfere with the module in any way?

I ask because we are developing a product (completely separate from ZenCart but run on our same server), and this other product uses a PayPal button that relies on PayPal to post back to the IPN handler for that program.

So if we put the URL for that other program into our PayPal IPN settings, would that somehow cause our ZenCart store (using the PayPal RESTFUL api) to stop processing the orders?

The /ipn_main_handler.php processing has no bearing on the PayPal RESTful module's operation. Just be sure that you grab the current version of that file from the Zen Cart GitHub as there have been a bunch of changes since zc210 to correct various PHP warnings and notices in that file.