Stripe.com payment integration module

[Promar]

The version 2.1.14 do not include create.php and therefore causes error. It is obvious when installed from scratch.
Anyway, the module do not show CC input fields in the step 3/3 of the Checkout conformation, but an order is confirmed and put among orders and sent by email. I tried also ver. 2.1.12 and behavior is the same?

[gernot]

Hello all,
I am testing my shop upgraded from ZC v1.5.6c to v2.1.0, and installed the Stripe module, which I was unable to use previously in Japan under 1.5.6.c.
I noticed that the code does not include generic order total processing, and seems to explicitly be coded only to handle low order fees.
In my case, since I upgraded the gift wrap module to PHP8 standards, the processing of the added amount is missing.
However, there could be many other situations of requiring order total processing: in the paypalwpp code, the entire order total processing is called in the code.
So I will try that approach in Stripe as well.
I am confused though: if the order total modules update

order->info['total']

, why is this not available to the payment modules, and why do they need to repeat the order total processing in order to re-obtain the correct value for the total?

Previously, in 1.5.6c, I was using the v1.0.4 Square module (and paypalwpp), where I now see that there is also no calling of the order total processing either, so I may have missed that payment was possibly less than the required amount for orders that had additional order processing fees.

[Gozzandes]

I’d like to clarify the behavior regarding `order->info['total']`.

Unlike other payment modules (such as PayPal WPP or Square), this Stripe module initiates the API call to Stripe during the `checkout_confirmation` stage. At that point, the order total—including any low order fee or other order total components—needs to be fully calculated, since it’s already being transmitted to the Stripe server before the confirmation button is pressed.

This differs from other payment modules where the order total is recalculated *after* pressing the confirmation button. So if you're using the low order fee module (or any custom `order_total` module), but that amount is not reflected in `order->info['total']` by the time you reach `checkout_confirmation`, it will not be included in the amount sent to Stripe.

If you’re not using low order fees or other dynamic order total adjustments, then relying on `order->info['total']` at that stage may be fine. But to ensure consistency, the Stripe module assumes that all necessary order total processing is completed **before** the confirmation page is loaded.

Let me know if you'd like to go over integration strategies for your particular setup—I’d be happy to walk through adjustments or considerations.


As a side note, the problems found in the previous Stripe module (which relied on a POST submission method) have already been resolved. That said, reverting to that outdated architecture doesn’t seem necessary at this point.

[gernot]

Hello @gozzandes
Many thanks for your explanation. I've been confusing myself trying to understand the logic of multiple payment modules and how order_total is use in various places, so I will need some time to reset my brain, read and digest your explanation, and thereby understand the code.

In the meantime, since $order->info['total'] at the time the stripe.php module was loaded was the plain product total only, I found that I could include the required order_total additions by requesting them in the pre_confirmation_check() function before the $amount_total is calculated.

function pre_confirmation_check() {
    // add $order_totals, $order_total_modules globals
    global $order, $db, $stripeCustomerID, $user_id, $stripe_select, $order_totals, $order_total_modules;
/../
  // debug - add any order_total additions for Stripe to get the correct amount
  if (MODULE_ORDER_TOTAL_INSTALLED) {
      $order_totals = $order_total_modules->process();
  }
  // end debug

  if ( isset($_SESSION['opc_saved_order_total'])) {
     $order_value = $_SESSION['opc_saved_order_total'];
    }else{

      if (MODULE_ORDER_TOTAL_LOWORDERFEE_LOW_ORDER_FEE == 'true' && MODULE_ORDER_TOTAL_LOWORDERFEE_ORDER_UNDER >= $order->info['total']) {
         $order_value = $order->info['total'] + MODULE_ORDER_TOTAL_LOWORDERFEE_FEE ;
        } else{
         $order_value = $order->info['total'];
        }
    }
  
  $amount_total=round($order_value * $order->info['currency_value'],$decimal_places)*$multiplied_by;
/../ 

I understand this is hack and I need to also change the code below with lowerorder fee.