Page 4 of 4 FirstFirst ... 234
Results 31 to 34 of 34
  1. #31
    Join Date
    Oct 2008
    Location
    Croatia
    Posts
    1,750
    Plugin Contributions
    22

    Default Re: Language Manager [Support Thread]

    Quote Originally Posted by pilou2 View Post
    Huum yes, when cloning from a language other than English, some files might be missing... Could this "Run Diff" button be actually the "Clone Language Pack" button? You would make a list of copied files then, at the end do the comparison/copy of missing files.
    See, that's why I enjoy discussing things with you - this is a great idea! And probably much simpler than what I had in mind.
    If I understood correctly, you're suggesting to simply run the clone process again and overwrite existing files? Or should we skip existing files if they exist instead of overwriting? I'd say skip existing and add a message that existing files were skipped. Skipping means any existing customization remains intact, BUT opens the possibility that an updated plugin (not encapsulated) introduced new constants which would not be copied now.

  2. #32
    Join Date
    Jun 2008
    Location
    Japan
    Posts
    343
    Plugin Contributions
    7

    Default Re: Language Manager [Support Thread]

    Quote Originally Posted by balihr View Post
    See, that's why I enjoy discussing things with you - this is a great idea! And probably much simpler than what I had in mind.
    If I understood correctly, you're suggesting to simply run the clone process again and overwrite existing files? Or should we skip existing files if they exist instead of overwriting? I'd say skip existing and add a message that existing files were skipped. Skipping means any existing customization remains intact, BUT opens the possibility that an updated plugin (not encapsulated) introduced new constants which would not be copied now.
    Yes, this is what I meant, copying from English only what was missing in the other language (source). If a new constant is missing in the source language because it has not been updated, it should default to English anyway. So, not a problem at all.

  3. #33
    Join Date
    Oct 2008
    Location
    Croatia
    Posts
    1,750
    Plugin Contributions
    22

    Default Re: Language Manager [Support Thread]

    Quote Originally Posted by pilou2 View Post
    Yes, this is what I meant, copying from English only what was missing in the other language (source). If a new constant is missing in the source language because it has not been updated, it should default to English anyway. So, not a problem at all.
    Nice, will add in a few days, currently focused on something else.
    If any other ideas come up in the meantime, happy to take it all onboard.

  4. #34
    Join Date
    Jun 2008
    Location
    Japan
    Posts
    343
    Plugin Contributions
    7

    Default Re: Language Manager [Support Thread]

    As you are busy elsewhere, I decided to add encapsulated plugins folders to cloning process. Please, take a look at the PR on your GitHub.

 

 
Page 4 of 4 FirstFirst ... 234

Similar Threads

  1. Image Manager [Support Thread]
    By balihr in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 9 Sep 2025, 02:06 AM
  2. v151 Log Manager [Support Thread]
    By lat9 in forum All Other Contributions/Addons
    Replies: 11
    Last Post: 4 Jul 2025, 02:40 PM
  3. Link Manager 3.0 Support Thread
    By clydejones in forum Addon Sideboxes
    Replies: 1987
    Last Post: 6 Aug 2021, 02:56 PM
  4. Testimonial Manager Support Thread
    By clydejones in forum All Other Contributions/Addons
    Replies: 1500
    Last Post: 4 Feb 2021, 04:12 PM
  5. Poll Manager Support Thread
    By boudewijn in forum Addon Sideboxes
    Replies: 148
    Last Post: 27 Jan 2016, 09:53 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg