Froogle Merchant Center merged into GoogleBase

[a_berezin]

Please download and test once more.
I cann't repeat that error :-( But on any case has cleaned a some code.
Please, e-mail me about results of your testing.

[Pixxi]

Andrew,

Thank you for the continued development work on this module

This may not be related to the problem BessIsaacola has reported, but isn't there still an unnecessary '\t' on the end of the feed?

For example:

$output = "title \t" .
                        "description \t" .
                        "link \t" .
                        "price \t" .
                        "image_link \t" .
                        "expiration_date \t" .
                        "label \t" .
                        "id \t" .
                        (GOOGLE_FROOGLE_IN_STOCK == 'true' ? "quantity \t" : '') .
                        (GOOGLE_FROOGLE_SHIPPING != '' ? "shipping \t" : '') .
                        (GOOGLE_FROOGLE_MANUFACTURER == 'true' ? "brand \t" : '') .
                        (GOOGLE_FROOGLE_PRODUCT_TYPE_SHOW == 'true' ? "product_type \t" : '') .
                        (GOOGLE_FROOGLE_LANGUAGE_DISPLAY == 'true' ? "language \t" : '') .
                        (GOOGLE_FROOGLE_CURRENCY_DISPLAY == 'true' ? "currency \t" : ''); 

Each line has a '\t' on the end - which means there will always be an extra (unnecessary) tab on the end of the feed, no matter which options are set in admin.

Shouldn't the "id \t" be simply "id", and the following '\t's be moved to the beginning of the optional feed lines, eg:

$output = "title \t" .
                        "description \t" .
                        "link \t" .
                        "price \t" .
                        "image_link \t" .
                        "expiration_date \t" .
                        "label \t" .
                        "id" .
                        (GOOGLE_FROOGLE_IN_STOCK == 'true' ? "\t quantity " : '') .
                        (GOOGLE_FROOGLE_SHIPPING != '' ? "\t shipping" : '') .
                        (GOOGLE_FROOGLE_MANUFACTURER == 'true' ? "\t brand " : '') .
                        (GOOGLE_FROOGLE_PRODUCT_TYPE_SHOW == 'true' ? "\t product_type" : '') .
                        (GOOGLE_FROOGLE_LANGUAGE_DISPLAY == 'true' ? "\t language" : '') .
                        (GOOGLE_FROOGLE_CURRENCY_DISPLAY == 'true' ? "\t currency" : ''); 

(And the same for the block of code from line 146 to line 159)

[Phid]

Has anyone successfully used this with SEFU? Although I am able to view a particular page based on the url output of this contrib, it's not the same url that I see for a product when I manually browse to the page on my site. I would prefer not to have too many urls different urls leading to the same page on my site, lest I'm punished for duplicate content.

[a_berezin]

Phid!
You are the first, who told me, that this GoogleFroogle not work with SEFU.
What SEFU you use?

[samad64]

phid, this mod works fine with Ultimate SEO v.2.103 i believe it is (latest version of Ultimate SEO at this time). There is another SEFU mod out there, and I'm not sure of compatibility of that.. maybe thats the one you're using?

[Phid]

Hello all,

I use the ex-Tim Kroger Breakmyzencart SEFU urls that have been updated by JeffD to be compatible with 1.3.6. I'm not saying that it won't work with it, just that I'd run the risk of having Google think I'm spamming with duplicate urls.

In the config area, when I set the "Show feed language = true", I get something like:

://www.mysite.com/pages-productinfo/product-204/language-en/my-product.html

in my url. While the link does lead to the product page, it's not the same url that appears when I just naturally browse to the page (like a search engine would normally). Here is how my url looks when I browse to the page manually:

://www.mysite.com/pages-productinfo/Mymerchandise-66_69/product-204/my-product.html

Now I can remove the language-en text by putting "Show feed language = false", but then I'll still be missing the "Mymerchandise-66_69". This text is from my sefu_defines.php file:

define('SEFU_CATEGORY_NAME', 'Mymerchandise');

Here are the settings I had for the GoogleFroogle generated feed:

Show Default Currency false
Default Currency USD
Show Offer ID model
Display quantity false
The shipping options available for an item
Show Manufacturer true
Show Product Type true
Product Type other
Show Feed Lanugage true
Feed Language English
Output File Name froogle.txt
Compress Feed File false

[a_berezin]

Ok! Don't use this module with "ex-Tim Kroger Breakmyzencart SEFU urls that have been updated by JeffD to be compatible with 1.3.6". I don't know how it works.

[BlessIsaacola]

Please download and test once more.
I cann't repeat that error :-( But on any case has cleaned a some code.
Please, e-mail me about results of your testing.

I was finally ready to test the updated file but I got an error File "zc-contribution/GoogleFroogle.zip" not found in download directory...

[a_berezin]

I am not ready

[a_berezin]

BlessIsaacola!
Sorry for delay. Test this one.