[Done v1.3.8] embedded ot_coupon.php popup javascript causes problems

[JeffD]

We just went live with our newly upgraded ZC 1.302 store a few minutes ago and have had about 5 orders. The last of which the customer used a coupon during checkout and when I look at that record in the orders_total table the title text field says:

Discount Coupon: <a href="javascript:couponpopupWindow('http://www.isegames.com/ise-popup_coupon_help/cID-31/index.html?zenid=v13r0d6mungedxxc4nj5h8t62')">4HINSTR100</a> :

rather than just:

Discount Coupon: 4HINSTR100

as I would expect.

Looking at ot_coupon.php, the offending line 48 says:

      $this->output[] = array('title' => $this->title . ': ' . '<a href="javascript:couponpopupWindow(\'' . zen_href_link(FILENAME_POPUP_COUPON_HELP, 'cID=' . $_SESSION['cc_id']) . '\')">' . $this->coupon_code . '</a> :',
                              'text' => '-' . $currencies->format($od_amount['total']),
                              'value' => $od_amount['total']);

and appears to be responsible for this problem. Can someone explain the purpose of this code?

Thanks,
Jeff

[Ajeh]

If you click the link it puts in a window exactly what the customer could see for that Discount Coupon when checking out ...

[JeffD]

Yes, but you don't want to write all that to the order_totals table record, otherwise you will break order editors like edit orders and super orders and make it very difficult to run queries on that table to produce reports, etc!


I have fixed my copy by changing this line back to:

$this->output[] = array('title' => $this->title . ': ' . $this->coupon_code . '</a> :',

Jeff

[ksoup]

I want to thank you for posting this. I have been on this for quite a long time with no answer in sight. Thank you!

[Ajeh]

We will be looking into this further to work for both conditions ...

Just have to put on my coding cap ...

[Ajeh]

This has been updated for the next release to not put the javascript into the database but to call it in the 2 orders classes ...

It will not remove it from the existing orders that have this added but it will no longer add it ...

To clean up an existing database via phpMyAdmin a search on the orders_total table for:

SELECT * FROM orders_total WHERE title LIKE '%<a href="javascript:couponpopupWindow%'; 

will locate any records that need to be cleaned up ...

[ksoup]

Ajeh, with cart 1.3.7.... where would configure the coupon javascript to be turned off and not included on the order total table?

This has been updated for the next release to not put the javascript into the database but to call it in the 2 orders classes ...

It will not remove it from the existing orders that have this added but it will no longer add it ...

To clean up an existing database via phpMyAdmin a search on the orders_total table for:

SELECT * FROM orders_total WHERE title LIKE '%<a href="javascript:couponpopupWindow%'; 

will locate any records that need to be cleaned up ...

[Ajeh]

This required modifying the ot_coupon.php file ... but I would have to go through and figure out the changes again to tell you how to do this before the release of Zen Cart v1.3.8 ... which we hope to have out very very soon ...

Otherwise, just running the select will find where this exists in the table for cleaning up ...