Strange for me it is using Sub-Categories I don't supose you could et#ver put on here or email me a copy of your complete googlefroogle.php so I can try it on mine I know there has been lots of changes to this mod so may be its not the same.
I have been going through mine all day trying to find a way but with no luck.
Mind you I am no coder so its just try it and hope and it takes forever.
Nevermind, you are right. Let's see if they still deny the feed...
It denyed mine if I left the sub-cats in but once I deleted them it was OK Just need to find away to do it on auto
I have submitted an updated Froogle contrib with the label header removed and product_types removed.
Also slighty tidyied up the code. I will get round to doing some more testing and see if Google accepts own product types
NamSingh, it denies the feed if you leave out product_type completely... Have to make label = product_type and then tweak it from there.
@Nam
So you have tested thoroughly on your own and found that removing "label" and "product_types" fixed things for sure?
I see your only change was to googlefroogle.php
So you did not update the SQL patch to remove product_type from the admin UI? That would require updates to googlefroogle.sql, and creation of update_from_133.sql. So how are people suppose to upgrade without updated SQL? And shopowners installing for the first time will be given a useless entry in the admin UI.
If you are going to patch the code then please also update the SQL.
Or at least explain to people the ramifications of installing your updated version.
Also I could have easily missed your low key update announcement in this thread.
"Tidied up the code" and "cleaned up some documentation" is a bit vague and ambiguous.
Changing code unnecessarily makes it difficult to compare one version to the next to migrate custom code changes (via a compare/merge tool). Best to leave the code alone except where you are making functional improvements.
When announcing a new mod or mod update please post the name of the mod, the new version, where available in the downloads area (URL), a changelog, and the version of Zen Cart it is known to be compatible (tested) with. Something similar to how most other mod "developers" announce their mod updates.
Finally, I don't understand, why you did not have others TEST the updated contrib BEFORE submitting? That is suppose to be how it works. Then people don't get stuck downloading, installing and troubleshooting a module update that is problematic. Argh.
Thanks,
Woody
Woody
I think with Googlebase getting more picky about what it excepts, the only real way round this. (because zencart does not hold the info google base wants at the moment).
Would be to put a new field in Admin on the new product page named product type and a drop down list made up of what googlebase excepts http://www.google.com/base/product_types.html this data could then be stored and brought up by the googlebase/froogle mod.
I know this is probably hell of a job but at the moment the info googlebase wants is just not in Zencart and I am sure most of you like me get 90% of traffic from googlebase.
@ Woody
This is the first time I've made any updates/changes or got involved so have not been clear of the procedure. I think I will get the update removed as it is different for each country by the sounds of it.
I didn't remove priduct_type as it is still supported by Google, just not accepted with the data from zen cart. I was hoping to get it working quite soon after more testing.
I second this, and it wouldn't be that big of a job since you could basically cut and paste the google product types and put them into the product form. A drop down menu would be way too big. Even a blank input space that saves to the SQL database as product_type would be ideal and wouldn't take long to implement at all...
Bookmarks