Sales report 2.0

[hauruapai]

Hi,

Firstly thank you for this and the info that others have given to fix the little bugs - it is now installed! But .....

I have the latest Zen Cart - clean install, and the report page shows fine. I have installed in the root, so admin is a dir under root and not under catalog. At the mo it is on my WinXPPro with PHP Version 5.2.3

But when I select say the following, which I figure are the widest options:

1. Gather & Filter Data
Preset Date Range - This Month
Search date of... - Order Purchase
and leave the other 3 set to "doesn't matter

Then leave the rest and click "Show Me The Money" it does not load a page at all - I have even tried the setting to Open in New Window. There is nothing happening! - No error message - no "Processing, please wait" (got that from the view source)

I have made sure that I do have sales and have checked to make sure that all calls to js files are correct by checking them against the Add Product page in admin through a view source - they are the same in each file. Also made sure that the sales_report.js.php, is in it's place in the admin/includes/javascript folder

I have made the changes as outlined in the "Read Me" as well as the changes on how to get the date to UK and adding in the php by the <? lines to get the report to show. (lines lines 693 and 1029)

Have tested in FF where nothing hapens and IE - in IE where nothing happens but it gives js errors in the report page -

line 26
Char 1
Syntax Error

line 665
Char 9
Object Expected

line 874
Char 1
Object Expected

line 967
Char 1
Object Expected

Would appreciate any advise and guidence to be able to get this working

[hauruapai]

hmm, this is now working - not too sure what I did except when I put it on a producation server, it worked - just wouldn't on my own pc.

[bhunted]

Great mod!

Question... Think maybe a bug?

I find that when it grabs the lined items and shows the sales tax collected, that it doesn't depict the correct tax and total of the order.

But, it does show in the totals line, the correct tax. Any ideas why?

The Tax Collected was $4.48 and it rounded it down to $4.00 in the order line.

Thanks!

[hqarrse2]

I am also getting this problem since a site reinstall but I can't work out where the error is.

On a report of the month everything still shows OK up until the date of the reinstall, but immediately afterwards I see the rounded down tax problem described by bhunted above.

On a report only of days since the reinstall, the tax is not shown at all, even though the orders themselves are still fine with tax added correctly.

I will try to get to the bottom of this this week and will of course post if I manage it, but mean time any ideas would be appreciated.

[hqarrse]

Just found a clue. At the point of change (unfortunately I don't know if it was at this point that I switched to 1.3.7 or whether I had done that before), I have found a change in the orders_total table.

Any entry in the orders_total table used to be 4 rows per order_id:
"Sub-Total".
Shipping Method description
"(Incl VAT)"
"Total"

The "(Incl VAT)" entry for each order no longer appears against any of my orders.

I notice in the sales_report class code the following:

####################___

// future code - currently being pulled from orders_total table for better accuracy
// calculate tax values
//$this->timeframe[$id]['total']['tax'] += zen_calculate_tax($onetime_charges, $tax);
//$this->timeframe[$id]['total']['tax'] += zen_calculate_tax(($final_price * $quantity), $tax);

####################____

Uncommenting these lines does give me a tax figure in the total rows of the report, but it is still being rounded down.

I am fiddling beyond my capability here, and hope this means something to someone fore familiar with sales_report and ZC tax.

I wonder if the loss of my orders_total row is a change in 1.3.7 (I can't remembered when I upgraded unfortunately) or a setting somewhere else in my new shop install.

Help appreciated.

[guillermozx]

Thanks a lot!
It works perfect on zencart v.1.3.7!!

[bhunted]

Hi.... just an FYI.... I only ever had ZC 1.3.7 and SR 2.0
So I don't think it's anything you did... maybe just a bug or maybe it only works properly in 1.3.6...
Dunno... hopefully the author will give us some insight soon...

Just found a clue. At the point of change (unfortunately I don't know if it was at this point that I switched to 1.3.7 or whether I had done that before), I have found a change in the orders_total table.

Any entry in the orders_total table used to be 4 rows per order_id:
"Sub-Total".
Shipping Method description
"(Incl VAT)"
"Total"

The "(Incl VAT)" entry for each order no longer appears against any of my orders.

I notice in the sales_report class code the following:

####################___

// future code - currently being pulled from orders_total table for better accuracy
// calculate tax values
//$this->timeframe[$id]['total']['tax'] += zen_calculate_tax($onetime_charges, $tax);
//$this->timeframe[$id]['total']['tax'] += zen_calculate_tax(($final_price * $quantity), $tax);

####################____

Uncommenting these lines does give me a tax figure in the total rows of the report, but it is still being rounded down.

I am fiddling beyond my capability here, and hope this means something to someone fore familiar with sales_report and ZC tax.

I wonder if the loss of my orders_total row is a change in 1.3.7 (I can't remembered when I upgraded unfortunately) or a setting somewhere else in my new shop install.

Help appreciated.

[murrah]

Hi,

I run Zencart 1.3.7.1.

I just installed Sales Report 2.0 and all the files seem to be in the correct places.

When I select "Sales report" from the Reports menu in Admin I get the following error:

Parse error: syntax error, unexpected $end in C:\PHPSites\ZenCart\admin\stats_sales_report.php on line 1187

By the look of the path in the error message it seems that the right file is being found. So, what could be wrong ?

Thanks,
Murray

[murrah]

Hi,

When I select "Sales report" from the Reports menu in Admin I get the following error:

Parse error: syntax error, unexpected $end in C:\PHPSites\ZenCart\admin\stats_sales_report.php on line 1187

OK. Here is the solution:

The script \admin\stats_sales_report.php has 2 places where it uses short_tags ie <? instead of <?php. If your php config has short_tags off (as mine did) the script will fall over (as mine did). So, change any <? to <?php. In the version of Sales Report 2.0 I am using, these occur on lines 693 and 1029. It is better NOT to use short_tags for just this reason - you never know what the config on the target server will be.

There is another problem you need to fix:
File \admin\includes\javascript\sales_report.js.php has javascript errors caused by numerous <?php// and //?> instances. Do a search and replace to change both these to just // ie these are just javascript comments, you dont need the <?php or ?> at all.

Hope that helps others.

Now, let me test the module itself !

Cheers,
Murray

[murrah]

Hi,

When I select "Sales report" from the Reports menu in Admin I get the following error:

Parse error: syntax error, unexpected $end in C:\PHPSites\ZenCart\admin\stats_sales_report.php on line 1187

OK. Here is the solution:

The script \admin\stats_sales_report.php has 2 places where it uses short_tags ie <? instead of <?php. If your php config has short_tags off (as mine did) the script will fall over (as mine did). So, change any <? to <?php. In the version of Sales Report 2.0 I am using, these occur on lines 693 and 1029. It is better NOT to use short_tags for just this reason - you never know what the config on the target server will be.

There is another problem you need to fix:
File \admin\includes\javascript\sales_report.js.php has javascript errors caused by numerous <?php// and //?> instances. Do a search and replace to change both these to just // ie these are just javascript comments, you dont need the <?php or ?> at all.

Hope that helps others.

Now, let me test the module itself !

Cheers,
Murray