POST data is getting lost on the way to actionMultipleAddProduct

[sfatula]

Jus tfor fun, what version of PHP? Mine is 5.2.3

[regenbauma]

Jus tfor fun, what version of PHP? Mine is 5.2.3

My site is using PHP 5.2.1

[DrByte]

Using the foreach-as approach is fine, and is in fact a more efficient construct than the while(list)=each construct. We are moving more toward the foreach approach progressively as code is updated for PHP5.
Thus, making the change you mentioned will be safe.

[sfatula]

Yes, I understand that. My issue is this - how many other times is the construct in question used in the code, and, what impact does it have (since they can break also presumably)? Not knowing the true cause, this is not a good feeling. So, I am updating PHP to the current version, re-testing, and, going to post in some PHP forums.

[DrByte]

I've tested Zen Cart 1.3.7 on countless servers with varying PHP configurations and never personally encountered the problem reported by regenbauma.
Even downloading his entire site and putting it on a few of my own servers couldn't recreate the problem he reported ... using the while/list/each code construct.

It's odd that it only seems to affect the $_POST data and not other arrays.

If you do find something about it, that will confirm that changing that line will be helpful for your situation.

Future versions of Zen Cart will have fewer while/list/each constructs in favor of foreach constructs.

[sfatula]

I hope you are not suggesting what I said is not worth it, it is. Yes, I changed the one line long ago. But, as a programmer who has written a few million lines of code in 30 years of programming, it does not end there. There are two paths:

1. IF the problem turns out to be a PHP bug, then, it is my responsibility to file an official bug report so that the problem can be fixed and not cost tens of thousands of programmers time for whatever odd reason it sometimes happens or
2. IF the problem turns out to be a real difference in the two constructs, and not a bug, then, I need to go through my Zen Cart code and look for other instances that might have the same construct, and, might not be behaving properly.

Either way, the problem is far from solved in my book. Simply changing one line that I know is bad and hoping all is ok is not the way to do things. That's all I was saying.

BTW - I have the problem on TWO servers, which are running two different OSes and two different PHP5 versions (though close). So, I am 2 for 2.