Quote Originally Posted by econcepts View Post
Thanks and glad you like the mod, however, you are incorrect in your thinking.

It appears you are not reading or understanding the SQL language provided in the install correctly.

If you look at the SQL code closely, you'll notice that the configuration group id variable is set during the SELECT statement, and is set to the specific value "WHERE configuration_group_title= 'Google Analytics Configuration';".

That group id differs between sites and the variable is set as such to properly remove the correct configuration values as needed (and if present).

A number of contributions use this same logic as it provides a means for users to install a module into an "open slot" without conflicting with other configuration group ids on their system.

This module is in use by myself on many sites, and thousands of other Zen Cart users (look in the downloads section) without any problems relating to "proper functionality of Zen Cart."

In fact, just to be sure, I tested your concept (I always test), and the patch works just fine without deleting the configuration keys you mentioned above. :)
I have run this code again in phpmyadmin

Code:
SET @t4=0;
SELECT (@t4:=configuration_group_id) as t4 
FROM configuration_group
WHERE configuration_group_title= 'Google Analytics Configuration';
DELETE FROM configuration WHERE configuration_group_id = @t4;
DELETE FROM configuration_group WHERE configuration_group_id = @t4;
and it indeed deleted:

PRODUCTS_OPTIONS_TYPE_SELECT
UPLOAD_PREFIX
TEXT_PREFIX
IH_VERSION (from Image Handler Addon)

My MYSQL version is 5.0.21 and the phpmyadmin is 2.8.1

I have run it again in MYSQL 4.1.22 and phpMyAdmin - 2.10.0.2. still the same problem.

Please note that, if run the above code in a database that has "Google Analytics Configuration" in configuration_group table, then the above will only delete the keys in configuration table with configuration_group_id equals to the Google Analytics configuration group ID.

OK I lost myself there.... anyway, the point is: if you run the above code for new installation of Google Analytics, then it will delete the 4 keys mentioned above.

Did you test run the code on a database already has Google Analytics installed?

I have reported this problem to other addon developer as well. So far, I managed to discover these addons are effected:

Google Sitemap
GOOGLE BASE FEEDER
Testimonials Manager
RSS Feed

Some have already releasing a fixed.