OLD Super Orders 2.0 (See v3.0 thread instead)

[abe23]

First of all, awesome mod! This will save me tons of time.

A question about using Super Orders with the Paypal IPN module. When I recieve payments through Paypal IPN they're not passed into the Super Orders payment data. So the invoice displays a customer still owing the full amount. 'Amount Applied: 0.00' etc.

I presume this is because only the credit card code was added to order.php and nothing inserted for Paypal transactions? Has anyone got some code to get Super Orders synchronised with Paypal payments?

Thanks!

[capnhairdo]

Not sure if this has been addressed already. (The forum search feature is beyond useless.)

Noticed that the Cash Report feature on our store wasn't listing MasterCard transactions, but was listing AmEx and Visa. Seems that there's inconsistent spelling of 'Master Card' in ZenCart / SuperOrders; sometimes it's got a space (so_payment_types table, most ZenCart code), sometimes it doesn't (our orders table). I'm guessing that when SuperOrders creates records in so_payment_types for each order, it wasn't correctly identifying the MasterCard transactions since the names didn't match up. (We're using PayFlow Pro for our payment gateway; not sure if that makes any difference.)

Added both spellings in the SuperOrders cc_line_item() function (includes/classes/super_order.php and manage/includes/classes/super_order.php). Seems to have fixed the problem.

    $cc_type_key = array('Master Card' => 'MC',
                         'MasterCard' => 'MC',
                         'Visa' => 'VISA',
                         'American Express' => 'AMEX',
                         'Discover' => 'DISC');

Also, seems that the Cash Report still shows listings for orders that have been deleted? My guess is that records in so_payment_types are not being deleted when corresponding orders in the orders table are.

[capnhairdo]

Also, it seems when there are orphaned records in the so_payments table, the Cash Report somtimes blows up entirely. From what I can tell, this is because the database query does a left join on the orders table, which leaves open the possibility for a non-matching record in the orders table:

    if ($target == 'payments' || $target == 'both') {
      $payment_query = "SELECT * FROM " . TABLE_SO_PAYMENTS . " p
                        LEFT JOIN " . TABLE_ORDERS . " o
                        ON p.orders_id = o.orders_id
                        WHERE date_posted BETWEEN '" . $sd . "' AND DATE_ADD('" . $ed . "', INTERVAL 1 DAY)
                        AND o.orders_id IS NOT NULL
                        ORDER BY payment_type asc";
      $payment = $db->Execute($payment_query);

The next line makes the rest of the report contingent upon there being a a non-null value for orders_id in the first record (not sure I understand this logic):

      if (zen_not_null($payment->fields['orders_id'])) {

Anyway, I believe changing the left join to an inner join will both fix the problem of deleted orders showing up, and keep the report from blowing up too, in one fell swoop. Can somebody verify this and/or say whether this might have some unintended consequences?

[ladyink]

Good Morning!

I've seen this question asked a few times and the answer is usually... don't worry about it, I fixed it. Well, I guess I'm not on top of my game today because... I can't figure it out.

On the Invoice, there is a column that says Tax and even though the items are taxable and the tax is added in after the sub-total, the column sales "None!" for each item. I would like to just get rid of the column all together.

While I'm asking, Is there a way to change the words "Per Unit" to "Shipping". I'm not even changing shipping per unit- it's by weight! I've looked at super_packingslip files and they say Shipping. I'm not sure where the "Per Unit" is coming from.

Thanks so much!
Nancy

[ladyink]

Well, my morning is getting better... I figured out the Shipping thing.
I changed
includes/languages/english/modules/shipping/perweightunit.php

and I just changed the Text. No big deal!

Nancy

[gsdcypher]

I am getting this error when trying to install the sql patch:

1062 Duplicate entry 'CA' for key 2
in:
[INSERT INTO so_payment_types VALUES (NULL, 1, 'CA', 'Cash');]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

Thanks.

[hova953]

I am getting this error when trying to install the sql patch:



Thanks.

You've run the SQL already, and the changes have been made

[webrob]

I am wondering if anyone knows of an easy way to export order info as XML. this would include attributes and the product they ordered.

[mauryg]

Good Morning!

I've seen this question asked a few times and the answer is usually... don't worry about it, I fixed it. Well, I guess I'm not on top of my game today because... I can't figure it out.

On the Invoice, there is a column that says Tax and even though the items are taxable and the tax is added in after the sub-total, the column sales "None!" for each item. I would like to just get rid of the column all together.

Thanks so much!
Nancy

I also see the problem with the invoice where the Tax says "None!".
The "None!" comes from admin/super_invoice.php line 239

      if ($display_tax) {
        echo zen_display_tax_value($order->products[$i]['tax']) . '%';
      }
      else {
        echo ENTRY_NO_TAX;
      }

and 'ENTRY_NO_TAX' is defined in admin/includes/languages/english/super_invoice.php.

define('ENTRY_NO_TAX', 'None!');

The odd thing is the definition of $display_tax (admin/super_invoice.php line 34)

  $display_tax = (FED_TAX_ID_NUMBER == '' ? true : false);

In the Admin>Config>Super Orders it says:

Federal Tax Exempt Number
If your tax exempt, then you should have a federal tax ID number. Enter the number here and the tax columns will not appear on the invoice. The number will also be displayed at the top of the invoice.

This makes NO sense at all. It seems that it is talking about the CUSTOMER's tax ID number, but the admin entry would be the STORE tax ID number. I know that Super Orders wants to ADD the use of Purchase Orders for customers, but I did not implement that because all my customers are credit card or PayPal. If the order were a purchase order then it would make sense that the customer would add THEIR tax ID number to avoid paying tax (e.g. if they were buying for resale, etc). But the fact that the display of the columns and the "None!" depends on $display_tax (the STORE tax ID number) makes NO sense to me. Perhaps Frank can explain that to us.

Also, in the "Details" report there are several 'redundant' columns. Tax Price (ex) Price (inc) Total (ex) Total (inc)
I can understand the Tax column if you have a mix of taxable and non-taxable items or different rates of tax per product. But I don't see the point of the double set of (ex) and (inc) columns. I seem to recall the in some countries it is required to show price with and without tax, but this is in the "Details" report and NOT on the invoice where I would expect it. If this is the case, it would be nice to have a switch in the Admin config section to turn it off for U.S. users who don't need it. In fact, as I read this, I am thinking that there should have been TWO variables, $display_taxID which controls the display of the tax ID number of the store and $display_tax which is a switch to turn on/off the display of the (ex) and (inc) columns in both the details page and the invoice.

One last thought. In the Totals column, I would suggest that in the USUAL case where tax is NOT charged on the shipping costs, the Tax amount should appear just after the Sub-Total and BEFORE the Shipping charges.

Frank, this is a great mod. My shop would not be able to work without it. I'm not complaining, just trying to understand some of the details.
BTW, any hope on including the tare in the Total Weight shown in the Totals column.

Maury

[mauryg]

I am wondering if anyone knows of an easy way to export order info as XML. this would include attributes and the product they ordered.

You might want to look at ZenCart Order Manager and see if it has the code that you want.
http://www.zen-cart.com/index.php?ma...roducts_id=223