Product Type Book (by moku)

[dgcdesign]

Is this module not available anymore? The download site seems to be, well... down?

[focus360]

Is this module not available anymore? The download site seems to be, well... down?

There is a lot of links to where the mod used to be. The latest is available here:

http://www.jphuk.co.uk/zc/index.php?...roducts_id=490

[hareslade]

Hi
The email advices are not working for me yet again, so I don't know what posts are solved without trekking back through the list.. I moved house recently so its a bit chaotic here. And I'm slightly out of touch with book product..
However
tHis is my test site for book product in single language
http://www.jphuk.co.uk/zc138a_t1/

I seem to remember probs with authors search were possibly originally due to not having a manufacturer in the book product item.. other than that, it works om my demo site?

The prob with the 'extra' data still showing with a disabled item, I agree, it shows the 'extra' data still, -if there isn't extra data the book item correctly disappears. I will look into this, but did anyone find the code solution?

[hareslade]

Hi
It seems to me that the music product does the same thing, shows the extra data, rather than disappearing completely when the item is disabled in admin.

http://www.jphuk.co.uk/zc138a_t1/ind...&products_id=6
The above link is my demo site with a music product, the product you see is disabled (red) in my admin, note it has no title

Would someone check this out on a 1.3.8 zencart by putting a music product in and then disabling it, , see if I'm right

I'm not saying it isn't a book product bug, but music product seems to have the same thing?
Reason I checked out music product, is that I compared the book php files code with music product files code, they have similar code in terms of what the coding does.

Let me know..
btw of course, add the artist etc extra data into the music product, for the testing..

[michaelhl]

Hello hareslade,
this is from the header.php in includes/modules/pages/

I take it from product_info and it it to product_book_info

 
 // if specified product_id is disabled or doesn't exist, ensure that metatags and breadcrumbs don't share inappropriate information
  $sql = "select count(*) as total
          from " . TABLE_PRODUCTS . " p, " .
                   TABLE_PRODUCTS_DESCRIPTION . " pd
          where    p.products_status = '1'
          and      p.products_id = '" . (int)$_GET['products_id'] . "'
          and      pd.products_id = p.products_id
          and      pd.language_id = '" . (int)$_SESSION['languages_id'] . "'";
  $res = $db->Execute($sql);
  if ( $res->fields['total'] < 1 ) {
    unset($_GET['products_id']);
    unset($breadcrumb->_trail[sizeof($breadcrumb->_trail)-1]['title']);
    header('HTTP/1.1 404 Not Found');

It seems not to work full, but the extras are not shown.

[hareslade]

HI michaelhl
The code setup you used from the standard product header isn't the same as the code in the music product file..

It looks to me like the http 404 header has been added to zencart standard product, but not for music product,
which explains the posts about search engines not liking book product, which copies the music code.

The music code probably doesn't allow a 404 header to be written, (where the ordinary product does allow), because the 404 standard product code instructions are in the header, not in main_template_vars.php. You can't write a header after any html is output.

Technically the separate problem seen with extras data showing, is because the main_template_vars_product_type.php in both music and book product, is running when it shouldn't, i.e its getting 'extras' data.

main_template_vars.php switches to the 'noproduct' template when there is no product found to display (i.e when it detects the red 'disabled' setting for the product is present). But I don't yet understand why the extras data are apparently showing on the 'info' template - it should have switched to the noproduct template.

Has anyone tested the music product for the same extras data problem when disabled, yet, as I suggest?

If it turns out music product is faulty, then really a post should be put in a new main thread, asking for solutions for music product.

[the ocarina]

Hey Hareslade,

Have you had any difficulties with your Zen Cart or mod when a shop has upwards 2,000 products?

I'm in a bit of a bind, which is detailed here: http://www.zen-cart.com/forum/showth...865#post604865

You don't need to read my entire problem, but I am curious about where I can go for answers in fixing the Zen Cart.

[hareslade]

the ocarina
There must be a processing time, or other limit somewhere on every sql request, you found it..
Either Hostgator has a type of sql processing limit which other hosts may not have,
or
the book sql might be proving too unwieldy because of the number of products

Or if you're showing 'product count' in categories menu links on the pages, turn that off it reduces sql requests.

Theres also a zencart global debug setting I think, that can show the sql process time period used, at bottom of each page, once you see it, if it says more than say 6 seconds its having trouble

I think all hosts limit the sql 'power' available per hosted site, as they are normally on servers with say 50 websites, and if one takes all the sql time up, the other sites will grind to a halt.

[hareslade]

generally... is anyone going to test the music product to see if it behaves the same as book product regarding the 'extra data' see several posts back?

Without confirmation I'm unable to post in the main forum regarding music product..

(The book product still shows up on its original url, even if the product has been disabled in admin.. does music product do exactly the same ?)

[reza]

hi
the link to download doesn't work. is there any other place where we can find the zip file?
oops; in between I found it:
http://www.jphuk.co.uk/zc/index.php?...roducts_id=490