[Done v1.3.9] Problem with "credit_covers"

[wilt]

Hi,

The problem here is we cannot just run the process function before the pre_confirmation as that would then set in stone all discounts, and then calculations would take place based on the reduced order totals.

I did however come up with a fix, based solely on changing the pre_confirmation_check routine in the order_total class

  function pre_confirmation_check() {
    global $order, $credit_covers;
    if (MODULE_ORDER_TOTAL_INSTALLED) {
      $total_deductions  = 0;
      reset($this->modules);
      $orderInfoSaved = $order->info;
      while (list(, $value) = each($this->modules)) {
        $class = substr($value, 0, strrpos($value, '.'));
        if ( $GLOBALS[$class]->credit_class ) {
          $order_total = $GLOBALS[$class]->get_order_total();
          if (is_array($order_total)) $order_total = $order_total['total'];
          $total_deductions = $total_deductions + $GLOBALS[$class]->pre_confirmation_check($order_total);
        }
        else 
        {
          $GLOBALS[$class]->process();
          $GLOBALS[$class]->output = array();
        }
      }
      $difference = $order->info['total'] - $total_deductions;
      if ( $difference <= 0.009 ) {
        $credit_covers = true;
      }
      $order->info = $orderInfoSaved;
    }
  } 

So although I have run the process function, i've restricted it to non Credit Class modules, and reset order totals after pre_confirmation_check finishes.

This works on my up to date v1.3.8. Would appreciate some testing/feedback before I commit that as a bug fix.

[Tick]

Hi,

The problem here is we cannot just run the process function before the pre_confirmation as that would then set in stone all discounts, and then calculations would take place based on the reduced order totals.

I did however come up with a fix, based solely on changing the pre_confirmation_check routine in the order_total class

(snip)

This works on my up to date v1.3.8. Would appreciate some testing/feedback before I commit that as a bug fix.

Thanks, Wilt! I will apply this to my development site tonight and do some test runs

Can I make a suggestion for 1.4? Perhaps the (returned) output from the process() function should be eliminated. Then you could break it into two functions: process() and output(). Then, process() could be called from the header_php file to set the discounts/additions in stone and it wouldn't matter when (or if) output() was called. In practice the new flow would go: process(), pre_confirmation_check(), output(). I know that would break existing order total modules, but hey, it's a major release!

As an added bonus, it would also make it easier to display messages to the user using the global messageStack object. I worked around it by calling order_total->process() at the top of the template so that I could use messageStack to warn customers about low order fees, but I imagine there would be other uses as well.

Thanks again, and I'll let you know how the testing goes....

[Tick]

This works on my up to date v1.3.8. Would appreciate some testing/feedback before I commit that as a bug fix.

Hi Wilt,

I've also done some preliminary testing and this works for me as well. I plan to add some logging statements to it and move it to production this week. I'll let you know if I run into any issues.

Thanks again for your help!