RSS2 Feed Contribution

[chain_man]

I installed this module recently and find it works with some feeds, but not with others.

When I select "Specials" I get all products instead of special priced items. I experimented with the code a bit and find that the SQL query for returning Specials is fine, but only if I set the case statement to 'new_products' instead of 'specials' and select 'New Products' as the feed I want.

If I revert to the original code, 'New Products' returns new products, as it should, but 'Specials' returns all products again.

The only other thing I have done was to change the extra_functions code to change 'feed=' to 'amp;feed=' in a couple of the functions where the url is built in order to allow the RSS Feed to work when I have the Wordpress module installed. (Not having the 'amp;' returns invalid feed or invalid page errors.)

Any suggestions? Besides uninstalling Wordpress...

[chain_man]

I installed this module recently and find it works with some feeds, but not with others.

When I select "Specials" I get all products instead of special priced items. I experimented with the code a bit and find that the SQL query for returning Specials is fine, but only if I set the case statement to 'new_products' instead of 'specials' and select 'New Products' as the feed I want.

If I revert to the original code, 'New Products' returns new products, as it should, but 'Specials' returns all products again.

The only other thing I have done was to change the extra_functions code to change 'feed=' to 'amp;feed=' in a couple of the functions where the url is built in order to allow the RSS Feed to work when I have the Wordpress module installed. (Not having the 'amp;' returns invalid feed or invalid page errors.)

Any suggestions? Besides uninstalling Wordpress...

OK - I got this working the way it's supposed to.

Caveat: The changes I made pertain only to my system. The suggestions may lead others to solve some relatively obscure problems, though.

The root of my problem seemed to be that I have Wordpress integrated into my zen cart, causing me to need 'amp;' prepended to the 'feed=' part of the URL, or else I get invalid page errors. This makes my feed URL look something like:
"?main_page=rss_feed&feed=featured" instead of the stock "?main_page=rss_feed&feed=featured". (Many thanks to bigjoeed, who posted this discovery on this thread several months ago.)

The biggest hint that the $feed variable was not populated correctly was that the title of the various feeds that did appear always had mystoredomain:RSS Feed, the generic title. Other stores with feeds had the type of feed included in the title, like mystoredomain:RSS Featured Feed. As this value is loaded based on the feed value, I decided the feed value was not being loaded correctly.

So I had to change $feed = $_GET['feed']; to $feed = $_GET['amp;feed']; and change $feed_args = substr($feed, $i+1); to $feed_args = substr($feed, $i+5); near the top of extra_functions/rss_feed.php.

Then I had to change switch($_GET["feed"]) to switch($_GET["amp;feed"]) (about line 128) of pages/rss_feed/header_php.php.

These changes got the $feed variable capturing the right values.

But I still could not get 'specials' to process the correct items. What I found was that the program could recognize 'special' but not 'specials' for some reason. So I had to change any place that $feed='specials' occurred to $feed='special' in pages/rss_feed/header_php.php. And add case='special' to the switch statement just below case='specials' in extra_functions/rss_feed.php. (This allows both 'special' and 'specials' to remain in the code).

Your mileage may vary...

[HeathenMagic]

Hello Chain_man,

Glad you got it working. I am really interested in the changes you made. I am thinking, it might solve the problem that many of us have, whereby the module doesn't work because of a XML declaration error. This is due to it picking up an extra space in a file somewhere in the zencart installation. Its proving pretty elusive, but the file changes you stated might help with this. I will have a look and try this and let everyone know. If anyone has already tried making chain_man's changes, it'd be great to hear from you.

Heathenmagic

[chain_man]

Hello Chain_man,

Glad you got it working. I am really interested in the changes you made. I am thinking, it might solve the problem that many of us have, whereby the module doesn't work because of a XML declaration error. This is due to it picking up an extra space in a file somewhere in the zencart installation. Its proving pretty elusive, but the file changes you stated might help with this. I will have a look and try this and let everyone know. If anyone has already tried making chain_man's changes, it'd be great to hear from you.

Heathenmagic

I'm not sure how my changes would fix the problems you have been describing. As I mentioned, they are a work-around for a specific condition where I had to add 'amp;' to the link. At no time did I have the error messages that you have had. The mod always displayed something, it was just the wrong something. Be careful.

[HeathenMagic]

Hello everyone,

I managed to fix the error I have, and am posting in case it helps somebody out.

In this thread:-

http://www.zen-cart.com/forum/showth...055#post613055

I was trying to fix an unrelated bug, and I am sure this is what did it for me. Ultimately, it is a file from a mod I installed.

This is for the xml declaration error, which prevents you seeing the feed at all. Something to do with line spaces at the end of a file can cause it too.

[100asa]

I've installed the latest version, but my feeds don't update. it's updated at the day of installation. why?

[100asa]

work well!!! I've made modify on page 32
UPDATE configuration SET set_function=NULL WHERE configuration_key = 'RSS_CACHE_TIME';
all work fine!

[a_berezin]

I've installed the latest version, but my feeds don't update. it's updated at the day of installation. why?

My bug
includes/class/rss_feed.php
Find (line ~383):

if ($time == false || (time() - filemtime(DIR_FS_RSSFEED_CACHE . '/' . $zv_file)) < $time) {

Replace by

if ($time == false || (time() - filemtime(DIR_FS_RSSFEED_CACHE . '/' . $zv_file)) > $time) {

[rlfreshwater]

OK - I got this working the way it's supposed to.

Caveat: The changes I made pertain only to my system. The suggestions may lead others to solve some relatively obscure problems, though.

The root of my problem seemed to be that I have Wordpress integrated into my zen cart, causing me to need 'amp;' prepended to the 'feed=' part of the URL, or else I get invalid page errors. This makes my feed URL look something like:
"?main_page=rss_feed&feed=featured" instead of the stock "?main_page=rss_feed&feed=featured". (Many thanks to bigjoeed, who posted this discovery on this thread several months ago.)

The biggest hint that the $feed variable was not populated correctly was that the title of the various feeds that did appear always had mystoredomain:RSS Feed, the generic title. Other stores with feeds had the type of feed included in the title, like mystoredomain:RSS Featured Feed. As this value is loaded based on the feed value, I decided the feed value was not being loaded correctly.

So I had to change $feed = $_GET['feed']; to $feed = $_GET['amp;feed']; and change $feed_args = substr($feed, $i+1); to $feed_args = substr($feed, $i+5); near the top of extra_functions/rss_feed.php.

Then I had to change switch($_GET["feed"]) to switch($_GET["amp;feed"]) (about line 128) of pages/rss_feed/header_php.php.

These changes got the $feed variable capturing the right values.

But I still could not get 'specials' to process the correct items. What I found was that the program could recognize 'special' but not 'specials' for some reason. So I had to change any place that $feed='specials' occurred to $feed='special' in pages/rss_feed/header_php.php. And add case='special' to the switch statement just below case='specials' in extra_functions/rss_feed.php. (This allows both 'special' and 'specials' to remain in the code).

Your mileage may vary...

Thank you, Doug, for figuring this out. I am also having an issue with this mod conflicting with WordPress. When I click on the RSS button in my footer it pulls up the feed to my blog instead of my products. [I know you said this only pertained to your system, but I tried everything else with no luck so I decided to try your suggestions.]

I've got a working feed (http://www.queerrepublictees.com/ind...;feed=products) but the problem is I can't get the RSS button to point to it.

I've done exactly what you did:

• changed $feed = $_GET['feed'] to $feed = $_GET['amp;feed']
• changed $feed_args = substr($feed, $i+1) to $feed_args = substr($feed, $i+5)
• changed switch($_GET["feed"]) to switch($_GET["amp;feed"])

... but it's still bringing up the blog instead of the products.
The confusing part is when I hover over the RSS button, in the bottom of my browser I can see:
http://www.queerrepublictees.com/index.php?main_page=rss_feed&feed=products

but if I select the button and look at the source code it points to the correct URL:
http://www.queerrepublictees.com/index.php?main_page=rss_feed&feed=products

There's got to be something really simple that I am overlooking. If anybody can help I'd be most grateful.

[chain_man]

Thank you, Doug, for figuring this out. I am also having an issue with this mod conflicting with WordPress. When I click on the RSS button in my footer it pulls up the feed to my blog instead of my products. [I know you said this only pertained to your system, but I tried everything else with no luck so I decided to try your suggestions.]

I've got a working feed (http://www.queerrepublictees.com/ind...;feed=products) but the problem is I can't get the RSS button to point to it.

I've done exactly what you did:

• changed $feed = $_GET['feed'] to $feed = $_GET['amp;feed']
• changed $feed_args = substr($feed, $i+1) to $feed_args = substr($feed, $i+5)
• changed switch($_GET["feed"]) to switch($_GET["amp;feed"])

... but it's still bringing up the blog instead of the products.
The confusing part is when I hover over the RSS button, in the bottom of my browser I can see:
http://www.queerrepublictees.com/index.php?main_page=rss_feed&feed=products

but if I select the button and look at the source code it points to the correct URL:
http://www.queerrepublictees.com/index.php?main_page=rss_feed&feed=products

There's got to be something really simple that I am overlooking. If anybody can help I'd be most grateful.

Check the includes/functions/extra_functions/rss_feed.php for the function rss_feed_link. Make sure the "'feed=' . $feed" is changed to "'amp;feed=' . $feed" there.