Order Editor 1.3.7 Issues

[DivaVocals]

I am not attacking someone (even if it looks that way in my posts) just pointing to the problems..

From me to you.. I totnally get that..(insert emoticon here)

It's difficult when it comes to the written word to convey emotions, sentiment, or intent.. unfortunately on a forum sometimes folks assume emotions or intent that were not the TRUE feelings of the author.. I always thought we were just chatting in this thread!! So it's ALL GOOD!!!

A lot of good things have been done to the mod by scot and i am taking them all in account while rewriting.

Agreed, and if I didn't say it clearly to YOU, I am EXCITED that you are doing this and can't wait to see this!!!

I don't think it will be appreciated if i explain here in full detail how to handle and use this new safety method to the public and just limit myself to rewriting and make the finished files available in the add-on section.

For now this is very high priority to me because i walked into the same problem with other mod's i was working on but because they are more complex i decided to use this mod for testing.
Working full days on this mod at the moment and hoping to release the first update this week.

Sounds AWESOME!! if you need folks to test, I am ABSOLUTELY willing to volunteer to test..

[asekeris]

Today decided to make a extra fresh install on my test server with no other mods installed and only added dutch language.
Taking edit orders to the next level in this install so i am not fooled by other mods and an release can be done earlier.

At the moment doing the last code modifications and then testing, testing and testing again.
After that (i hope this evening) i will upload it to the add on section.

For now left out the automatic taxes and changing some fields to dropdown for the sake of release speed.

By leaving out all other mods i use the release will be much faster and everybody can test as he wants.
Maybe i will hold you to the offer for pre testing if i am in doubt.

[DivaVocals]

DEFINITELY hold me to it.. I am more than happy and willing to test this out for you.. I have my test store setup in such a way that I can EASILY roll back to a vanilla store setup to test.. I do that for the same reason as you do so that I can see how the add-on behaves without the influences of other add-ons..

Today decided to make a extra fresh install on my test server with no other mods installed and only added dutch language.
Taking edit orders to the next level in this install so i am not fooled by other mods and an release can be done earlier.

At the moment doing the last code modifications and then testing, testing and testing again.
After that (i hope this evening) i will upload it to the add on section.

For now left out the automatic taxes and changing some fields to dropdown for the sake of release speed.

By leaving out all other mods i use the release will be much faster and everybody can test as he wants.
Maybe i will hold you to the offer for pre testing if i am in doubt.

[DrByte]

It is UNADVISABLE to make such an edit to init_sessions. You're basically just opening the door so anyone can edit your orders without logging in.
Something's wrong with your addon, and should be fixed there.

I understand your point in this DrByte that it is not good to open doors that should be shut but can you explain then what the difference is between opening the door for EDIT_ORDERS and opening it for FILENAME_PRODUCTS_PRICE_MANAGER for example.
It is the same door and somebody messing up your prices is also not real fun.
I could be wrong but to me an open door is open and it makes no difference who opened it.

Upon further investigation, I'm going to capitulate and take back my earlier comment.

While it *is* advisable to rewrite some of the addon's functionality to do things more securely and in so doing prevent XSS and CSRF risks, the edit suggested by cbensi shouldn't be as risky as initially expected.

Apologies for the confusion caused.

[asekeris]

Upon further investigation, I'm going to capitulate and take back my earlier comment.

While it *is* advisable to rewrite some of the addon's functionality to do things more securely and in so doing prevent XSS and CSRF risks, the edit suggested by cbensi shouldn't be as risky as initially expected.

Apologies for the confusion caused.

No problem at all.
It just gave me the push to do the long overdue overhaul of this mod.
I also found during this overhaul that following this method completely is nearly impossible for pages that need calling itself to complete updates or changes and is even more complicated when there are in between steps with 'normal links' instead of form submits.
This will make life much easier and will finish the update as soon as possible.

[asekeris]

Just submitted an intermediate update to the add on section and waiting for aproval. (v 1.5.4)

Items taken care off:
1. Changed action keywords to be compatible with 1.39h.
2. Made the mod multi-language.
3. Made the mod multi-currency.
4. Included dutch language files.
5. Minor fix in the HTML header. (no more error display)
6. Removed fixed file names and replaced by FILENAME_ORDER_EDIT.
7. Upgraded order status and send email to the new layout. (Like the order details)
8. Changed the fixed texts in language defines.
9. A lot of cleaning up and rewriting to standard zen functions.

TO DO in next versions:
1. Automatic tax calculations following the settings in the store.
2. Integration of support for some other mods.
3. Change some input fields in dropdown.
4. a lot of code formatting for better readebility.

[DivaVocals]

Sounds awesome.. Items 6-8 sound a lot like the changes that JTheed and I had made to the edit_orders.php file we were going to bundle in with new Super Orders..

Is it possible to get a copy of your version now?? I am bundling up the new Super Orders package as we speak and it would be nice if we could include what will be the latest and greatest version of Edit Orders versus having to do a second Super Orders release..

One small suggestion though..

Suggest that the version numbering should be updated to either 3.0 or 2.05 to avoid confusion.. Most of us have been working with ver 2.03 (now 2.04) of this add-on from Scott's site... rolling the version numbers backwards might be a source of confusion for many..

Just submitted an intermediate update to the add on section and waiting for aproval. (v 1.5.4)

Items taken care off:
1. Changed action keywords to be compatible with 1.39h.
2. Made the mod multi-language.
3. Made the mod multi-currency.
4. Included dutch language files.
5. Minor fix in the HTML header. (no more error display)
6. Removed fixed file names and replaced by FILENAME_ORDER_EDIT.
7. Upgraded order status and send email to the new layout. (Like the order details)
8. Changed the fixed texts in language defines.
9. A lot of cleaning up and rewriting to standard zen functions.

TO DO in next versions:
1. Automatic tax calculations following the settings in the store.
2. Integration of support for some other mods.
3. Change some input fields in dropdown.
4. a lot of code formatting for better readebility.

[DivaVocals]

Okay.. Not for nothing, but having a look at your 1.54 version it seems that your version is merely an update/enhancement of v1.53 available here in the Zen Cart downloads section. I'm sure you know that v1.5.3 is MILES AWAY from the most UPDATED version of Edit Orders which has been the subject of recent discussions in this support thread (v2.04).

There seem to be a TON of updates/enhancements/fixes which were incorporated into v2.xx of this module that are not in your version..

Given that DrByte has confirmed that two options originally proposed to correct the issues experience when using Edit Orders with Zen Cart 1.3.9h are "acceptable" solutions, why not update the version most of us are using (and indeed the version that a majority of the questions/hints/etc in this support thread are asking about) and submit that to the downloads section??

Just submitted an intermediate update to the add on section and waiting for aproval. (v 1.5.4)

Items taken care off:
1. Changed action keywords to be compatible with 1.39h.
2. Made the mod multi-language.
3. Made the mod multi-currency.
4. Included dutch language files.
5. Minor fix in the HTML header. (no more error display)
6. Removed fixed file names and replaced by FILENAME_ORDER_EDIT.
7. Upgraded order status and send email to the new layout. (Like the order details)
8. Changed the fixed texts in language defines.
9. A lot of cleaning up and rewriting to standard zen functions.

TO DO in next versions:
1. Automatic tax calculations following the settings in the store.
2. Integration of support for some other mods.
3. Change some input fields in dropdown.
4. a lot of code formatting for better readebility.

[asekeris]

Is is just an intermediate update to fix the 1.39h compatibility with some of the quirks fixed.
All other problems are worked on and in the end get into this version in the download section.
By then i will make a decision about the version number.

[DivaVocals]

Is is just an intermediate update to fix the 1.39h compatibility with some of the quirks fixed.
All other problems are worked on and in the end get into this version in the download section.
By then i will make a decision about the version number.

It's not the version numbering I am concerned about.. The version you submitted does not include ANY of the updates/enhancements/fixes which were incorporated into v2.xx of this module that most of us use.. (the version that sturner fixed) The version you submitted is a step back for those of us using the v2.xx versions of Edit Orders..