Tabbed Products Pro (TPP) Contrib - Official Thread

[schoolboy]

Minify is PHP version dependant...

[Brent]

I think I should be OK as my host is running PHP Version 5.2.12?

Also surely if it was a version issue it wouldn't load CSS across the board? Seems strange that it loads in some places and not others.

[smoke133]

Hi,

Everything seems OK until I enable Minify. After this my CSS files are not loaded but this ONLY happens when viewing a product. On other screens the CSS is loaded.

If I replace /includes/templates/MY_TEMPLATE/common/html_header.php with the default version my CSS loads but I obviously don't have tabs.

Brent

What CSS loader and version are you using?

[Brent]

What CSS loader and version are you using?

Many thanks for showing interest as I'd given up hope.

As it happens after many sleepless nights I finally cracked this nut today! I'll post the solution to save some other poor sod the same aggravation.

I was using TPP V1.07 with the bundled CJ Loader and installed on the Classic template I had no problems. Using my template I could not get it to work. I therefore took V1.06 and merged Zen V1.3.9h changes. This installed and ran without any problems.

I then installed the latest version of CJ Loader but as soon as I enabled Minify none of my CSS or Java loaded. To cut a very long troubleshooting process short it turns out the problem was caused by neither of these mods. I was running easySlider on my home page. Enabling Minify also broke that and searches found the following thread. Following that advice fixed easySlider and hey presto all my other CSS and Java started loading.

After all this though I'm not convinced I'm seeing a large increase in load speeds using Minify.

[DivaVocals]

After all this though I'm not convinced I'm seeing a large increase in load speeds using Minify.

**nods in agreement** I have similar questions with regards to various minify scripts I've used on WordPress.. In addition to the issues/conflicts that come up from using these minify scripts..

[Brent]

**nods in agreement** I have similar questions with regards to various minify scripts I've used on WordPress.. In addition to the issues/conflicts that come up from using these minify scripts..

Glad it's not just me then. As I'm no coder and simply a merge merchant I assumed I must be missing something. What worried me is that they no longer appear to be running CJ Loader on eazyecommerce . com as all the style sheets are loaded individually.

Would your advice be to stick solely with V1.06 merged with Zen V1.3.9h changes and drop CJ Loader?

[DivaVocals]

Glad it's not just me then. As I'm no coder and simply a merge merchant I assumed I must be missing something. What worried me is that they no longer appear to be running CJ Loader on eazyecommerce . com as all the style sheets are loaded individually.

Would your advice be to stick solely with V1.06 merged with Zen V1.3.9h changes and drop CJ Loader?

v1.07 is 1.06 with the required v1.3.9h changes.. I just decided to throw in the latest CJ Loader too.. It's not REQUIRED to use the CJ Loader..

[Brent]

v1.07 is 1.06 with the required v1.3.9h changes.. I just decided to throw in the latest CJ Loader too.. It's not REQUIRED to use the CJ Loader..

At first glance though it's not obvious to anyone who isn't a coder that the two are basically the same. Even when doing a file compare of the two versions. Partly because there have been name changes between the two versions.

/includes/templates/your_template/css/stylesheet_tpp.css become /includes/templates/your_template/css/tpp.css

/includes/templates/your_template/jscript/jscript_tpp.js became /includes/templates/your_template/jscript/tpp.js

What really creates the major headache though is the addition of /includes/templates/your_template/common/html_header.php as it is in no way clear if this is introduced by TPP or CJ Loader. On top of that the version shipped with TPP bears no resemblance to the version that ships with CJ Loader. Various discussions on that here.

By the way I had assumed the functionality that allows you to load the style sheet from Admin was a TPP update that had been slipped in between V1.06 and V1.07. Does this actually come from CJ Loader then?

Could you possibly post a copy of your V1.06 with 1.3.9h changes so that I can double check I haven't missed anything? Also in view of the fact that there is some doubt of Minify it would be good to give other users the choice between the two versions.

Many thanks for all your hard work supporting this add-on. I've read and re-read every post in this thread and many of your earlier answers helped me fit all the pieces together.

[DivaVocals]

I don't know what versions or files you are comparing.. v1.07 is simply v1.06 with the required changes to TWO files for Zen Cart 1.3.9h compatibility.

Updated to files to include 1.3.9 modifications.
~ includes/templates/YOUR_TEMPLATE/templates/tpl_product_info_display.php
~ includes/templates/YOUR_TEMPLATE/common/html_header.php
Author: C Jones
Version: 1.07
Zen Cart™ Version: v1.3.9
Update added on Aug 29 2010
PHP 5.3 Compatible?: Yes
Download Now!
File size: 390034 bytes

Some of the files you mention sound like the old v1.05 files.. I suggested you download the 1.06, 1.06, and 1.07 versions again and do your file comparisons again.. You are mixing up files between three different versions..

At first glance though it's not obvious to anyone who isn't a coder that the two are basically the same. Even when doing a file compare of the two versions. Partly because there have been name changes between the two versions.

/includes/templates/your_template/css/stylesheet_tpp.css become /includes/templates/your_template/css/tpp.css

/includes/templates/your_template/jscript/jscript_tpp.js became /includes/templates/your_template/jscript/tpp.js

What really creates the major headache though is the addition of /includes/templates/your_template/common/html_header.php as it is in no way clear if this is introduced by TPP or CJ Loader. On top of that the version shipped with TPP bears no resemblance to the version that ships with CJ Loader. Various discussions on that here.

By the way I had assumed the functionality that allows you to load the style sheet from Admin was a TPP update that had been slipped in between V1.06 and V1.07. Does this actually come from CJ Loader then?

I don't have any additional files to share.. I shared my "V1.06 with 1.3.9h changes" when I submitted the update to TPP (AKA v1.07 of TPP)..

Could you possibly post a copy of your V1.06 with 1.3.9h changes so that I can double check I haven't missed anything? Also in view of the fact that there is some doubt of Minify it would be good to give other users the choice between the two versions.

Many thanks for all your hard work supporting this add-on. I've read and re-read every post in this thread and many of your earlier answers helped me fit all the pieces together.

[Brent]

I don't know what versions or files you are comparing.. v1.07 is simply v1.06 with the required changes to TWO files for Zen Cart 1.3.9h compatibility.


Some of the files you mention sound like the old v1.05 files.. I suggested you download the 1.06, 1.06, and 1.07 versions again and do your file comparisons again.. You are mixing up files between three different versions..

Just downloaded V1.06 and V1.07 again to do another compare and the differences I mentioned above are indeed there.