[Done 1.3.9] Storage of email_html in email_archive table problematic

The way HTML email are stored is incompatible with retransmission using the zen_mail function, since the $block variable cannot easily be reconstructed. As a suggested workaround, a plain text email could be resent easily if the following change was made to functions_email.php:

If the $module value 'resend" is used, blank out email_html right before the AFTER_EMAIL_FORMAT_DETERMINED notifier i.e.

  if ($module == 'resend') {
    $email_html='';  // just blank out the html portion if resend from admin
  }
  //notifier intercept option
  $zco_notifier->notify('NOTIFY_EMAIL_AFTER_EMAIL_FORMAT_DETERMINED');

This change would allow the Email Archive Manager to be able to resend at least text based email when the customer's email preference is HTML and the Store has Configuration->Email Options->Use Mime HTML set to true.

Thanks,
Scott

swguy:

The way HTML email are stored is incompatible with retransmission using the zen_mail function, since the $block variable cannot easily be reconstructed.
Can you elaborate on the difficulties of reconstructing?

Unless there's an inverse to zen_build_html_email_from_template() that turns an $html_email into a $block, it doesn't look possible to me. Am I missing something? How would you propose to regenerate the block array from what is stored in the email_html column?

Well, since the HTML content is stored in the database as the actual HTML sent, there's no need to process the data as a template.

So maybe it's best to change this line:$email_html = zen_build_html_email_from_template($module, $block);to this:```
$email_html = [B](!is_array($block) && substr($block, 0, 6) == '<html>') ? $block : [/B]zen_build_html_email_from_template($module, $block);

Nice!

Say, while you're in there :smile: could we please have a parameter to force text-only email? This frees you from the need to build a new template.

Not sure what exactly you mean.

I'd like one of the parms to zen_mail to be "force the use of plain txt" so it doesn't look for a template.

In terms of re-sending an email via the admin addon?

Just meant in terms of possible changes to includes/functions/functions_email.php (since you were in there anyway).

Cool. There are lots of improvements in that area in 2.0, including the ability to specify text-only (a good case for that is XML-only content and such), etc. The entire email content has been split off into templates, for both text and html content, with lots of parameter options available. Further details will be furnished around the time of release.

Looking forward to it! :smile: Thanks.