Local Sales Tax Mod - Support Thread

Small tweak: in readme_local_sales_tax.html, the h1 title is wrong. (Says "Optional/Required Shipping Insurance")

swguy:

Small tweak: in readme_local_sales_tax.html, the h1 title is wrong. (Says "Optional/Required Shipping Insurance")
Thanks, updated on GitHub.

For anyone trying to use the 2.5.3 uninstall script to move up to 3.0.0, there is a problem with the uninstall script:

Around line 36 in /YOUR_ADMIN/includes/init_includes/init_local_sales_taxes_uninstall.php:

if(defined(MODULE_ORDER_TOTAL_COUNTY_LOCAL_TAX_STATUS)) {

Replace with :

if(defined('MODULE_ORDER_TOTAL_COUNTY_LOCAL_TAX_STATUS')) {

This should clear the 500 server errors that pop up.

retched:

For anyone trying to use the 2.5.3 uninstall script to move up to 3.0.0, there is a problem with the uninstall script:

Around line 36 in /YOUR_ADMIN/includes/init_includes/init_local_sales_taxes_uninstall.php:

if(defined(MODULE_ORDER_TOTAL_COUNTY_LOCAL_TAX_STATUS)) {

> 
> Replace with :
> 
> ```php
if(defined('MODULE_ORDER_TOTAL_COUNTY_LOCAL_TAX_STATUS')) {

This should clear the 500 server errors that pop up.
FWIW, the encapsulated version takes care of the upgrade itself.

BTW the doubling issue that both @retched and I experienced is resolved for new orders by this update. Thanks for your hard work, @lat9!

PHP 8.3 / ZC 2.1.0 / Local Sales Tax 3.0.0

Running into a problem. The module installs correctly (had to remove the Smash Taxes module changes). The table is currently set up for NY State (4.0%) and a tax rate based off of Zip Code (4.875%). However, checking out, I get the following:

The local sales tax rate works fine but for some reason the state sales tax isn't being calculated. When I disable the Local Sales Tax Plugin, the state sales tax is being calculated.

Should I just give up and dump the 4% onto the Local Sales tax table?

Do you have a 4% tax defined for the NY State zone?

lat9:

Do you have a 4% tax defined for the NY State zone?

Correct. New York has a zone defined with the 4% tax rate.

Again, I can disable the Local Sales Tax and the 4% tax rate is applied. But if I enable LST, the 4% tax setting is ignored.

Didn't you modify Squash Taxes to include state tax? Maybe check that logic or even uninstall Squash Taxes.

Possibly useful data point: I have ZC 2.1.0 + Latest Local Sales Tax, my LST rates do include State tax, but I have another state which is also taxed that does not use LST. Ordering with delivery to that state works as expected, with the native Zen Cart sales tax being applied properly.

swguy:

Didn't you modify Squash Taxes to include state tax? Maybe check that logic or even uninstall Squash Taxes.

Possibly useful data point: I have ZC 2.1.0 + Latest Local Sales Tax, my LST rates do include State tax, but I have another state which is also taxed that does not use LST. Ordering with delivery to that state works as expected, with the native Zen Cart sales tax being applied properly.

I did have those changes but I reverted all of those changes to barebones ZC 2.1.0 files. Trying to track down what else could I have changed.

retched:

I did have those changes but I reverted all of those changes to barebones ZC 2.1.0 files. Trying to track down what else could I have changed.
Nope, it's (again) my bad. The current implementation of the encapsulated version "assumes" (falsely, obviously) that the state's base tax-rate is baked into the local sales tax rates.

An update is forthcoming.

lat9:

Nope, it's (again) my bad. The current implementation of the encapsulated version "assumes" (falsely, obviously) that the state's base tax-rate is baked into the local sales tax rates.

An update is forthcoming.

While you're at it, there is one additional "old version" file that could be deleted by the upgrader, the admin version of "local_sales_taxes.php". You currently have it as local_sales_tax.php on line 80 of the ScriptedInstaller.php.

I think that the local taxes are not applied for store pickup orders. When notify_order_cart_external_tax_rate_lookup() is called, $taxZoneId is the shipping address zone_id, not the store's zone_id. I do have "Store Pickup Tax Basis" in the local sales tax config set to the zone of the store.

I have posted a possible fix in the repo for this plugin's Issues section.

v3.0.1 of "Local Sales Tax" is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=422

This release contains changes associated with these GitHub issues:

#5: Include state's base tax-rate in the local sales tax.
#6: Correct previous plugin removal; the base admin tool's name was local_sales_taxes.php.
#8: Incorrect tax-rate charged for storepickup orders.

v3.0.2 of "Local Sales Tax" is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=422

This version "really" corrects the calculation for storepickup orders (thanks @proseLA for the update).

Before I make a suggestion, the "state" sales tax is supposed to be added into the shipping tax rate, correct?

What I noticed is the regions tax isn't applied or added into the shipping tax rate? I have a way to fix but I wanted to be sure that was intended or not before I push something through.

retched:

Before I make a suggestion, the "state" sales tax is supposed to be added into the shipping tax rate, correct?

What I noticed is the regions tax isn't applied or added into the shipping tax rate? I have a way to fix but I wanted to be sure that was intended or not before I push something through.
Some states require tax on shipping, some don't.

lat9:

Some states require tax on shipping, some don't.

But that's what I mean, my shipping method has the tax class set and it calculates the local sales tax portion... but for some reason the state sales tax isn't added on.

For example, say a shipping method sent to NYC was $1.00. State tax is 4% and local (NYC) tax is 4.875%. I can see that the tax rate of 4.875% is set but for some reason, the state tax isn't. If I disable the local sales tax module, it's the inverse (the state tax of 4% would apply). But it should be both.