Forums / Bug Reports / [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

[Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Locked

Views: 5,128

Results 1 to 16 of 16
This thread is locked. New replies are disabled.
4 Jan 2009, 5:26 PM
#1
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

[Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Symptom:

When adding products with BUY NOW button from product listing pages (categories) or from all new featured etc. the added product (when not going to cart) title is added to the breadcrumb and stays there while in that category or all new feature going from page to page (next) etc...This looks especially bad in the categories since the last breadcrumb title becomes the heading.

This issue does not exist when there is a Buy Now quantity box enabled on the listings pages, only with the button "Buy Now"

This seems to be related to this older bug from 1.3.5.

Is there a tweak to the /includes/init_includes/init_cart_handler.php page?

Currently:

running ZC 1.38a:

admin settings:

  1. admin>Config>My Store>Display the shopping cart after adding a product (or return back to their origin) set to false. (do not goto cart)

2.admin>Config>Product Listing>Display Product Add to Cart Button (0=off; 1=on; 2=on with Qty Box per Product) to 1 or 2 (I have mine set to 1)

  1. Listing a product: admin>Catalog>Categories/products>Product in Category>Products Quantity Box Shows: No, Do not show Quantity Box.

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

4 Jan 2009, 6:10 PM
#2
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

I cannot seem to reproduce this ...

Are you controlling when the Add to Cart/Quantity shows on a per product basis or what on your site?

Have you an URL where perhaps we could see this?

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

4 Jan 2009, 7:32 PM
#3
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

90% of my products are a quantity of one, so with each product I list I set the (see jpeg)> 3. Listing a product: admin>Catalog>Categories/products>Product in Category>Products Quantity Box Shows: No, Do not show Quantity Box. so the ADD to Cart button appears and does not show a quantity box in the product info page, I have the Buy Now buttons enabled by the admin setting above (2), I guess the setting on (3) makes it so the setting on (2) doesn't matter if its 1 or 2.

here is temp link to my site The site link is slow so I will PM the link too.

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

5 Jan 2009, 3:18 PM
#4
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

A good temporary fix for now for :

if no quantity box is set from the listing of the product+do not go to cart+show BUY NOW buttons without quantity box = above issue

Temporary solution:

in includes/classes/shopping_cart.php:

around line 1709:

//    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters)));
    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters, $products_id) . 'products_id=' . $_GET['products_id']));

change to:

  }
//    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters)));
    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters, $products_id)));
  }

Thanks Ajeh for this fix!:flex:

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

20 Jan 2009, 11:46 PM
#5
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Update: the above bug fix creates this issue.

I have tried every admin setting work around to fix the 1st issue without creating the second.:lamo:

It does not seem possible to have Buy it now buttons on the product listing, all, featured, new pages without going somewhere (shopping cart, product info etc)

If a product is added from the above pages without going somewhere, the product info will appear in the breadcrumb and heading (product listing) and stay there, until the user moves out of the listing, all, featured, new pages.

I do not have any mods that would affect this function only the shopping_cart.php page has been alerted from the 1.38a fileset with the SQL injection update

Other than crippling the reviews pages...is there a solution?

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

21 Jan 2009, 3:48 AM
#6
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

I think I am missing something here ...

You want to be able to have the Listings and use the Buy Now button and stay on the Listing and not show the Product last added to the Cart in the Breadcrumb ... correct?

In Configuration ... Product Listing ... set to 1:

Display Product Add to Cart Button (0=off; 1=on; 2=on with Qty Box per Product)
Do you want to display the Add to Cart Button?

NOTE: Turn OFF Display Multiple Products Qty Box Status to use Option 2 on with Qty Box per Product

Set to 0:

Display Multiple Products Qty Box Status and Set Button Location
Do you want to display Add Multiple Products Qty Box and Set Button Location?
0= off
1= Top
2= Bottom
3= Both

In Configuration ... My Store ... Set to false:

Display Cart After Adding Product
Display the shopping cart after adding a product (or return back to their origin)

Have you an URL where you have added the change I posted that you are still getting this to display?

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

21 Jan 2009, 5:39 AM
#7
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Sorry, if I wasn't clear. You read thousands of posts, I should be more specific in my postings.

The last code fix you provided fixed the issue I was having with the breadcrumb, however by changing the code it creates a new issue in the reviews section (product not found). Please see the url links in my last post.

Is there a fix for the reviews page? or a better solution for the first issue?

to recreate: set product quantity to 1, do not display a quantity box, do not display a quantity box in the product listings, enable buy now buttons only, set to not go to cart when product is added. Add a product with a buy now button on a product listing page, or ALL, new , featured etc.

I think this is a bug.

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

21 Jan 2009, 2:19 PM
#8
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Have you a specific URL and the click for click to reproduce this problem on your site?

So far, I am not seeing it ... :unsure:

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

21 Jan 2009, 3:11 PM
#9
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

See if this makes a difference for you:

//    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters)));
    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters, $products_id) . ($_GET['main_page'] !='index' ? 'products_id=' . $_GET['products_id'] : '')));

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

21 Jan 2009, 5:53 PM
#10
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Well ... then the listings are bad ... :blink:

I am going to have to chew on this one for awhile ... maybe if I try ... :lamo:

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

21 Jan 2009, 9:13 PM
#11
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Best I can come up with at the moment to fix the breadcrumbs when the Display Cart is set to false when adding products so that the bread crumb doesn't show the product name is to use this in the shopping_cart class around lines 1708-1709:

//    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters)));
    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters, $products_id) . (!in_array($_GET['main_page'], array(FILENAME_PRODUCTS_ALL, FILENAME_PRODUCTS_NEW, FILENAME_PRODUCTS_FEATURED, FILENAME_DEFAULT)) ? 'products_id=' . $_GET['products_id'] : '')));

See if that works better for you now ...

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

21 Jan 2009, 11:59 PM
#12
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

New fix works on everything but featured products, and advanced search (forgot to mention that page too) Since I also have the wishlist mod those pages are also affected.

Maybe until a more permanent global fix is arrived at, perhaps its easier to just go with your first fix :flex:and disable the buy now button fuction the the reviews pages....

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

22 Jan 2009, 3:01 PM
#13
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

You can add additional defines from the filenames.php file to that array on when the products_id should not be included ...

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!

22 Jan 2009, 9:26 PM
#14
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

Ok, I will test it out....thanks for your help!:bigups:

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

29 Jan 2009, 4:06 PM
#15
dharma avatar

dharma

Totally Zenned

Join Date:
Nov 2006
Posts:
505
Plugin Contributions:
0

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

This seems to work ok:

//    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters)));
    zen_redirect(zen_href_link($goto, zen_get_all_get_params($parameters, $products_id) . (!in_array($_GET['main_page'], array(FILENAME_PRODUCTS_ALL, FILENAME_PRODUCTS_NEW, FILENAME_FEATURED_PRODUCTS, FILENAME_ADVANCED_SEARCH_RESULT, UN_FILENAME_WISHLIST, UN_FILENAME_WISHLIST_FIND, FILENAME_DEFAULT)) ? 'products_id=' . $_GET['products_id'] : '')));

I corrected FILENAME_FEATURED_PRODUCTS and added FILENAME_ADVANCED_SEARCH_RESULT and WL pages, manufacturers pages seem to be thrown in for free (maybe covered by FILENAME_DEFAULT) .

Can't think of any other pages that add to cart....

Thanks again for the fix!
:rolleyes:

Zencart 1.3.9h - PHP 5.2.13 - My SQL 5.0.84 - Apache 1.3.41

29 Jan 2009, 4:18 PM
#16
ajeh avatar

ajeh

Oba-san

Join Date:
Sep 2003
Location:
Ohio
Posts:
62,757
Plugin Contributions:
1

Re: [Done v1.3.9f] Breadcrumb:: Product Listing Title :: Buy Now Button

You are most welcome ... thanks for the update on what worked best for you ... :smile:

Linda McGrath
If you have to think ... you haven't been zenned ...

**Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!**

Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today!]
Officially PayPal-Certified! Just click here

Try our Zen Cart Recommended Services - Hosting, Payment and more ...
Signup for our Announcements Forums to stay up to date on important changes and updates!