SitemapXML v.2

@torvista
Yes you were spot on. My Iobit Malware had my 7zip in the blocked folder.

Thanks for the heads up on finding the culprit.

ianhg:

Brilliant that seems to have worked for me Zencart 1.5.8 Bootstrap V3.5.0 and PHP7.4.. Thanks you

That works for you on Zencart 1.5.8? I'm trying to upgrade from 3.9.3 on zencart 1.5.5, but running into the usual language defines problem. The 3.9.6 release, and the github repo @mc12345678 linked to, contain the old fashioned languages/english/sitemapxml.php file format, but I believe 1.5.8 requires the new lang.sitemapxml.php style with array definitions to be loaded by $languageLoader. I'm attempting a manual conversion, but some bumps in the road, e.g. SITEMAPXML_SITEMAPINDEX_HTTP_LINK is defined and then used in the same file, so you can't define it in an array and use it later in that same array, the way you could when they were define() statements.

Also the menu item seems to have dropped off my Tools menu, apparently my admin_menus database row has page_name 'BOX_TOOLS_SITEMAPXML' and this constant is no longer defined. My old version was zen-cart-sitemap-xml 3.9.3, looks like I'll have to fix up the database menu entries manually to fit the new language define names. I can see that one can invoke the admin/index.php?cmd=sitemapxml&action=install by typing it into the browser address bar to trigger it, but how is it supposed to run otherwise? The 'Install' section in README.md just talks about going to Tools->Sitemap XML which won't appear without the admin_pages / admin_menus database rows.

I've run into this broken admin menu language key problem a few times over the years. Anyone else think it would be helpful to add an else block in admin_access.php zen_get_admin_pages() where it tests "if (defined($row['main_page']) && defined($row['page_name'])) {" so it could log which one was not defined when it fails?

Anyone else think it would be helpful to add an else block in admin_access.php ...

This has already been done.
https://github.com/zencart/zencart/pull/5412

I believe 1.5.8 requires the new lang.sitemapxml.php style
No. It will load the old-style language defines, and there are no plans to drop that.
Personally I have left all add-ons using the old language defines, to keep them all visually separate from the core files in file listings/comparisons.

swguy:

This has already been done.

Thanks for the link, but that's zen_get_menu_titles(), not zen_get_admin_pages() that I was talking about :)

torvista:

No. It will load the old-style language defines, and there are no plans to drop that.

I must have missed this in my read through the new language system docs. Still a bit blind about the system.

>I must have missed this in my read through the new language system docs

No, maybe you are as stupid as me and just don't understand plain english either:

https://github.com/zencart/documentation/issues/988

torvista:

No, maybe you are as stupid as me and just don't understand plain english either:

If I understand your point, I think I agree with you, the docs seem to be quite clear that the language file format and loading system was changed, and the old way of using define statements no longer works. There's language to that effect in a few places in the docs you linked indirectly to https://github.com/zencart/documentation/blob/master/content/dev/code/158_language_files.md (with use of statements such as "has changed", "will no longer work" etc) .. I don't think it's unreasonable to assume that any old languages/<lang>/file.php file would be completely ignored under ZC 1.5.8, that was certainly my assumption. If it's actually a hybrid system that supports the old and new ways of loading language strings, it slipped me by completely. We have a pretty complex site with many customised and custom pages plus addons, some of which have become core ZC, some of which haven't been ported to 1.5.8 yet and I've had to do a hack job on, lots to keep track of. Late here, will bash my head against it more tomorrow. Was hoping to go live tomorrow but probably slip another day with other problems raised today.

dbltoe:

This one should be working.

You can also try https://github.com/dbltoe/Sitemap-XML-4 BUT, all bets are off with the "off-brand" SEO. :(

I installed this version, but the result is not correct, it don't taking care of dynamic naming. We still see the product ID not the name

it suppose to look like this:

The old version the SitemapXML v3.3.3 works perfectly with Zencard 1.55F, but not compatible with 1.57d

Does someone could tell to me if it change something for Google index robot, if it see the product ID **products_id=1151 **instead the product name yo-zuri-3d-inshore-popper-lures-sardine-1193

peter_pechesud:

Does someone could tell to me if it change something for Google index robot, if it see the product ID **products_id=1151 **instead the product name yo-zuri-3d-inshore-popper-lures-sardine-1193
What URL rewriter are you using? That doesn't look like either Ceon URI Mappings or Ultimate URLs formatting.

I'm using Magic SEO URLs for Zen Cart v1.3.x/1.5.x 6.2

peter_pechesud:

I'm using Magic SEO URLs for Zen Cart v1.3.x/1.5.x 6.2
Probably (keyword) because that URL-mangler isn't watching for notifications from the zen_href_link like Ultimate SEO URLs and* Ceon URI Mappings*** do.

Hi,

I am just installing your Sitemap to my new shop ZC 1.5.8.a, but it not works.
i see many problems by includes/classes/sitemapxml.php

like this:
[24-Apr-2023 10:13:52 UTC] Request URI: /index.php?main_page=sitemapxml&rebuild=yes, IP address: 212.96.184.184, Language id CZK
#0 /pub/amforawa/vialux.cz/web/www/includes/classes/sitemapxml.php(98): zen_debug_error_handler()
#1 /pub/amforawa/vialux.cz/web/www/includes/modules/pages/sitemapxml/header_php.php(66): zen_SiteMapXML->__construct()
#2 /pub/amforawa/vialux.cz/web/www/index.php(35): require('...')
--> PHP Deprecated: Creation of dynamic property zen_SiteMapXML::$base_url_index is deprecated in /pub/amforawa/vialux.cz/web/www/includes/classes/sitemapxml.php on line 98.

or

PHP Fatal error: Uncaught Error: Cannot access private property queryFactory::$count_queries in /pub/amforawa/vialux.cz/web/www/includes/classes/sitemapxml.php:735

and many others

Could you help me?
thank you Dalibor

You want to change

$this->statisticModuleQueries = $db->count_queries;

to

$this->statisticModuleQueries = $db->queryCount();

Alternately, you can downgrade to PHP 8.1 until someone else has fixed this whole file; there are other changes that will be required as well.

Version 3.9.9 of SitemapXML is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=367

This version

• Drops support for Zen Cart versions prior to 1.5.7; tested on PHP versions 7.3 through 8.2 and Zen Cart 1.5.7 through 1.5.8a.
• Provide interoperability with PHP 8.2, defining all class variables and removing usage of the now-deprecated utf8_encode function.
• Removes the automatic Zen Cart check for plugin updates as that can have adverse performance implications for a site's admin processing.
• Corrects MySQL fatal errors when run with more strict (e.g. MySQL 8) SQL servers.
• "Refreshed" the majority of the PHP files to use now-current PHP and Zen Cart programming styles and removing code that was required for Zen Cart versions prior to 1.5.7 and/or PHP versions less than 7.3.
• Removed configuration multi-language support.

Current GitHub repository: https://github.com/lat9/sitemapxml

Thanks Cindy!

Could the other separate versions kicking around Github integrate their changes and/or disappear....? It's messy and confusing.

FWIW, I based my version on @mc12345678's repository, bringing in the (for whatever reason unmerged) issue #2 as well as the 3.9.7/3.9.8 version updates provided by @highburyeye.

I scoured this support-thread for other issues and believe (keyword) that I've addressed them all.

torvista:

Could the other separate versions kicking around Github integrate their changes and/or disappear....? It's messy and confusing.
Gone from me.