[Done v1.3.9] Zen 1.3.7 UPS Shipping Module Version 4674

I have zen-cart 1.3.7 and found a bug with UPS shipping module. We have never been able to get international shipping methods beyond the US and Canada to work. I found out why.

For starters the current UPS shipping module does not offer the WXS shipping method which is Worldwide Express Saver (might add it later?)

When i got it to add that method i found it was showing only $1 shipping charge. The reason is in teh UPS.php module around line 170 the returned cost from UPS is returned as $1,213.87 but as a string and not an int. So when it goes on to do the cost calc of ($cost + MODULE_SHIPPING_UPS_HANDLING) * $shipping_num_boxes) the multiplication of the number of boxes causes it to reset the value to $1 cause the returned value from UPS is a string (due to the comma for it being over $1,000). I added a preg_replace to remove the , from the returned value and it fixed it but i think this should be looked at and fixed in future releases or maybe it was and i dont have the newest verison.

You might try using the UPSXML addon. I'm uncertain whether it's compatible with your v1.3.7 though, as I haven't used it.

DrByte:

You might try using the UPSXML addon. I'm uncertain whether it's compatible with your v1.3.7 though, as I haven't used it.

I have used UPSXML before, need to try it on 1.3.7 but shouldnt something like that be fixed on the normal UPS version? I mean im sure shipping prices over $1,000 are not very common but some sites will have them and its a major issue if they are unable to quote proper shipping due to that. Just a suggestion.

Kamino84:

... in teh UPS.php module around line 170 the returned cost from UPS is returned as $1,213.87 but as a string and not an int. So when it goes on to do the cost calc of ($cost + MODULE_SHIPPING_UPS_HANDLING) * $shipping_num_boxes) the multiplication of the number of boxes causes it to reset the value to $1 cause the returned value from UPS is a string (due to the comma for it being over $1,000). I added a preg_replace to remove the , from the returned value and it fixed it but i think this should be looked at and fixed in future releases or maybe it was and i dont have the newest verison.This has been fixed in the upcoming v1.3.9 release.

For those using v1.3.8a, would the UPSXML addon solve this problem?

One would have to test it to find out. I haven't.

Ok, is there something that can be used now with v1.3.8a to correct the situation?

What is the URL of the site where you're experiencing the problem?

Don't have one at this time.

Previous Bug Reports with a [Done vX.XX] in the Title have also provided code or a patch that one could use with v1.3.8a. Having already created a personal v1.3.8a that includes many Security & Bug patches, I wanted to included this fix as well.

If none available at this time, that would be good to know as well.

In the ups.php you could change the code from:

        // EOF: UPS USPS
        $methods[] = array('id' => $type,
                           'title' => $this->types[$type],
                           'cost' => ($cost + MODULE_SHIPPING_UPS_HANDLING) * $shipping_num_boxes);

to read:

        // EOF: UPS USPS
        $cost = preg_replace('/[^0-9.]/', '',  $cost);
        $methods[] = array('id' => $type,
                           'title' => $this->types[$type],
                           'cost' => ($cost + MODULE_SHIPPING_UPS_HANDLING) * $shipping_num_boxes);

Thanks Linda.

For those following this thread the patch is applied to:

includes/modules/shipping/ups.php - line #179