Forums / Bug Reports / [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

[Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

Locked

Started by angeljusto on 4 Aug 2009, 11:44 AM · Views: 2,938

Results 1 to 8 of 8
This thread is locked. New replies are disabled.
4 Aug 2009, 11:44 AM
#1
angeljusto avatar

angeljusto

New Zenner

Join Date:
Jan 2009
Posts:
5
Plugin Contributions:
0

[Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

Sorry to bother you because I am most probably wrong and this is not a bug, I thought I better post it just in case. I haven't found any post on this subject.

In Zencart 1.3.8, ot_shipping.php, at line 61, we have:

if (!defined($GLOBALS[$module]->tax_basis)) {

The thing is, left like that, no matter what I choose in the admin, I always get the default "Store" basis for shipping tax calculation, because the property always evaluates as not defined.

I changed this for:

if (!isset($GLOBALS[$module]->tax_basis)) {

And it seems to work as it should. Am I doing somehting wrong?

4 Aug 2009, 8:26 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

You're correct. The change you suggested is appropriate.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

4 Aug 2009, 10:03 PM
#3
jw00dy avatar

jw00dy

New Zenner

Join Date:
Jan 2007
Location:
Tooele, UT
Posts:
4
Plugin Contributions:
0

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

What is the full path to that file?

Just another squirrel trying to get a nut :)

4 Aug 2009, 10:07 PM
#4
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

/includes/modules/order_totals/ot_shipping.php

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

4 Aug 2009, 10:14 PM
#5
jw00dy avatar

jw00dy

New Zenner

Join Date:
Jan 2007
Location:
Tooele, UT
Posts:
4
Plugin Contributions:
0

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

Oh you beat me to it :)

Thank you.

Just another squirrel trying to get a nut :)

5 Aug 2009, 12:27 AM
#6
sawhorse avatar

sawhorse

Zen Follower

Join Date:
Oct 2007
Location:
Kentucky - USA
Posts:
425
Plugin Contributions:
0

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

I see that line of code at line 44 not 61. I have not modified this file. I am using ZC v1.3.8a. Am I in the wrong place or missing something?

Sawhorse

ZC 1.3.8a; Addons: Admin Profiles, Ty Package Tracker; Swap Images via MouseOver or Click, Smart Backgrounds; Printable Price List; CSS buttons; Contact Us - Add Subject; Template: Self Constructed; Site: http://sawhorsejewelry.com

5 Aug 2009, 1:11 AM
#7
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

Line 44 is correct.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

5 Aug 2009, 1:16 AM
#8
sawhorse avatar

sawhorse

Zen Follower

Join Date:
Oct 2007
Location:
Kentucky - USA
Posts:
425
Plugin Contributions:
0

Re: [Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

Thank you!

ZC 1.3.8a; Addons: Admin Profiles, Ty Package Tracker; Swap Images via MouseOver or Click, Smart Backgrounds; Printable Price List; CSS buttons; Contact Us - Add Subject; Template: Self Constructed; Site: http://sawhorsejewelry.com