[bug in addon template] noindex, nofollow on all pages

I've found an error in html_header.php in multiple installations.

I have ZC installed on three sites. Since they are all v1.3.8a, with the security patch, I'm not sure exactly when this would have come in. They are all recent installs from separate hosting company's "fantastico" script installers. The oldest was installed around June, the latest a few days ago, and it was described as v1.3.8a on the install screen.

The problem is NOT in the zen-cart-v1.3.8a-full-fileset-12112007.zip file I recently downloaded for reference, so I guess this would count as "fixed", but I suspect I'm not the only one with this issue.

Portions of the code controlling ROBOTS_PAGES_TO_SKIP have been commented out, it looks like a debugging thing. It should read...

<?php if (defined('ROBOTS_PAGES_TO_SKIP') && in_array($current_page_base,explode(",",constant('ROBOTS_PAGES_TO_SKIP'))) || $current_page_base=='down_for_maintenance') { ?>
<meta name="robots" content="noindex, nofollow" />
<?php } ?>

Instead it reads...

<?php //if (defined('ROBOTS_PAGES_TO_SKIP') && in_array($current_page_base,explode(",",constant('ROBOTS_PAGES_TO_SKIP'))) || $current_page_base=='down_for_maintenance') { ?>
<meta name="robots" content="noindex, nofollow" /> 
<?php //} ?>

This, of course, would have the effect of putting noindex, nofollow on all your pages.

:oops:
As I went around fixing my sites, I discovered there's a bit more going on here than I thought. Not all of them had the extra comment characters. However, they do all have the issue of putting noindex, nofollow on all pages.

My current workaround is to comment out the "robots" meta tag, which means all my pages will be indexed, but that's better than none.

http://www.zen-cart.com/forum/showpost.php?p=498927&postcount=12

bbsbcastle,
The problems you're reporting are specific to the template you're using.
Uncomment the lines that shouldn't have been commented in the first place, and you'll be fine.

The bugfix barco mentioned is also prudent to apply to your site, but deals with a similar but not identical issue.

In the future, please don't post the same problem in multiple places all over the forum, as it creates duplicated work and duplicated discussions which don't have the details of each other.
ie: http://www.zen-cart.com/forum/showthread.php?p=809513#post809513