Interoperability betwen Super Orders/Edit Orders and non-native discounting mods

If you are using Super Orders or Edit Orders and an order total discount other than Group Discounts (e.g. Better Together, Quantity Discounts, Military Discounts, Newsletter Discounts, Combination Discounts, Big Spender, Big Chooser, Frequency Discounts, or any other contribution written by someone other than me), the process of editing an order using either of those mods will flip the sign on a discount causing it to appear to be a surcharge.

The fix is straightforward; both admin/edit_orders.php and admin/super_edit.php simply list discount classes ("ot_coupon", etc.) You simply have to add any additional classes you are using to if statements in those two files which enumerate through the order total discount classes. Searching for "ot_coupon" will show you what to change.

The full fix and more notes are on my blog at http://thecartblog.com/2009/12/21/zen-cart-edit-orders-and-my-discounting-mods/

Scott

Thanks Scott -- that post was much appreciated as we were struggling with that.

Regards

Jamie

LOL donations gratefully accepted.

I am having this issue with the Edit Order add on but I am not using additional group discounting software. Please help.

I get the same exact result you described on your webpage.

My $ot_class code looks like this.

$ot_class == "ot_coupon" || $ot_class == "ot_gv"

Yet it still changes the - to a + upon editing an order.

Please help.

Matt

I also tried adding group discounts to the ot_coupon class line like this.

$ot_class == "ot_coupon" || $ot_class == "ot_gv" || $ot_class == "ot_group_pricing"

But no luck.

If I manually place a - sign in the order and click update then the - sign will remain. All new orders when I go to edit them lack the - sign on group discounts.

Looks like I got it fixed by adding the ot_group_discount to edit_orders.php.

I was looking for it to display a "-" sign and not paying attention to the actual total.

Thanks!

I still have the problem with the - sign after editing an order with a group discount. the discount turns into a surcharge.
I have already changed the edit_orders.php, are there any other changes needed?

if ($ot_class == "ot_coupon" || $ot_class == "ot_gv" || $ot_class == "ot_group_pricing")

I use zencart 138a and edit_orders 2.3.

thx.

Bram

Thank you so much for these instructions! That took care of something that's been a thorn in my side for almost 2 years. Donation on its way!

Thank you!

Just wanted to note that this fix will be incorporated into the upcoming Super Orders release.. Thanks Scott for the info!!:smile:

swguy:

If you are using Super Orders or Edit Orders and an order total discount other than Group Discounts (e.g. Better Together, Quantity Discounts, Military Discounts, Newsletter Discounts, Combination Discounts, Big Spender, Big Chooser, Frequency Discounts, or any other contribution written by someone other than me), the process of editing an order using either of those mods will flip the sign on a discount causing it to appear to be a surcharge.

The fix is straightforward; both admin/edit_orders.php and admin/super_edit.php simply list discount classes ("ot_coupon", etc.) You simply have to add any additional classes you are using to if statements in those two files which enumerate through the order total discount classes. Searching for "ot_coupon" will show you what to change.

The full fix and more notes are on my blog at http://thecartblog.com/2009/12/21/zen-cart-edit-orders-and-my-discounting-mods/

Scott

Wouldn't the better "fix" be to fix those other discounting mods to properly identify themselves as such, and produce correct output, and thus not trigger the problem?

DrByte:

Wouldn't the better "fix" be to fix those other discounting mods to properly identify themselves as such, and produce correct output, and thus not trigger the problem?
:laugh::laugh: You might be right.. Though I'm not sure how to do this.. If I understand you correctly is this something that has to be corrected in the discounting modules themselves??

Yes .

DrByte:

Yes .Got it!!:smile: