Which one should I choose :

6 Jan 2010, 8:18 PM

New Zenner

Join Date:: Oct 2009
Posts:: 16
Plugin Contributions:: 0

Which one should I choose :

I'm merging the following 2 files:
file 1: /includes/functions/html_output.php in
http://www.zen-cart.com/forum/showpo...0&postcount=10
and
file 2:/includes/functions/html_output.php in
the PHP 5.3 patch for v1.3.8a

Which one should I choose :

if ( $value == '~*~*#' && (isset($GLOBALS[$name]) && is_string($GLOBALS[$name])) && ($reinsert_value == true) ) {

if ( (isset($GLOBALS[$name]) && is_string($GLOBALS[$name])) && ($reinsert_value == true) ) {

Which one should I choose :

} elseif ($value != '~*~*#' && zen_not_null($value)) {

} elseif (zen_not_null($value)) {

Amanda

6 Jan 2010, 8:23 PM

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,513
Plugin Contributions:: 176

Re: Which one should I choose :

The first one.

But, I already answered that question in the other thread where you asked it.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

6 Jan 2010, 8:27 PM

amanda099

New Zenner

Join Date:: Oct 2009
Posts:: 16
Plugin Contributions:: 0

Re: Which one should I choose :

There are 3 differences. You answered only to the 1. in the other thread .

But, Thanks for quick response !
Amanda