Zen Follower
- Join Date:
- Sep 2012
- Posts:
- 253
- Plugin Contributions:
- 0
All Invoices Report [support]
Glad I could help you.
Views: 21,183
Zen Follower
Glad I could help you.
New Zenner
The solution for me was similar. I move the style and it worked fine. I also found this was in a <br> tag not a div just after <!-- Add page break for print out -->.
When I moved the style to the first <table> I also deleted the <br> where the style was originally located.
One slightly annoying thing is that the addon has always chucked out a blank page before printing the invoices. After the change it does the same but after the invoices are printed. Any ideas why this could be happening? I have found this since the very first version that I have installed and on different printers using different operating systems (currently Windows 7 Ultimate) and different browsers (currently IE 11. Given all these facts I would say it would be a coding issue rather than system, software or printer problem.
Zen Follower
I heavily modified this report but what I can tell you is there is something making it generate that blank page. So there is some content after the page break. I'm assuming this is after every invoice so if you are printing 10 invoices you are getting 10 blank pages and not 10 invoices with 1 blank page at the end. The fact that you say it went from a blank page before to blank page after confirms this.
Administrator
I've checked the default version of All Invoices on a 17-page printout on the most recent version of both FireFox and IE11 and I don't see the extra-page issue.
New Zenner
no issues here!
Administrator
zennedOut
hi,
i just started looking at this module for a specific need. while it does get installed on the admin side; i would still cleanse the $orderStatus variable prior to its use. from:
$orderStatus = $_GET['status'];
to
$orderStatus = zen_db_prepare_input($_GET['status']);
or perhaps making use of the bindVars instead.
i have a need to print a range of invoices; i am not sure if others have a need for that. which seems like easy enough to do. however, on first glance, this does look to be like a valuable module. thanks!
Administrator
Good point, carlwhat, I'll add that to the plugin's change-list. I'm not as concerned about the sanitizing since it's on the admin side.
zennedOut
lat9,
which one was the good point: adding an invoice range? or sanitizing the $_GET variables?
i agree, the sanitizing is not as big a concern as it is on the admin side. the invoice range is for what i needed the module. i suppose the tricky part is what invoices to include, as we have a cancelled order status which we do not want to see; but then all of other statuses we do.
i suppose the selection process could go on and on...
in addition, we implemented the super_orders and super_invoices module, so i needed to modify the formatting of the invoice to match that...
that said, a very helpful starting point for me. thanks again for this contribution.
best.
Administrator
carlwhat, I was responding to the need to sanitize the $_GET variable (just using a simple integer-cast is sufficient).
I'll add the order-range specification as a change-request to the plugin.
Zen Follower
Just a quick query if there's an updated version for 1.5.5a in the pipeline? Thank you for making this available!
Administrator
terraGirl:
Just a quick query if there's an updated version for 1.5.5a in the pipeline? Thank you for making this available!
Should be good-to-go! That's one of the benefits (usually) of a no-core-file-overwrites plugin.
Sensei
Hi lat9,
I just submitted an update (called it 2.5) which allows the storeowner to optionally update all the selected orders' status after generating the report.
It involved rearranging a couple things between files.
And the foreach which loops thru orders is v1.5.5 specific. I guess it could be changed to a "while !EOF, MoveNext()" if really needed on older versions.
.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole
Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.
Administrator
DrByte:
Hi lat9,
I just submitted an update (called it 2.5) which allows the storeowner to optionally update all the selected orders' status after generating the report.
It involved rearranging a couple things between files.And the foreach which loops thru orders is v1.5.5 specific. I guess it could be changed to a "while !EOF, MoveNext()" if really needed on older versions.
https://www.zen-cart.com/downloads.php?do=file&id=1083
Thanks, DrByte. I'll download your changes and create a v2.5.0 release in the plugin's GitHub repository.
Zen Follower
Hi..
I have just downloaded and installed the 2.1.0 version (since I have 1.5.4). The readme file is telling me that I have to go to Reports->All Invoices or Reports->All Packing Slips. But I do not see the option All invoices or reports under the reports-button (only the standard ones like customers order total and so on)
Do you happen to know what went wrong?
Administrator
LadyoftheCave:
Hi..
I have just downloaded and installed the 2.1.0 version (since I have 1.5.4). The readme file is telling me that I have to go to Reports->All Invoices or Reports->All Packing Slips. But I do not see the option All invoices or reports under the reports-button (only the standard ones like customers order total and so on)
Do you happen to know what went wrong?
That's weird, since this plugin is a "drop-in" (i.e. no existing files modified). Are you sure that you "dropped" the files in the right directory?
zennedOut
an easy way to tell if you loaded the files to the right place would be to directly call the script:
https://www.yoursite.com/YOUR_ADMIN/all_invoices.php
does that work?
unfortunately i do not remember exactly how things appear on the admin menu w/o doing a little digging....
good luck.
Zen Follower
lat9:
That's weird, since this plugin is a "drop-in" (i.e. no existing files modified). Are you sure that you "dropped" the files in the right directory?
I think I did, but I will check everything again in case I missed something..
Zen Follower
Yes, I did something wrong, it must have been the heat (extremely hot day in the Netherlands) :oops:
It is working now, but since it is working, I have two other questions (sorry :blush:):
Best Regards
Administrator
I'm glad you got it sorted; in answer to your questions:
Tell staff why this post should be reviewed.