If this is your first visit, check our documentation. To post, register or login.
Forums / Bug Reports / [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

[Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

Locked

Started by torvista on 23 Apr 2010, 11:20 AM · Views: 3,265

Results 1 to 6 of 6
This thread is locked. New replies are disabled.
23 Apr 2010, 11:20 AM
#1
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,880
Plugin Contributions:
7

[Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

Hi,
this symptom is the same in 1.38 and 1.39.

The search field "Look-up CONSTANT or Language File defines" has five filters available.

If I search for this constant:
TEXT_PRODUCT_WEIGHT_UNIT
only the two "All Main Language files...." filters return the correct results. The other three filters return nothing.

regards
Steve

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

23 Apr 2010, 3:04 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,512
Plugin Contributions:
176

Re: [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

Um ... that's because that constant is only in the "main" language files. Thus the searches of the other files will return no results.

I don't see any bug there.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

23 Apr 2010, 6:01 PM
#3
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,880
Plugin Contributions:
7

Re: [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

ok, see I can wriggle out of this one..

Looking at the options available (and actually reading them properly for the first time..) I see 2, 3 and 4, 5 are exclusive.

<option value="1">All Language Files for ENGLISH - Catalog/Admin</option>
<option value="2">All Main Language files - Catalog (/tienda_139a/includes/languages/english.php /espanol.php etc.)</option>
<option value="3">All Current Selected Language Files - /tienda_139a/includes/languages/english/*.php</option>
<option value="4">All Main Language files - Admin (/tienda_139a/admin/includes/languages/english.php /espanol.php etc.)</option>
<option value="5">All Current Selected Language Files - Admin (/tienda_139a/admin/includes/languages/english/*.php

1 - I read "All" as like er, everything - it doesn't do that, this is what confused me.
2 - looks in catalog, top-level primary language files only - works.
3 - looks in the rest of the catalog, subdirectory files, which is not really "All Currently Selected" (wriggling)
4 - looks in admin, english.php only - works ok
5 - as 3 but for admin.

So, I respectfully still think option 1 is not doing what it says on the tin.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

23 Apr 2010, 6:55 PM
#4
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,512
Plugin Contributions:
176

Re: [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

Noted.

It's unlikely to be addressed in 1.3.x, since development efforts are focused on v2.0.
And, in v2.0 the structure is slightly different (more efficient) and the problem you describe doesn't exist there.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

23 Apr 2010, 10:48 PM
#5
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,512
Plugin Contributions:
176

Re: [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

/admin/developers_tool_kit.php
Around line 246, add these 2 lines as shown:```
$check_directory[] = DIR_FS_ADMIN . DIR_WS_LANGUAGES . $_SESSION['language'] . '/';
$check_directory[] = DIR_FS_ADMIN . DIR_WS_LANGUAGES . $_SESSION['language'] . '/modules/newsletters/';
[B] $check_directory[] = DIR_FS_CATALOG_LANGUAGES;
$check_directory[] = DIR_FS_ADMIN . DIR_WS_LANGUAGES;
[/B] break;

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

24 Apr 2010, 9:32 AM
#6
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,880
Plugin Contributions:
7

Re: [Done 1.3.9b] Developers Tool Kit, "Look up CONSTANT" search filters not working

Thanks for the fix.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...