[Done v1.3.9e] With Sales Tax Display Status=1, $0 Sales tax has wrong label

In 1.3.8, the label "Sales Tax" would be used because no actual tax applied, i.e.

Sales Tax: $0.00

In 1.3.9d, a tax which does not apply is displayed:

FL TAX 7.0%: $0.00

I reviewed a few files and didn't see an obvious root cause. A patch would be to use TEXT_UNKNOWN_TAX_RATE in ot_tax.php if value is 0.

Hmm

I tested this locally and if the address of the customer is 'in scope' for the tax zones set up in the store then you are correct, that the store will show the tax description of an applicable zone.

However if the customers address is not in scope, then a generic 'Sales Tax' label is shown.

I will cook up a simple test case with a default install ASAP to show this behavior.

Hi,

Any updates on this.

Installed 139b, created fresh database.
Updated to 139d.
Tax applies to FL only at 7%.
Turn on Sales Tax Display Status 1 in Admin
Check out with a Georgia address.
Page 2 shows FL Tax 7.0%: $0.00

This should say "Sales Tax: $0.00" - no?

Hi,

You are correct :)

There are a couple of cases where the code still fails to format the tax description correctly

can you try this updated code for ot_tax.php

    function process() {
      global $order, $currencies;

      reset($order->info['tax_groups']);
      $taxDescription = '';
      $taxValue = 0;
      if (STORE_TAX_DISPLAY_STATUS == 1)
      {
        $result = zen_get_all_tax_descriptions();
        if (count($result) > 0)
        {
          foreach ($result as $description)
          {
            if (!isset($order->info['tax_groups'][$description]))
            {
              $order->info['tax_groups'][$description] = 0;
            }
          }
        }
      }
      if (count($order->info['tax_groups']) > 1 && isset($order->info['tax_groups'][0])) unset($order->info['tax_groups'][0]);
      while (list($key, $value) = each($order->info['tax_groups'])) {
        if (SHOW_SPLIT_TAX_CHECKOUT == 'true')
        {
          if ($value > 0 or ($value == 0 && STORE_TAX_DISPLAY_STATUS == 1 )) {
            $this->output[] = array('title' => ((is_numeric($key) && $key == 0) ? TEXT_UNKNOWN_TAX_RATE :  $key) . ':',
                                    'text' => $currencies->format($value, true, $order->info['currency'], $order->info['currency_value']),
                                    'value' => $value);
          }
        } else
        {
          if ($value > 0 || ($value == 0 && STORE_TAX_DISPLAY_STATUS == 1))
          {
            $taxDescription .= ((is_numeric($key) && $key == 0) ? TEXT_UNKNOWN_TAX_RATE :  $key) . ' + ';
            $taxValue += $value;
          }
        }
      }
      if (SHOW_SPLIT_TAX_CHECKOUT != 'true' && ($taxValue > 0 or STORE_TAX_DISPLAY_STATUS == 1))
      {
        $this->output[] = array(
                        'title' => substr($taxDescription, 0 , strlen($taxDescription)-3) . ':' ,
                        'text' => $currencies->format($taxValue, true, $order->info['currency'], $order->info['currency_value']) ,
                        'value' => $taxValue);
      }
    }

Nope. Still shows FL Tax.

k,

I think the problem was that I'm testing slightly differently to you, in that I was changing the primary address via the My Account section. This was masking the fact that the logic to choose the tax descriptions was only relying on the primary address, so changes made to the tax address (either by adding a new address or selecting a non primary address, would not be recognised)

So with fingers crossed, can you try this

    function process() {
      global $order, $currencies;

      reset($order->info['tax_groups']);
      $taxDescription = '';
      $taxValue = 0;
      if (STORE_TAX_DISPLAY_STATUS == 1)
      {
        $taxAddress = zen_get_tax_locations();
        $result = zen_get_all_tax_descriptions($taxAddress['country_id'], $taxAddress['zone_id']);
        if (count($result) > 0)
        {
          foreach ($result as $description)
          {
            if (!isset($order->info['tax_groups'][$description]))
            {
              $order->info['tax_groups'][$description] = 0;
            }
          }
        }
      }
      if (count($order->info['tax_groups']) > 1 && isset($order->info['tax_groups'][0])) unset($order->info['tax_groups'][0]);
      while (list($key, $value) = each($order->info['tax_groups'])) {
        if (SHOW_SPLIT_TAX_CHECKOUT == 'true')
        {
          if ($value > 0 or ($value == 0 && STORE_TAX_DISPLAY_STATUS == 1 )) {
            $this->output[] = array('title' => ((is_numeric($key) && $key == 0) ? TEXT_UNKNOWN_TAX_RATE :  $key) . ':',
                                    'text' => $currencies->format($value, true, $order->info['currency'], $order->info['currency_value']),
                                    'value' => $value);
          }
        } else
        {
          if ($value > 0 || ($value == 0 && STORE_TAX_DISPLAY_STATUS == 1))
          {
            $taxDescription .= ((is_numeric($key) && $key == 0) ? TEXT_UNKNOWN_TAX_RATE :  $key) . ' + ';
            $taxValue += $value;
          }
        }
      }
      if (SHOW_SPLIT_TAX_CHECKOUT != 'true' && ($taxValue > 0 or STORE_TAX_DISPLAY_STATUS == 1))
      {
        $this->output[] = array(
                        'title' => substr($taxDescription, 0 , strlen($taxDescription)-3) . ':' ,
                        'text' => $currencies->format($taxValue, true, $order->info['currency'], $order->info['currency_value']) ,
                        'value' => $taxValue);
      }
    }

Same issue.

k,

any possibility of a screenshot of checkout_confirmation showing the problem

Argh! I'm sorry - second patch works perfectly. I had forgotten to change my address when I ran the test again.

No problem,

Thanks for all the help in testing back and forth.