Forums / Bug Reports / [Done v1.3.9e] Manufacturers sidebox pulldown Reset - malformed url

[Done v1.3.9e] Manufacturers sidebox pulldown Reset - malformed url

Locked

Views: 1,307

Results 1 to 3 of 3
This thread is locked. New replies are disabled.
20 Jul 2010, 7:13 AM
#1
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,876
Plugin Contributions:
7

[Done v1.3.9e] Manufacturers sidebox pulldown Reset - malformed url

Hi,
after selecting a manufacturer and going to that page, the first item in the selection pulldown list changes from the original "Select" to a "Reset".

Reset produces an url without an id eg:

http://.../index.php?main_page=index&manufacturers_id=

which ostensibly goes to the index page.

However the formatting of this page is broken as

  1. $this_is_home_page is not set, so breadcrumbs are on, and any other custom hacks using this variable break.
  2. if page-specific css is in use (index_home.css), this is not applied.

regards
Steve

ps The same thing happens if an id is missing off a cPath url, but I guess that should never happen.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

20 Jul 2010, 3:21 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,515
Plugin Contributions:
176

Re: [Done v1.3.9e] Manufacturers sidebox pulldown Reset - malformed url

Try editing /includes/init_includes/init_category_path.php, at line 40:
Change this:$this_is_home_page = ($current_page=='index' && (!isset($_GET['cPath'])) && (!isset($_GET['manufacturers_id'])) && (!isset($_GET['typefilter'])) );to this:```
$this_is_home_page = ($current_page=='index' && (!isset($_GET['cPath']) || $_GET['cPath'] == '') && (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '') && (!isset($_GET['typefilter']) || $_GET['typefilter'] == '') );

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

20 Jul 2010, 10:19 PM
#3
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,876
Plugin Contributions:
7

Re: [Done v1.3.9e] Manufacturers sidebox pulldown Reset - malformed url

That fixed it thanks.

Note that the file path is:

\includes\init_includes\init_category_path.php

regards
Steve

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...