Zen Cart Logo
Forums / Bug Reports / [Done v1.3.9g] Typo results in invalid markup

[Done v1.3.9g] Typo results in invalid markup

Locked

Views: 1,238

Results 1 to 3 of 3
This thread is locked. New replies are disabled.
4 Sep 2010, 4:31 PM
#1
s_mack avatar

s_mack

Totally Zenned

Join Date:
Jun 2005
Location:
Kelowna, BC Canada
Posts:
1,033
Plugin Contributions:
4

[Done v1.3.9g] Typo results in invalid markup

/includes/modules/payment/paypaldp.php
line 535

forgetting the fact html markup should not be in this file at all anyway, what is there produces invalid code.

'<tr><td class="smallText">' . TEXT_3DS_CARD_MAY_BE_ENROLLED . '</td></table>');

Note there is no closing tr tag.

Also problematic is the use of the valign element in this file as well as many others. valign is NOT valid xhtml and hasn't been for a long time. A quick search of a FRESH copy of V1.3.9 reveals 648 instances. I'm not aware of any actual problems with the use of valign, but a page will not validate with it included.

  • Steven
6 Sep 2010, 8:08 PM
#2
ray_the_otter avatar

ray_the_otter

Zen Follower

Join Date:
Jul 2010
Posts:
278
Plugin Contributions:
0

Re: [Done v1.3.9g] Typo results in invalid markup

648 instances? i used developers tool kit and could only find 5 or 6 valign???

Is 1.3.9g going to be a monster size complex update?

Ray

6 Sep 2010, 8:25 PM
#3
s_mack avatar

s_mack

Totally Zenned

Join Date:
Jun 2005
Location:
Kelowna, BC Canada
Posts:
1,033
Plugin Contributions:
4

Re: [Done v1.3.9g] Typo results in invalid markup

I never use the developers tool kit so I'm not really sure how well that searches. I did a full text search of all files included in the release. It shouldn't be a big deal to fix them.