Forums / Bug Reports / [Done v1.3.9g] Possible Bug when Transaction IDs start with 0

[Done v1.3.9g] Possible Bug when Transaction IDs start with 0

Locked

Views: 1,206

Results 1 to 2 of 2
This thread is locked. New replies are disabled.
28 Sep 2010, 8:18 PM
#1
numinix avatar

numinix

Totally Zenned

Join Date:
Apr 2007
Location:
Vancouver, Canada
Posts:
1,567
Plugin Contributions:
58

[Done v1.3.9g] Possible Bug when Transaction IDs start with 0

One of my clients has been receiving transaction IDs that begin with 0 and then are followed by a long string of letters and numbers, typical of a regular PayPal transaction ID.

However, in the WPP function _GetTransactionDetails() it has

if ($txnID == '' || $txnID < 1) return FALSE;

As a result, the admin_notification info is coming up blank. Other than the transaction ID starting with 0, I see no other problems.

Changing it to

if ($txnID == '' || $txnID === 0) return FALSE;

Seems to work. Where 0 is the exact transaction ID returned in sandbox mode.

28 Sep 2010, 8:24 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: [Done v1.3.9g] Possible Bug when Transaction IDs start with 0

Curiously I was literally just looking at that section of code an hour ago, for the same reason, and came to pretty much the same conclusion. :blush:

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.