Zen Cart Logo
Forums / Bug Reports / [N/A] Error in instructions for global_xss_whitelist

[N/A] Error in instructions for global_xss_whitelist

Locked

Views: 832

Results 1 to 2 of 2
This thread is locked. New replies are disabled.
17 Oct 2010, 4:18 AM
#1
tick avatar

tick

New Zenner

Join Date:
Jun 2007
Location:
Phoenix, AZ
Posts:
66
Plugin Contributions:
0

[N/A] Error in instructions for global_xss_whitelist

Hello all,

There is an error in the instructions in admin/includes/init_includes/init_sanitize.php.

The instructions read:

/**
 * process all $_POST terms
 * Notes to contribution developers. 
 * If you need to add your own override for the whitelist, you should not just simply set
 * $global_xss_whitelist but merge it with any possible previous values, in order to honour other 
 * contributions.
 * 
 * eg. create an override file in the admin/includes/extra_configures directory  containing
 * 
 * $global_xss_whitelist = isset($global_xss_whitelist) ? $global_xss_whitelist : array();
 * $my_whitelist  = array('some_field_name');
 * $global_xss_whitelist = array_merge($whitelist, $global_xss_whitelist); 
 */
```For the given code to work "$my_whitelist" should be "$whitelist". It's trivial, but I for one copied and pasted from the example and had to figure out why it didn't work as expected.

Thanks!
17 Oct 2010, 9:22 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
177

Re: [N/A] Error in instructions for global_xss_whitelist

As stated in the thread that shows some recommended whitelist updates, the whole whitelist is being removed in 1.3.9h.