Security Patch?

I'm doing an early 1.3.9 to current 1.3.9 upgrade, going through every file to winmerge in changes. I note that my html_output.php (functions) file includes: the following code:

/* ~~~~! Line added re: ZenCart Security Patch 090619 */
$form .= '<input type="hidden" name="securityToken" value="' . $_SESSION['securityToken'] . '" />';

The current version of this file does not include this line as far as I can see. Does this mean the patch is no longer required, or are we to keep it in even though it has not been implimented in the newest official releases of the files?

going through every file to winmerge in changes
If you are using the template overrides - - those are the only files you should have to check for new versions and merge if there is one

And yes that has been "fixed"

kobra:

If you are using the template overrides - - those are the only files you should have to check for new versions and merge if there is one

And yes that has been "fixed"

I think that's a bit of a naive comment given the multitude of plugins and what I'm sure is hundreds of users who are capable of customizing the script. Many people make changes to Zencart's code beyond the cosmetics of the templates.

Thank you for the response though. I will delete the patched line.

What is trying to be explained here is that in an override directory, any file you retouch should be put in a folder with you template name in the directory you are working in.

The reason is when you do any upgrade you can simply upload the full contents of Zen Cart without the fear that you may overwrite any of your changes.

To answer your first question simply replace that file with the new one. If you don't want to do that because of changes that you made within that file, you will need to carry those changes over to the new file and disregard the old.

Removing that code from that file will cause problems with login.

TheHYPO:

Many people make changes to Zencart's code beyond the cosmetics of the templates.
You apparently do not fully comprehend the override system as it extends beyond just the template cosmetics

kobra:

You apparently do not fully comprehend the override system as it extends beyond just the template cosmetics

Are you suggesting (and if you are, then I'm in fact not aware of the full extent of the override system) that I could put a[template] folder and that will work in any folder of zencart, period?

I was certainly aware there were sections of zencart where I could do that (such as the langages folder, the english subfolder and the modules folder where I could (and have) put [template] subfolders in to make my changes).

But I was under the impression that this was limited to specific fodlers, and if I wanted to edit, for example, functions, functions/[template]/newfile.php would not work to override - same with classes. What about the individual "pages" under modules?

I see only now that there is an 'overrides' folder under "init_includes" - is this a different system of override that doesn't use my template name?

The other point to make is that at least 75% of changes I make are to the admin section (the backend) for the ease of the store-owner, including both installation of custom addons, and creation of my own additions or improvements. As far as I know, there is no override system in the admin section (where approximately 50% of the files I have to update were)

If I'm wrong about any of this, please let me know, as it certainly WOULD make things easier for me in the future.

Cheers.

TheHYPO,
There are not overrides for the admin
As a good coder, any core file altered is commented as such, I place kobra in the head of any edited core file so that when an upgrade is in order a quick grep of the files will list all files with that term and I now have a list of changed core files

Any added item that has it's own file(s), will not be over written in an upgrade

There are others not template related, extra_functions, override, extra_definitions, and others

As far as where template overrides can be used:

Ant dir with a classic present can have any file at that level overridden in a template dir named for the template