[Fixed v1.5.1] PHP Warning: strlen() expects parameter 1 to be string

Did you apply the modification suggested by DrByte?> just got a new debug** using modified code as above**:yes, I am using the modified code.

Steve,
I imagine you already have, but I can't resist asking if you did a winmerge of the old and new just in case.

Thanks for the interest.

This is exactly what I have in the live shop code:

       while (list($key, $value) = each($_GET)) {
      if (is_array($value)) trigger_error('GET param found to be array: ' . print_r($value, true) . '  --- contents of GET: ' . print_r($_GET, true));//steve looking for reason, as per http://www.zen-cart.com/forum/showthread.php?t=176804
        //if ( (strlen($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && (!in_array($key, $exclude_array)) && ($key != 'x') && ($key != 'y') ) {//steve original line 
    if ( (!in_array($key, $exclude_array)) && (strlen($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {//steve this line edited to stop debug error as per http://www.zen-cart.com/forum/showthread.php?p=1070316#post1070316
          if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) {

Its odd that this error is not triggered always..?
just got another, the first one since the 17th...
Can I do further testing or just forget it?

[25-Oct-2011 23:12:41] PHP Notice: GET param found to be array: Array
(
[0] => 210
)
--- contents of GET: Array
(
[main_page] => index
[action] => notify
[notify] => Array
(
[0] => 210
)

)

I've never known it to block a sale.
But, as I stated earlier, we've had no problems on any site since changing to the suggested fix.
Sorry I can't be of more help.

From my experience, this has to do with the "notify" stuff, I am using the Caixa sermepa module and kept having troubles of orders paid but not showing up on my shop.

Do not use the "notify" option, I do not know how your module works but you should be able to disable this.

Won't change anything to the way the program works, you will be notified for each order anyway but your bank will stop trying to send you a mail for this.

In my case, this was where the problem was: the notification url in the module.

Hope this help!

:unsure:

I get this error across all payment modules.
It could be a week between occurrences so no obvious pattern.

I do use Advanced Shipper so in effect it has the same shipping module in use every time so you could throw mud at that but the developer says not guilty (and is to be trusted).

The issue is that you are on PHP 5.3 and that changed the way that strlen handles arrays.

Before 5.3 strlen would return the word array for any array - hence feeding a string into the function - from 5.3 it returns NULL instead and strlen fails.

I had the same problem and fixed it by counting the elements in the array instead.

so:

 
    if ( (!in_array($key, $exclude_array)) && (strlen($value))> 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {//steve this line edited to stop debug error as per http://www.zen-cart.com/forum/showthread.php?p=1070316#post1070316
          if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) {  

would become

 
    if ( (!in_array($key, $exclude_array)) && (count($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {
          if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) { 

This assuming that you know you are always getting an array returned. If not then you would need to test if it was an array or a string earlier and set a flag to test against

I had the same problem and fixed it by counting the elements in the array instead.

Thanks for sharing that.
Maybe I'll be able to sleep at night now with no fear of random debugs in the morning!

Aureanus:

This assuming that you know you are always getting an array returned.
Therein is the problem. It is almost NEVER getting an array. The ONLY time it gets an array is when the product-notifications screen is presented. The zillion other times that the function is used there is no array passed at all.
I submit that your proposed fix is likely to cause the entire function to not return the right results, thus preventing normal operation of the majority of cases where this function is called.
Thus, its NOT SAFE to be used on live sites, unless of course you want to encounter lost sales and poor customer experience while shopping.

Thus, its NOT SAFE to be used on live sites, unless of course you want to encounter lost sales and poor customer experience while shopping.

Assuming that the php version is causing this as Aureanus asserts, I (for one) would be happy to trial a fix...I still get these irritating errors most days.

DrByte:

Therein is the problem. It is almost NEVER getting an array. The ONLY time it gets an array is when the product-notifications screen is presented. The zillion other times that the function is used there is no array passed at all.
I submit that your proposed fix is likely to cause the entire function to not return the right results, thus preventing normal operation of the majority of cases where this function is called.
Thus, its NOT SAFE to be used on live sites, unless of course you want to encounter lost sales and poor customer experience while shopping.

Fair point, then you just add a test for an array before it

A quick example is below

 

$valueStr=0
 
if (isarray($value)) { 
     $valueStr=count($value)
}else {
     $valueStr=strlen($value)
}

if ( (!in_array($key, $exclude_array)) && $valueStr > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) { 
          if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) { 

torvista:

Thanks for the interest.

This is exactly what I have in the live shop code:

   while (list($key, $value) = each($_GET)) {
  if (is_array($value)) trigger_error('GET param found to be array: ' . print_r($value, true) . '  --- contents of GET: ' . print_r($_GET, true));//steve looking for reason, as per http://www.zen-cart.com/forum/showthread.php?t=176804
    //if ( (strlen($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && (!in_array($key, $exclude_array)) && ($key != 'x') && ($key != 'y') ) {//steve original line 
if ( (!in_array($key, $exclude_array)) && (strlen($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {//steve this line edited to stop debug error as per http://www.zen-cart.com/forum/showthread.php?p=1070316#post1070316
      if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) {

You just forgot to remove the line containing trigger_error call.

You just forgot to remove the line containing trigger_error call.

You mean the debug was caused by the info, not the original fault!
Doh! :bangin:

What were the actual messages in the most recently logs? If they weren't text generated by the trigger_error() call you had in your code, then that's not the issue.

Since the solution posted in post 16, the debug "errors" have indeed just been the output of the error trigger, I just didn't think about it long enough to realise!

15-Dec-2011 15:45:48] PHP Notice: GET param found to be array: Array
(
[0] => 136
)
--- contents of GET: Array
(
[main_page] => index
[action] => notify
[notify] => Array
(
[0] => 136
)

)
in blah blah.

after a week running my upgrade to 1.5 I get this error again for the first time:
[31-Jan-2012 20:39:06] PHP Warning: strlen() expects parameter 1 to be string, array given in /home/XXXX/public_html/tienda/includes/functions/functions_general.php on line 152

FYI, from functions_general.php

 function zen_get_all_get_params($exclude_array = '', $search_engine_safe = true) {

    if (!is_array($exclude_array)) $exclude_array = array();

    $get_url = '';
    if (is_array($_GET) && (sizeof($_GET) > 0)) {
      reset($_GET);
      while (list($key, $value) = each($_GET)) {
        if ( (!in_array($key, $exclude_array)) && (strlen($value) > 0) && ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {
          if ( (SEARCH_ENGINE_FRIENDLY_URLS == 'true') && ($search_engine_safe == true) ) {
//    die ('here');
            $get_url .= $key . '/' . rawurlencode(stripslashes($value)) . '/';
          } else {
            $get_url .= zen_sanitize_string($key) . '=' . rawurlencode(stripslashes($value)) . '&';
          }
        }
      }
    }
    while (strstr($get_url, '&&')) $get_url = str_replace('&&', '&', $get_url);
    while (strstr($get_url, '&&')) $get_url = str_replace('&&', '&', $get_url);

    return $get_url;
  }
```Although the cause of the error has already been detailed previously I can confirm its the same:
  create a new customer
   make a purchase 
  and after checkout, when presented with the screen and the option to receive product updates (which is already ticked), click on update rather than logout.

I understand this error "doesn't matter" but as the fix included in 1.5 does not work (at least on my site), how can I stop this debug error being created (on most sales)?

Its the only fault I get and it's an unnecessary maintenance task to have to check and delete them continually.

Quick and dirty idea: if you and your customers don't actually use the product-notification feature, turn it off and/or delete that form from the checkout-success template, and then none of those inputs will trigger the problems you're complaining about.

Thanks. I appreciate this is a less than minor problem...and I'll avoid it as you suggest.
Nonetheless I am curious to know why the fix doesn't work (is it just my site?) or does it require a more complicated fix?
I am used to Zen Cart having no errors at all so this stands out.
regards
Steve