Zen Cart Logo
Forums / Bug Reports / [Not a bug] [1.5.0BETA] UTF-8 Charset

[Not a bug] [1.5.0BETA] UTF-8 Charset

Locked

Started by gob33 on 31 Jul 2011, 4:32 PM · Views: 2,284

Results 1 to 3 of 3
This thread is locked. New replies are disabled.
31 Jul 2011, 4:32 PM
#1
gob33 avatar

gob33

New Zenner

Join Date:
Jun 2008
Location:
Bordeaux, France
Posts:
69
Plugin Contributions:
3

[Not a bug] [1.5.0BETA] UTF-8 Charset

Not really a bug.
If you use UTF-8 as CHARSET in 1.5.0, they should not be iso-8859-1 anywhere for consistency. But found:

----------------------------------------
Find 'iso-8859-1' in 'ZENCART-1.5.0-BETA-07262011b\admin\alert_page.php':
ZENCART-1.5.0-BETA-07262011b\admin\alert_page.php(23): <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
----------------------------------------
Find 'iso-8859-1' in 'ZENCART-1.5.0-BETA-07262011b\includes\classes\class.phpmailer.php':
ZENCART-1.5.0-BETA-07262011b\includes\classes\class.phpmailer.php(44):   var $CharSet           = "iso-8859-1";
----------------------------------------
Find 'iso-8859-1' in 'ZENCART-1.5.0-BETA-07262011b\includes\functions\functions_email.php':
ZENCART-1.5.0-BETA-07262011b\includes\functions\functions_email.php(172):       $mail->CharSet =  (defined('CHARSET')) ? CHARSET : "iso-8859-1";
----------------------------------------
Find 'iso-8859-1' in 'ZENCART-1.5.0-BETA-07262011b\includes\templates\template_default\templates\tpl_zc_install_suggested_default.php':
ZENCART-1.5.0-BETA-07262011b\includes\templates\template_default\templates\tpl_zc_install_suggested_default.php(20): <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
----------------------------------------
Find 'iso-8859-1' in 'ZENCART-1.5.0-BETA-07262011b\zc_install\techsupp.php':
ZENCART-1.5.0-BETA-07262011b\zc_install\techsupp.php(49): <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">

Search complete, found 'iso-8859-1' 5 time(s). (5 file(s)).

A problem to take care is when sending exotic language chars through mail.

31 Jul 2011, 5:18 PM
#2
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,511
Plugin Contributions:
176

Re: [Not a bug] [1.5.0BETA] UTF-8 Charset

You're right. It's not a bug.
And none of those require any changes. Even the iso-8859-1 reference in functions_email is just a fallback to set a default if you haven't set one properly in your language file ... and if you haven't set one in your language file then emails are the last thing you need to be worrying about.
All the rest are simply static HTML pages and require no utf8 support.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

31 Jul 2011, 10:31 PM
#3
gob33 avatar

gob33

New Zenner

Join Date:
Jun 2008
Location:
Bordeaux, France
Posts:
69
Plugin Contributions:
3

Re: [Not a bug] [1.5.0BETA] UTF-8 Charset

Ok. Was just to check nothing wrong.
I said that after having probs sending chars with accents in french in emails on 1.3.9. If i used html special chars, they were displayed as &... in mails.

V1.5.0 gives me the possibilty to translate language files encoded in utf-8, so the defines used in mails would be without the &... I have not still checked if you use base64 or quoted-printable when building the mail. (Ive seen also a parameter in the mail class)