Forums / Bug Reports / [Done 2.0] 1.50beta h2 inside caption tag

[Done 2.0] 1.50beta h2 inside caption tag

Locked

Views: 939

Results 1 to 2 of 2
This thread is locked. New replies are disabled.
30 Aug 2011, 9:32 PM
#1
torvista avatar

torvista

Totally Zenned

Join Date:
Aug 2007
Location:
Gijón, Asturias, Spain
Posts:
2,876
Plugin Contributions:
7

[Done 2.0] 1.50beta h2 inside caption tag

as per this comment:
http://www.zen-cart.com/forum/showthread.php?p=561756

includes/templates/template_default/templates/tpl_account_default.php

Line 26

<table width="100%" border="0" cellpadding="0" cellspacing="0" id="prevOrders"> <caption><h2><?php echo OVERVIEW_PREVIOUS_ORDERS; ?></h2></caption> <tr class="tableHeading">

The h2 inside the caption tag is invalid XHTML.

This could be fixed by deleting the h2 tags and adding
#prevOrders caption
to the existing h2 declaration in the stylesheet, eg:

h2, #prevOrders caption {
font-size: 1.4em;
}

Or giving the caption its own id

<caption id="orderHistoryStatus"><?php echo OVERVIEW_PREVIOUS_ORDERS; ?></caption>

regards
Steve

ps. Why bother with all this validation pedantry?
Because a stock ZC site is one of the very few sites (not just shops) on the entire net that is actually 100% valid code, which is something to be proud of I think.

Steve
github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

2 Sep 2011, 9:01 PM
#2
blindside avatar

blindside

Totally Zenned

Join Date:
Sep 2004
Posts:
1,237
Plugin Contributions:
1

Re: [Done 2.0] 1.50beta h2 inside caption tag

We are using a new approach in coming versions, which will make this issue irrelevant. Furthermore, this will never come up on an XHTML validator because the page sits behind the login veil. If you are really concerned, simply use a template override.

Frank Koehl
"Cleverly Disguised as a Responsible Adult"

frankkoehl.com