Direct Bank Deposit

Hi,
Not sure if anyone is monitoring this thread but I'm having an error show after installing direct bank deposit.
I have ZC v1.5.7c and PHP 7.4.21.
I only have the FLAT rate option available to choose from for shipping.
Can anyone help me figure out why and how to fix?
On another note, would anyone also know how to replace (swift code details) to (PayID details) instead?
Thank you.

[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.#1  include(/home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php) called at [/home2//public_html/.com.au/admin/modules.php:200]#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_ADDRESS - assumed 'MODULE_SHIPPING_STOREPICKUP_ADDRESS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php on line 28.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  include(/home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php) called at [/home2//public_html/.com.au/admin/modules.php:200]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_ADDRESS - assumed 'MODULE_SHIPPING_STOREPICKUP_ADDRESS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php on line 30.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_SORT_ORDER - assumed 'MODULE_SHIPPING_STOREPICKUP_SORT_ORDER' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 55.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_TAX_CLASS - assumed 'MODULE_SHIPPING_STOREPICKUP_TAX_CLASS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 57.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_TAX_BASIS - assumed 'MODULE_SHIPPING_STOREPICKUP_TAX_BASIS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 58.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_STATUS - assumed 'MODULE_SHIPPING_STOREPICKUP_STATUS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 60.

Does the above error mean the "storepickup.php" in this plugin doesn't blend smoothly with the newer 1.5.7c version on php 7.4.21?
I've looked into both files and not sure exactly if all the changes in this plugin's storepickup.php file are all relevant, which might be causing my above errors?
Are the only parts that need to be merged over to the new 1.5.7c storepickup.php file are the 2 text email footer additions??

    $this->email_footer = MODULE_SHIPPING_STOREPICKUP_TEXT_EMAIL_FOOTER;


    function confirmation() {
      return array('title' => MODULE_SHIPPING_STOREPICKUP_TEXT_EMAIL_FOOTER);
    }

I'm now getting this error..

[23-Jul-2021 13:15:54 Australia/Sydney] Request URI: /admin/index.php?cmd=orders&origin=index&page=1&oID=20&action=update_order&language=en, IP address: 60.

#1  dirbankaus->update_status() called at [/home2//public_html/.com.au/includes/modules/payment/dirbankaus.php:41]
#2  dirbankaus->__construct() called at [/home2//public_html/.com.au/admin/orders.php:521]
#3  require(/home2//public_html/.com.au/admin/orders.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /home2//public_html/.com.au/includes/modules/payment/dirbankaus.php on line 50.

I looked in that folder on line 50 and line 100 and here are the line codes from those:

$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

function after_order_create($order_id) {      $this->email_footer = sprintf(MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER, $order_id);
    }

rlexyd:

I'm now getting this error..

[23-Jul-2021 13:15:54 Australia/Sydney] Request URI: /admin/index.php?cmd=orders&origin=index&page=1&oID=20&action=update_order&language=en, IP address: 60.

#1 dirbankaus->update_status() called at [/home2//public_html/.com.au/includes/modules/payment/dirbankaus.php:41]
#2 dirbankaus->__construct() called at [/home2//public_html/.com.au/admin/orders.php:521]
#3 require(/home2//public_html/.com.au/admin/orders.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /home2//public_html/.com.au/includes/modules/payment/dirbankaus.php on line 50.

> 
> I looked in that folder on line 50 and line 100 and here are the line codes from those:
> ```
$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

function after_order_create($order_id) { $this->email_footer = sprintf(MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER, $order_id);
}

I don't really see how/where line 100 came into concern, but what is being indicated is that at the point of attempting to identify the zone applicable to delivery of the item, it appears that there is no 'id' assigned to the delivery country. Perhaps was this a virtual product or download? May need to "work" around the operation in that area if so in some way to satisfy the intent of collecting the information...

Hi mc,
Thank you for your assistance.
I sometimes notice my php files get spaced out between each line, so just to be sure I put line 50 and 100 just incase this was spaced out with the error as well.

As for the item, it's a physical product.

The error log seems to generate everytime I click to go into an order details in admin, whether just going in or updating the status of the order etc..

I wonder if anyone has created the necessary files to accept Canadian Dollars ?
I did try (unsuccessfully) to modify the AUS files to use for CAD - when tested - I lost all my other currency options...
I use a company called "Wise" to facilitate accepting several countries currencies - and I have the following as details required for Canadian currency & banking system.

Account holder
Joe Bloggs

Institution number

Account number

Transit number

Bank address

***********, ********* ********* ** *** *** Canada

Anyone managed to achieve e this ?

Did you ever get a CAN version going?
I have Direct Banking working for AUS on zc 157d and now zc158.

Hi Nigel

Can we confirm dirbankusa will work on v1.5.8 and php8 ?
when deployed I only get a partial list of payment methods. (and no disbank)
I am in South Africa and hard wired the zone flag to true, but this may not be enough.
and changed "Routing" to Branch Code.

Thank you

Some background information would help.
Do you have a version of the plugin currently running and if so with which Zen Cart version and with which PHP version?

The downloadable version of Direct Bank Deposit has not been updated since 2017 and was really for pre Zen Cart 157 and PHP7.4

I may be able to assist as I have Direct Bank Deposit - AUS running with PHP8.2.
Many of the changes required for Zen Cart 158 and PHP 8.1 will be similar.

Thank you OldNGrey!
Sure that will work for us too if you got it working om PHP8.2 . Small changes I can do myself.
I "almost" have it working, but damn it, I cannot see what I am doing wrong.
Will appreciate your modules.
Email to [email protected] will be appreciated.
Very much!

Have a client using Direct Bank Deposit NZ with 1.5.7d and PHP 7.4 with the following error:

[24-Jan-2023 11:13:14 NZ] Request URI: /******/index.php?cmd=orders&page=1&oID=2156&action=update_order&language=NZ, IP address: ******
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:269]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Any thoughts to help them out?

Hi OldNGrey,
Running on 1.5.8 and PHP 8.0
My IP forced my to upgrade to 1.5.8 because they discontinued support for anything < PP8.0
And no, I now not have a working plugin.
So yes please, I will appreciate your plugins by any means you suggest.
Regards

dbltoe:

Have a client using Direct Bank Deposit NZ with 1.5.7d and PHP 7.4 with the following error:

[24-Jan-2023 11:13:14 NZ] Request URI: //index.php?cmd=orders&page=1&oID=2156&action=update_order&language=NZ, IP address: ******
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [//orders.php:269]
#3 require(//orders.php) called at [//index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

> 
> Any thoughts to help them out?
 
I think you need to be checking delivery country is set. Try changing approx line 48 from ```
if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {

to ```
if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) && isset($order->delivery['country']['id']) ) {

kokolo:

Thank you OldNGrey!
Sure that will work for us too if you got it working om PHP8.2 . Small changes I can do myself.
I "almost" have it working, but damn it, I cannot see what I am doing wrong.
Will appreciate your modules.
Email to [email protected] will be appreciated.
Very much!
I have placed an updated USA module of Direct Bank Deposit in my GitHub. https://github.com/OldNGreyBMR/direct_bank_deposit.

Please try it in a TEST environment.

If it works OK, it shouldn't be much work to create a South African variant for all to use.

OldNGrey:

I think you need to be checking delivery country is set. Try changing approx line 48 from ```
if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {

> to ```
      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) && isset($order->delivery['country']['id']) ) {

I have placed an updated NZ module of Direct Bank Deposit in my GitHub. https://github.com/OldNGreyBMR/direct_bank_deposit/tree/main/NZ/includes that works with ZC157d and ZC158 with PHP 7.4 to 8.2.

Please try it on a test system and let me know the outcome.

Thank you OldNGrey!
Loaded the three files from Github and get the following error:

PHP Fatal error: Uncaught Error: Undefined constant "MODULE_PAYMENT_DIRBANKNZ_DESCRIPTION" in /usr/www/users/koineepgvq/zz/includes/modules/payment/dirbanknz.php:35
Stack trace:....

This happens while the payment module list is being constructed and gets to "D"

I don't know why I am battling with such an simple thing. Started to think the problem is deeper because I get the same type of "undefined" error with the Netcash payment module. My shop in now down for some time without a proper payment module...imagine! Shop without a till!

Regards

You missed the essential line in the posting " Please try it on a test system ".

I have updated the 3 NZ files to match changes I made to the AUS code. The "MODULE_PAYMENT_DIRBANKNZ_DESCRIPTION" error I had previously overlooked has been corrected and references to cheques and money orders removed.

The NZ files are in my GitHub repository located at https://github.com/OldNGreyBMR/direct_bank_deposit/tree/main/NZ/includes

Copy the files to the correct locations; When the Admin Payment Modules page loads correctly, select "Direct-Bank-Deposit - New Zealand", Remove the Module, then Install it and set the values. This ensures that you are using the most recent version.

Please try it on a **test **system first before you place it in a production system

Thank you for you effort. Will test it. Obviously I am not wise enough as yet.

Hi OldNGrey,
It works perfectly! After I lifted my lazy backside and created a test environment to test first.
As reference I want to use the order number. How can I pick that up?
Can I get it from the session variables?
You don't have to do it, just give me a hint.

kokolo:

As reference I want to use the order number. How can I pick that up?
The order number is appended to the information when the order is confirmed by the customer.
The order number doesn't exist until that moment.
The confirmation email shows the bank details and a Reference eg "Reference: z_Test03-85-8414"; in this case z_Test03 is the customer last name, 85 is the customer ID number, 8414 is the order number.

On the order confirmation screen the customer sees the Reference: where the "%s" will be replaced by the order number.