query_factory.php on line 46 errors when upgrade from 150 to 151

Hi Guys,
Just updated to 151 from 150.

I am getting the below error log. I did have http://www.data-diggers.com/links-to-query-cache-query-log-uti-and-others/ Query Cache installed but I have overwritten these files (includes/classes/db/mysql/query_factory.php and includes/functions/functions_catagories.php) with the 151 versions.

[24-Sep-2012 21:13:12] PHP Parse error: syntax error, unexpected $end, expecting ')' in /home/nuganics/public_html/includes/classes/db/mysql/query_factory.php on line 46

I think line 46 in query_factory.php is
function connect($zf_host, $zf_user, $zf_password, $zf_database, $zf_pconnect = 'false', $zp_real = false) {

The site still loads as long as I use 150 version of /includes/auto_loaders/config.core.php and not the latest 151 version.

Kind regards
Tim

The query_factory.php file in Zen Cart v1.5.1 contains over 500 lines in it. Your error message says yours ends on line 46.
Sounds like a bad upload from your FTP program, or your site is using files that didn't come with original Zen Cart code.

Thank you for the reply DrByte. query_factory.php has 538 lines and the correct version in the header (viewed via ftp and deleted and uploaded again just to be sure). I just switched /includes/auto_loaders/config.core.php to the 151 version and I got the below errors also. init_canonical.php might not be a real error.

[24-Sep-2012 21:45:09] PHP Fatal error: Cannot redeclare class QueryCache in /home/nuganics/public_html/includes/classes/query_cache.php on line 16

which is class QueryCache {

[24-Sep-2012 21:44:43] PHP Fatal error: Call to undefined function zen_href_link() in ... various files

I reuploaded all the files again and I get 500 error as soon as I upload 151 version of /includes/auto_loaders/config.core.php and I get /includes/classes/query_cache.php on line 16 errors in log file folder.

The below files I didn't copy over into my active template but I don't think that will be a issue. I also looked at all the extensions I installed to see if any need to be fixed on for the new files uploaded but no changed as just cosmetic.

/includes/languages/english/html_includes/classic/define_main_page.php
/includes/languages/english/html_includes/define_main_page.php
/includes/templates/template_default/common/html_header.php
/includes/templates/template_default/common/tpl_header.php
/includes/templates/template_default/popup_search_help/tpl_main_page.php
/includes/templates/template_default/templates/tpl_account_default.php
/includes/templates/template_default/templates/tpl_contact_us_default.php
/includes/templates/template_default/templates/tpl_modules_create_account.php
/includes/templates/template_default/templates/tpl_product_reviews_write_default.php
/includes/templates/template_default/templates/tpl_zc_install_suggested_default.php

p.s would be great to have a 150 to 151 update pack :P

Any other ideas?

Kind regards
Tim

In admin when I go to view the customers or orders I get "WARNING: An Error occurred, please refresh the page and try again."

The error log is

[24-Sep-2012 23:04:28] PHP Fatal error: 1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'select o.orders_id, o.customers_id, o.customers_name, o.payment_method, o.shipp' at line 1 :: select count(select o.orders_id, o.customers_id, o.customers_name, o.payment_method, o.shipping_method, o.date_purchased, o.last_modified, o.currency, o.currency_value, s.orders_status_name, ot.text as order_total, o.customers_company, o.customers_email_address, o.customers_street_address, o.delivery_company, o.delivery_name, o.delivery_street_address, o.billing_company, o.billing_name, o.billing_street_address, o.payment_module_code, o.shipping_module_code, o.ip_address
from (zen_orders_status s, zen_orders o )
left join zen_orders_total ot on (o.orders_id = ot.orders_id and ot.class = 'ot_total')
where (o.orders_status = s.orders_status_id and s.language_id = '1') order by o.orders_id DESC) as total in /home/nuganics/public_html/includes/classes/db/mysql/query_factory.php on line 120

another one
[24-Sep-2012 23:03:59] PHP Fatal error: 1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'select p.order_id, p.paypal_ipn_id, p.txn_type, p.payment_type, p.payment_status' at line 1 :: select count(select p.order_id, p.paypal_ipn_id, p.txn_type, p.payment_type, p.payment_status, p.pending_reason, p.mc_currency, p.payer_status, p.mc_currency, p.date_added, p.mc_gross, p.first_name, p.last_name, p.payer_business_name, p.parent_txn_id, p.txn_id from zen_paypal as p left join zen_orders as o on o.orders_id = p.order_id order by p.paypal_ipn_id DESC) as total in /home/nuganics/public_html/includes/classes/db/mysql/query_factory.php on line 120

another one
[24-Sep-2012 23:03:55] PHP Fatal error: 1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'select * from zen_group_pricing) as total' at line 1 :: select count(select * from zen_group_pricing) as total in /home/nuganics/public_html/includes/classes/db/mysql/query_factory.php on line 120

Changing query_factory.php back to the 150 version doesn't fix it.

Server OS: Linux 3.2.28 Database: MySQL 5.5.23-55
HTTP Server: Apache
PHP Version: 5.2.17 (Zend: 2.2.0) PHP Memory Limit: 256M PHP Safe Mode: Off
PHP File Uploads: On Max Size: 64M POST Max Size: 64M

For those previously using Query Cache
The Zen Cart 1.5.1 version of Query Cache is quite a bit different from the version(s) released by data-diggers. Especially in terms of customized zen-cart files. It is not simply a "drag 1.5.1 files and overwrite". My advice is to remove the old data-diggers Query Cache files first.

What I ended up doing
Start with clean versions of all the Zen Cart 1.5.1 files. This includes removing customizations made to core Zen Cart files for older installations of Query_Cache and Query_Log. Then do a manual merge of all the files not including any changes from the previously installed Query Cache.

This also includes removing the qc_ functions which provide in memory caching... Site performance was better in my experience without these being used. Also I would advocate towards using the built-in mechanisms in Zen Cart 1.5 to provide local (in memory, database, file) caching where needed or desired.

Going through this process took care of all the issues I saw initially on my development site - the blank pages - SQL errors - missing content. I did also need to make a small set of patches for my environment - see the note below.

nuganics:

[24-Sep-2012 21:45:09] PHP Fatal error: Cannot redeclare class QueryCache in /home/nuganics/public_html/includes/classes/query_cache.php on line 16

Did you remove the autoloader and init_include files from the old Query Cache plugin / module?

Note:
If you also have defined 'SQL_CACHE_METHOD' in your configuration (or admin configuration) you may want to look at http://www.zen-cart.com/showthread.php?200484-Query-Factory - It contains some changes I ended up needing as I use both the query_cache and Zen Cart's built in cache.

Thank you for the reply. Removing the data-diggers files did get rid of the 500 errors Cheers lhungil.

I didn't have any data-diggers files in init_include files from the old Query Cache plugin / module.

I didn't install Query_Log so hopefully all good there.

I am still getting errors like the below when I go to view the customer or orders list.
[25-Sep-2012 21:31:54] PHP Fatal error: 1064:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'select o.orders_id, o.customers_id, o.customers_name, o.payment_method, o.shipp' at line 1 :: select count(select o.orders_id, o.customers_id, o.customers_name, o.payment_method, o.shipping_method, o.date_purchased, o.last_modified, o.currency, o.currency_value, s.orders_status_name, ot.text as order_total, o.customers_company, o.customers_email_address, o.customers_street_address, o.delivery_company, o.delivery_name, o.delivery_street_address, o.billing_company, o.billing_name, o.billing_street_address, o.payment_module_code, o.shipping_module_code, o.ip_address
from (zen_orders_status s, zen_orders o )
left join zen_orders_total ot on (o.orders_id = ot.orders_id and ot.class = 'ot_total')
where (o.orders_status = s.orders_status_id and s.language_id = '1') order by o.orders_id DESC) as total in /home/nuganics/public_html/includes/classes/db/mysql/query_factory.php on line 120

/admin/includes/configure.php has the below.

define('USE_PCONNECT', 'false');
define('STORE_SESSIONS', 'db');
// for STORE_SESSIONS, use 'db' for best support, or '' for file-based storage

// The next 2 "defines" are for SQL cache support.
// For SQL_CACHE_METHOD, you can select from: none, database, or file
// If you choose "file", then you need to set the DIR_FS_SQL_CACHE to a directory where your apache
// or webserver user has write privileges (chmod 666 or 777). We recommend using the "cache" folder inside the Zen Cart folder
// ie: /path/to/your/webspace/public_html/zen/cache -- leave no trailing slash
define('SQL_CACHE_METHOD', 'none');
define('DIR_FS_SQL_CACHE', '/home/nuganics/public_html/cache');

I changed it to file storage ad relogged in but got the same errors.

What should I try next as there are no more Query Cache plugin files?

Kind regards
Tim

It appears you still have some left over code in your files. better check for code changes made for query factory
Or maybe it is easier to just start with a clean 1.5.1 installation

Hi DrByte, lhungil, and Design75,
Just want to say thank you for your replies. Not sure what I did just overwrote all /admin/ with 1.5.1 files and working fine. I must have edited a admin file.

Thanks for the help.

Kind regards
Tim

ZC 1.5.1
multisite
Ultimate SEO

I constantly have the similar errors in my log files. I always points to line 120. Two of the logs are below. I do not use "data diggers" (if data diggers is a mod that needs to be installed. never heard of what it is until in here)
Can anyone tell me what is going wrong? MY sites does work but these error occasionally appears.

one error log:

[09-Nov-2013 06:21:22 America/New_York] PHP Fatal error: 2006:MySQL server has gone away :: select distinct p.products_id, p.products_image, pd.products_name, p.master_categories_id from (products p left join featured f on p.products_id = f.products_id left join products_description pd on p.products_id = pd.products_id) INNER JOIN categories_description cd
ON (p.master_categories_id = cd.categories_id
AND cd.language_id=1
AND cd.categories_description LIKE '%-robbor_green_BAM-%') where p.products_id = f.products_id and p.products_id = pd.products_id and p.products_status = 1 and f.status = 1 and pd.language_id = '1' and p.products_id in (3208, 3209, 3210, 3211, 3212, 3213, 3214, 3215, 3216, 3217, 3218, 3219, 3220, 3221, 3222, 3223, 3224, 3225, 3226, 3227, 3228, 3229, 3230, 3231) in /data/14/1/137/80/1300732/user/1392549/htdocs/MYSITE/includes/classes/db/mysql/query_factory.php on line 120

another error log:

[08-Nov-2013 17:52:59 America/New_York] PHP Fatal error: 0: :: SELECT parent_id FROM categories WHERE categories_id = 103 in /data/14/1/137/80/1300732/user/1392549/htdocs/MYSITE/includes/classes/db/mysql/query_factory.php on line 120

twi:

... one error log:

[09-Nov-2013 06:21:22 America/New_York] PHP Fatal error: 2006:MySQL server has gone away :: ...
The highlighted section in red is the error message being returned. This is quite a bit different from the other error messages listed in this thread....

The error message your query is showing typically means the connection to the MySQL server was disconnected by the server while Zen Cart was loading a page... Or PHP could not (re)initiate a connection to the MySQL server (while a page was loading)... Zen Cart typically re-tries the connection a few times before giving up...

Just to be on the safe side, double check the settings you have in both of your "configure.php" files and make sure they match the correct username, password, database, and server address for MySQL. If these are of you will constantly see such messages in the Zen Cat debug logs.

When this error is occurring intermittently with Zen Cart... The fix is usually a call to the hosting company. They can look into exactly what was causing the issue (with their HTTP server / PHP talking to their MySQL server). In some cases (after looking into the issues) I've had hosting providers report anything from needing to "restart" the server, they needed to adjust some settings for the MySQL server, they had another "shared account" hogging the CPU, were dealing with some current "attacks" against their servers, or they were working to address some issues with their servers / network...

I'd be leery of a hosting provider who could not help solve the issue... Or one where the issue intermittently keeps happening after it has been "fixed"... I've not yet had to ever call more than once about this type of issue in a one year time frame... And on most providers have never even run into this issue occurring on a regular basis while running Zen Cart).

If this is on your own installation of WAMP, LAMP, MAMP, etc... Make sure you have configured MySQL with a large enough setting for "max_allowed_packet". You can read more about other possible causes here.

Others may be able to shed additional light, but if this is happening on a hosted server.... The hosting provider will have access to additional logs and data helpful in determining what is happening.

Thanks again Andrew. You come to my rescue again. I will check the setting on both of my configure.php files to see if they are off or not with the setting.
If not then I will contact to host to look into this.

Thanks again.

lhungil:

The highlighted section in red is the error message being returned. This is quite a bit different from the other error messages listed in this thread....

The error message your query is showing typically means the connection to the MySQL server was disconnected by the server while Zen Cart was loading a page... Or PHP could not (re)initiate a connection to the MySQL server (while a page was loading)... Zen Cart typically re-tries the connection a few times before giving up...

Just to be on the safe side, double check the settings you have in both of your "configure.php" files and make sure they match the correct username, password, database, and server address for MySQL. If these are of you will constantly see such messages in the Zen Cat debug logs.

When this error is occurring intermittently with Zen Cart... The fix is usually a call to the hosting company. They can look into exactly what was causing the issue (with their HTTP server / PHP talking to their MySQL server). In some cases (after looking into the issues) I've had hosting providers report anything from needing to "restart" the server, they needed to adjust some settings for the MySQL server, they had another "shared account" hogging the CPU, were dealing with some current "attacks" against their servers, or they were working to address some issues with their servers / network...

I'd be leery of a hosting provider who could not help solve the issue... Or one where the issue intermittently keeps happening after it has been "fixed"... I've not yet had to ever call more than once about this type of issue in a one year time frame... And on most providers have never even run into this issue occurring on a regular basis while running Zen Cart).

If this is on your own installation of WAMP, LAMP, MAMP, etc... Make sure you have configured MySQL with a large enough setting for "max_allowed_packet". You can read more about other possible causes here.

Others may be able to shed additional light, but if this is happening on a hosted server.... The hosting provider will have access to additional logs and data helpful in determining what is happening.

Checked the settings on both configure.php files. both have identical configurations. I will contact the host concerning this issue and see if they can fix it.

Also, Could it have something to do with the files involved in My multisite module? Please see below. Correct me if I am wrong. Based on my deductive reasoning, this might not be the problem. Otherwise the site might create the error all the time other than intermittently.

// Define the MULTISITE V1.0 parameters BY 2mk
// NOTE:: PER INSTALLATION INSRUCTION STEP 14 OF MULTISITE V1.0
include_once('includes/config_sites/sites_switch.php');

twi:

Checked the settings on both configure.php files. both have identical configurations. I will contact the host concerning this issue and see if they can fix it.

Also, Could it have something to do with the files involved in My multisite module? ...
Not sure as I do not use that module... If the module was causing similiar issues I'd except to see a fair amount of messages here on the forums... But you never know... Hopefully your host can look at the date/time when the error message is reported and help track down why PHP is intermittently reporting it lost the connection to MySQL (and Zen Cart's code to retry the request ran into the same problem)...

lhungil:

Not sure as I do not use that module... If the module was causing similiar issues I'd except to see a fair amount of messages here on the forums... But you never know... Hopefully your host can look at the date/time when the error message is reported and help track down why PHP is intermittently reporting it lost the connection to MySQL (and Zen Cart's code to retry the request ran into the same problem)...

Thanks. I will have to see what the host say and shed some light on the topic if they give me a answer to this.

lhungil:

Not sure as I do not use that module... If the module was causing similiar issues I'd except to see a fair amount of messages here on the forums... But you never know... Hopefully your host can look at the date/time when the error message is reported and help track down why PHP is intermittently reporting it lost the connection to MySQL (and Zen Cart's code to retry the request ran into the same problem)...

This is what they have to say on the situation:

Sorry about your MySQL issue. I don't see the error on the site. This error can happen when you have to many connections to the database. Please make sure you are closing the database connections quickly, instead of leaving them open for read/writes. If you have any questions regarding this Service Request, you can chat directly with our Technical Support team by clicking on the following link: http://ts.chatwithsupport.net

I am puzzled at what is given as a explanation. Does he mean me logging in to the database using phpMyAdmin ? Or he is the puzzled one?

Means the hosting provider LIMITS how many connections one can have open to the MySQL server... Sounds like they are more taking a "stab" in the dark then actually monitoring the server (and looking at logs) to determine the cause... I'd "think" long and hard about looking at a new hosting provider...

Zen Cart can end up with many connections open at one time depending upon how many requests to view the site / admin are happening at the same time (and if the hosting provider's systems / communications between PHP and MySQL are slow). The usual "fix" is just switching providers...

You can TRY the following change (so you can tell your provider your script does manually close connections)... Keep in mind I have not tested this on a production site, so if you make the change you may want to watch your site closely... And if the warnings go away (for at least a month) please let us all know!

Add the following function (shown in red) to the end of the query_factory class:

  function __destruct() {
    $this->close();
  }
}

class queryFactoryResult {

lhungil:

Means the hosting provider LIMITS how many connections one can have open to the MySQL server... Sounds like they are more taking a "stab" in the dark then actually monitoring the server (and looking at logs) to determine the cause... I'd "think" long and hard about looking at a new hosting provider...

Zen Cart can end up with many connections open at one time depending upon how many requests to view the site / admin are happening at the same time (and if the hosting provider's systems / communications between PHP and MySQL are slow). The usual "fix" is just switching providers...

I would agree with this.. I once had a client with a similar issue, and the host used to tell her this was the issue and all but refused to check their server logs to determine the cause.. the "fix" was to change hosts..

Here's the funny thing, one day AFTER we switched hosts, I got a "follow-up" call from the old hosting provider informing me that they had "solved" the problem.. They informed me that they had been "monitoring" my client's site performance and were happy to report that the site's load time had improved and was no longer showing signs of the performance issues we were reporting.. I very calmly told the poor tech guy that I was not surprised about the improved performance given that my client was no longer hosting her site with them.. I could almost hear his jaw hit his desk..:laugh:

lhungil:

Means the hosting provider LIMITS how many connections one can have open to the MySQL server... Sounds like they are more taking a "stab" in the dark then actually monitoring the server (and looking at logs) to determine the cause... I'd "think" long and hard about looking at a new hosting provider...

Zen Cart can end up with many connections open at one time depending upon how many requests to view the site / admin are happening at the same time (and if the hosting provider's systems / communications between PHP and MySQL are slow). The usual "fix" is just switching providers...

You can TRY the following change (so you can tell your provider your script does manually close connections)... Keep in mind I have not tested this on a production site, so if you make the change you may want to watch your site closely... And if the warnings go away (for at least a month) please let us all know!

Add the following function (shown in red) to the end of the query_factory class:

http://www.zen-cart.com/images/smilies/bigups.gif

function __destruct() {
$this->close();
}
}

class queryFactoryResult {

Thanks.  so I always thought it was a problem with my install.  in fact it is a problem at the hosting side due to limitations.  A few months ago I was going to switch host when I had the problem with paypal module on the day I took my fully tested site online.   The problem persisted an entire week.  But somehow someone else with the same problem contacted my host (and his host, (netsol) and his problems got fixed while mine was also fixed.  I will definitely think about switching.

DivaVocals:

I would agree with this.. I once had a client with a similar issue, and the host used to tell her this was the issue and all but refused to check their server logs to determine the cause.. the "fix" was to change hosts..

Here's the funny thing, one day AFTER we switched hosts, I got a "follow-up" call from the old hosting provider informing me that they had "solved" the problem.. They informed me that they had been "monitoring" my client's site performance and were happy to report that the site's load time had improved and was no longer showing signs of the performance issues we were reporting.. I very calmly told the poor tech guy that I was not surprised about the improved performance given that my client was no longer hosting her site with them.. I could almost hear his jaw hit his desk..:laugh:

Thanks for shedding more light on the situation. I am actually really fed up with my current host. Most of the responses seems nothing but patronization instead of really looking and checking for a solution. I am not surprise on the incident you are telling us here. It's just confirmed my suspicion that they (some hosts) just give you an answer for the sake of giving an answer. :(