Testimonial Manager Support Thread (for ZC v1.5.x)

Coins2012:

We are still on version 1.5.2 and ZC 1.50, lately I am getting spam testimonials from registered customers, I think these are paid people that create account and put spam testimonials, I am having a hard time finding the customer that wrote the testimonials so that I could block him/her from logging in to the account.

The same thing was happening to us on an epidemic level. I tried everything. Finally I seemed to completely eliminate the problem by installing a simple CAPTCHA into the form. The testimonial will now only submit if the person types a matching number from the CAPTCHA.

That's something you might want to look into implementing to see if it helps/

Latest version of TM has avatar manager that is broken also testimonial uploaded images are being saved as

Submited image: includes/classes/observers/auto.vat_for_eu_countries.php

DigitalShadow:

Latest version of TM has avatar manager that is broken also testimonial uploaded images are being saved as

Submited image: includes/classes/observers/auto.vat_for_eu_countries.php

Please read the posting guidelines and provide more info... not having any issues with it.

Do you have mod Vat for EU countries installed?

DigitalShadow:

Do you have mod Vat for EU countries installed?

no, but installed on a test site zc156c php7.3 with TM. Added the Vat mod and All works.. The script for images is setup to re-code image to strip out location info and ML bugs, then renames them for storage.. All done before sending to your server.

I'm not running php 7+ due to a problem with the paypal code since 1.5.5 for payflow uk

Any chance the problem is with php 5.6.40?

DigitalShadow:

I'm not running php 7+ due to a problem with the paypal code since 1.5.5 for payflow uk

Any chance the problem is with php 5.6.40?

Yes... Although untested, everything in the image rewrite PHP says is supported in php5 - 7+ however, I think the sql statements may throw errors too.. I don't have anything older then php7.2 installed right now to test with...

davewest:

Yes... Although untested, everything in the image rewrite PHP says is supported in php5 - 7+ however, I think the sql statements may throw errors too.. I don't have anything older then php7.2 installed right now to test with...

Blast!

The issue only happens if the customer doesn't select to upload an image, if I choose to upload an image it works as expected, however if no image is uploaded the submitted image is saved as

Submited image:
includes/classes/observers/auto.vat_for_eu_countries.php

instead of a blank value

Also noted that when a testimonial is submitted the avatar is being saved with a double // in the database

So file saved as

avatars//img_01.jpg

DigitalShadow:

Blast!

The issue only happens if the customer doesn't select to upload an image, if I choose to upload an image it works as expected, however if no image is uploaded the submitted image is saved as

Submited image:
includes/classes/observers/auto.vat_for_eu_countries.php

instead of a blank value

I can not recreate the errors to even get a image save to come closes to that folder.. I don't see any configurations that would allow for that type of a cross up. I would switch off the image upload for now... I would guess theirs something going on with the old php that does not agree with the code.

avatars setting in admin, remove the ending / or at lest check for doubles..

DigitalShadow:

Also noted that when a testimonial is submitted the avatar is being saved with a double // in the database

So file saved as

avatars//img_01.jpg

ok... so.. testimonials are sent with a selected avatar and not uploaded.. only an image of user selection is uploaded to go with the words... Avatars as at_10.png, only the at_#.png is allowed to be selected. This protects user submitted avatars which can only be uploaded within a logged in account holder, if you installed that addon code section.. not required. without, users can not add there own avatars.

If you say img_#.jpg, then that would suggest you have the account addon installed..

In testimonial config is the setting to change/modify upload and avatar folder names/location.

davewest:

In testimonial config is the setting to change/modify upload and avatar folder names/location.

If i remove the "/" from the avatar location in the admin then the avatars no longer show in the popup circle. I had to edit header_php in testimonials_add to put the "/" back in

$dir = 'images/' . TESTIMONIAL_IMAGE_DIRECTORY . '/';

v1.5.5f php7.1 Testimonials v1.5.4 Westminster_New

Hi Dave,

so wondering if you can help me with this - on a mobile phone testimonials are showing up at the beginning of every category page, before category heading. How can I stop this from happening - using Westminster_New template however I haven't configured testimonials to show - I have testimonials sidebox switched on and it is the testimonial in that sidebox that is showing - any relationship there?

cheers,
Mike

shags38:

v1.5.5f php7.1 Testimonials v1.5.4 Westminster_New

Hi Dave,

so wondering if you can help me with this - on a mobile phone testimonials are showing up at the beginning of every category page, before category heading. How can I stop this from happening - using Westminster_New template however I haven't configured testimonials to show - I have testimonials sidebox switched on and it is the testimonial in that sidebox that is showing - any relationship there?

cheers,
Mike

Dave please disregard the above - amazing how as you are explaining a problem and providing information to someone that you start thinking about the problem differently - SHAZZAAMMMM !! .... it was a simple thing of a box ticked when it shouldn't have been ticked in sideboxes configuration (you know, the sidebox I mentioned above :) )

I hope you are doing well.

cheers,
Mike

Users with MySQL 5.7 or higher: note that the table creation used in admin/includes/functions/extra_functions/testimonials_manager_functions.php needs to be changed from

      date_added DATETIME NOT NULL DEFAULT '0000-00-00 00:00:00',

to

      date_added DATETIME NOT NULL DEFAULT '0001-01-01 00:00:00',

Dave, do you want the Github Repo for

https://www.zen-cart.com/downloads.php?do=file&id=299

to be set to

https://github.com/davesaddle/Testimonial-Manager

?

swguy:

Dave, do you want the Github Repo for

https://www.zen-cart.com/downloads.php?do=file&id=299

to be set to

https://github.com/davesaddle/Testimonial-Manager

?

Actually.. now that you brought it to my mind front.. the errors are in how the date code is used and sensitized in admin/testimonials_manager.php that's in error.. I need to fix how it's used... the database change would be a band aid only.

I'll put down my Python3 cook book and get an update sent in... Or was there an issue with database mySQL versions!

The default value for the date should be as it was..

date_added DATETIME NOT NULL DEFAULT '0000-00-00 00:00:00',

The problem was in code I was testing for and setting a 0001-01-01 00:00:00 which is wrong.. I was stupid in my thinking when copying code.. We actually need to set a NOW date and not the 0001 thingy or even test for it... This also sets up the date picker correctly for now and not in the past or to far into the future.

Fixed in admin and add testimonial.. Date/time default now is used and not empty during SQL query's.
Fixed a bug in contact radio fields admin/testimonials_manager.php
Fixed an issue in add testimonial with avatar selection adding a double // in the image address.
Some code clean-up for responsive admin.. I like buttons to stay handy on any size screen.

I updated Github, but like to run a test install before uploading a copy here..

This does not work in MySQL 5.7. That's why there's a file called zero_dates_cleanup.sql in zc_install - to fix the old defaults of 0000-00-00 to 0001-01-01.

swguy:

This does not work in MySQL 5.7. That's why there's a file called zero_dates_cleanup.sql in zc_install - to fix the old defaults of 0000-00-00 to 0001-01-01.

My bad... what happens when you're cracking one and rushing through another.. More to the point, this is not a problem with code, but a new version of MySQL and strict mode specifically NO_ZERO_DATE thingy... which I didn't read up on until now.. which I now have some others to fix... well update it with a sniffer for upgrades... thanks.