Zen Cart Logo
Forums / Bug Reports / coupon_admin.php contains double p tag

coupon_admin.php contains double p tag

Views: 1,142

Results 1 to 4 of 4
28 Oct 2012, 3:02 PM
#1
design75 avatar

design75

Totally Zenned

Join Date:
Dec 2009
Location:
Amersfoort, The Netherlands
Posts:
2,862
Plugin Contributions:
5

coupon_admin.php contains double p tag

I am not sure in which version this started, but in Zen Cart 1.5.1 the language file coupon_admin.php (location: admin/includes/language/english/),contains two defines with a double <p> tag (line 51 and 52)

define('TEXT_COUPON_HELP_DATE', '<p><p>The coupon is valid between %s and %s</p></p>');
define('HTML_COUPON_HELP_DATE', '<p><p>The coupon is valid between %s and %s</p></p>');

This should be

define('TEXT_COUPON_HELP_DATE', '<p>The coupon is valid between %s and %s</p>');
define('HTML_COUPON_HELP_DATE', '<p>The coupon is valid between %s and %s</p>');
10 Nov 2012, 5:00 PM
#2
webmeister avatar

webmeister

New Zenner

Join Date:
Oct 2012
Posts:
49
Plugin Contributions:
0

Re: coupon_admin.php contains double p tag

Found it in 1.5 - does it make any difference to remove or not?

14 Nov 2012, 2:45 AM
#4
drbyte avatar

drbyte

Sensei

Join Date:
Jan 2004
Posts:
63,513
Plugin Contributions:
176

Re: coupon_admin.php contains double p tag

In practice it's harmless. It won't break anything.

The duplication will be removed in a future version.

But if you're asking whether it's something you should lose sleep over, it's not. It's like the lowest level of urgency.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.