lat9:
The 'base' checkout_process code has no idea what the requirements of the selected payment method are, that's why your (and @balihr's) bypass of the checkout_confirmation page's processing caused issues. As I noted before, OPC's "Payment Methods that handle submit" configuration setting enables OPC to bypass its auto-submit of the checkout_confirmation page for payment modules so configured.
this is everything that is wrong, IMO, with this payment module and the checkout flow.
we have a page called checkout_payment. and yet stripe does nothing/little on that page?
i look at this section of code:
https://github.com/lat9/stripe/blob/7becdd955a5695502ebf495a8f719b8ec9ac4914/includes/modules/payment/stripe.php#L140-L163
and there is no validation of a valid stripe payment or anything of the sort.
so you want to force this payment flow to work the way that you want? ignoring what zc provides for the payment?
it seems you want to use the checkout_confirmation page for a payment. that is not really what the base checkout code gives developers.
as i have previously noted in OPC (which i am not sure why you are bringing OPC up in this thread), order totals do NOT match when doing a standard 3 page checkout v OPC. as i have also noted, you get around this quandary by putting in observers in your paypalr module to accommodate this seeming inconsistency. while i have clients that use OPC, i hardly love it.
payment modules should not have to jump through hoops for their use. nor should they require observers to get them to work with OPC v. 3 page checkout.
i will no longer comment on this thread. there are far too many issues, IMO, for this modules use. if other people can get it to work, great. but it is not for me.
i had a client who wanted to implement stripe. after going over the particulars about its use with him, he has decided to not pursue it.
i will further note that my code does NOTHING of the sort that you say. it does NOT bypass checkout confirmation. having javascript submit a form on a checkout confirmation page is not what i would call bypassing the page. bypassing said page would require far too much modification of core ZC code, of which i am loathe to do.
author of square Webpay, now with Apple Pay and Google Pay.
mXworks
donations: venmo or paypal accepted.
premium consistent excellent support. available for hire.